blender/blender
151
479
Fork 711
Code Issues 6.7k Pull Requests 904 Projects 18 Wiki Activity

NLA Strip influence slider doesn't respond to autokey correctly. #76549

New Issue
Open
opened 2020-05-08 14:43:14 +02:00 by Tal Hershkovich · 13 comments
Tal Hershkovich commented 2020-05-08 14:43:14 +02:00
Copy Link

System Information
Operating system: Win 10
Graphics card: GeForce GTX 1070

Blender Version
Broken: 2.82 Release

Short description of error

The Influence property of the NLA's strip, has some strange behavior and something that might be a bug.
This was reported before in #63865, which was supposedly resolved, but the problem still exists

When changing the value of the influence slider with the autokey turned on, it jumps back to its previous value and does not update to the new one. After repeating it 2 or 3 times it applies the value. When applying the value numerically it works fine, it seems to be a problem with the update of the slider.
Moreover, when turning influence on it always adds a keyframe to the first frame of the action (where the action is on the timeline ). It sets a keyframe with the value 0, instead of the current value.

Exact steps for others to reproduce the error

  • Open attached file
  • Select one of the Action strips.
  • In the Sidebar, go to {nav Strip > Active Strip} and turn on Animated Influence. (Note that a keyframe is added to the first frame of the action).
  • Go to a new frame with the Autokey turned on, change the value of the influence slider.
  • Go to a new frame - the value should jump back to the previous one

I've made a short video which describes the errors
https://www.youtube.com/watch?v=Sh5MwYCH9T4

Sample file:

Influence_bugreport.blend

**System Information** Operating system: Win 10 Graphics card: GeForce GTX 1070 **Blender Version** Broken: 2.82 Release **Short description of error** The Influence property of the NLA's strip, has some strange behavior and something that might be a bug. This was reported before in #63865, which was supposedly resolved, but the problem still exists When changing the value of the influence slider with the autokey turned on, it jumps back to its previous value and does not update to the new one. After repeating it 2 or 3 times it applies the value. When applying the value numerically it works fine, it seems to be a problem with the update of the slider. Moreover, when turning influence on it always adds a keyframe to the first frame of the action (where the action is on the timeline ). It sets a keyframe with the value 0, instead of the current value. **Exact steps for others to reproduce the error** - Open attached file - Select one of the Action strips. - In the Sidebar, go to {nav Strip > Active Strip} and turn on `Animated Influence`. (Note that a keyframe is added to the first frame of the action). - Go to a new frame with the Autokey turned on, change the value of the influence slider. - Go to a new frame - the value should jump back to the previous one I've made a short video which describes the errors https://www.youtube.com/watch?v=Sh5MwYCH9T4 Sample file: [Influence_bugreport.blend](https://archive.blender.org/developer/F8520583/Influence_bugreport.blend)
Tal Hershkovich commented 2020-05-08 14:43:14 +02:00
Author
Copy Link

Added subscriber: @TalHershkovich

Added subscriber: @TalHershkovich
Robert N. commented 2020-06-25 10:37:36 +02:00
Copy Link

Added subscriber: @RobertN

Added subscriber: @RobertN
Wayde Moss commented 2020-10-29 18:13:49 +01:00
Member
Copy Link

Added subscriber: @wbmoss_dev

Added subscriber: @wbmoss_dev
Wayde Moss commented 2020-10-29 18:13:49 +01:00
Member
Copy Link

This is tagged to the wrong module. It should be Animation & Rigging and User Interface. Separate bugs should be reported separately too.

This is tagged to the wrong module. It should be Animation & Rigging and User Interface. Separate bugs should be reported separately too.
Omar Emara commented 2022-03-09 12:31:22 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Brad Clark commented 2022-03-09 18:48:13 +01:00
Member
Copy Link

Added subscriber: @BClark

Added subscriber: @BClark
Brad Clark commented 2022-03-09 19:09:53 +01:00
Member
Copy Link

I can confirm there are some issues and or settings that make this seem like a bug.

  1. The first time you turn on Animated Influence, there is an auto key of value 0 added to the first frame of the action, so not just frame 0 but where ever the action is on the timeline.
  2. Animated Strip Time, doesn't have the same bug/issues as Animated Influnces so maybe the code there can be used to fix Animated Influence.
  3. If you then delete the keys from Animated Influence, the next time you turn it on or of, there are not any keys created at 0 for the action. Now it waits to auto key it until the slider is moved.
  4. Slider display - If you move the slider to set the value and the key is created, what ever that first value is that gets keyframed, is now the only value the slider displays when moving the playback head. even if you are on a key, the value shown in the slider isn't the value of the kefyrame unless you update that value by some other way (clicking key button next to the slider, enter the value in the fcurve editor etc) then the slider refreshes and shows the correct values.
I can confirm there are some issues and or settings that make this seem like a bug. 1. The first time you turn on Animated Influence, there is an auto key of value 0 added to the first frame of the action, so not just frame 0 but where ever the action is on the timeline. 2. Animated Strip Time, doesn't have the same bug/issues as Animated Influnces so maybe the code there can be used to fix Animated Influence. 3. If you then delete the keys from Animated Influence, the next time you turn it on or of, there are not any keys created at 0 for the action. Now it waits to auto key it until the slider is moved. 4. Slider display - If you move the slider to set the value and the key is created, what ever that first value is that gets keyframed, is now the only value the slider displays when moving the playback head. even if you are on a key, the value shown in the slider isn't the value of the kefyrame unless you update that value by some other way (clicking key button next to the slider, enter the value in the fcurve editor etc) then the slider refreshes and shows the correct values.
Brad Clark commented 2022-03-09 19:10:16 +01:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Needs Triage'

Changed status from 'Confirmed' to: 'Needs Triage'
Omar Emara commented 2022-03-10 14:24:48 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Robert Sunny commented 2022-03-13 09:03:52 +01:00
Copy Link

Added subscriber: @robertsunny

Added subscriber: @robertsunny
Philipp Oeser removed the
Interest
Animation & Rigging
 label 2023-02-09 14:36:13 +01:00
Nathan Vegdahl commented 2023-05-08 12:05:17 +02:00
Member
Copy Link

Confirmed that this is still the case in latest main, and marking as a bug.

I can't see any reasonable way this could be an intended behavior. If a property is changed and that triggers a new key via auto-key, the resulting key should be the value set by the user.

Confirmed that this is still the case in latest `main`, and marking as a bug. I can't see any reasonable way this could be an intended behavior. If a property is changed and that triggers a new key via auto-key, the resulting key should be the value set by the user.
👍 1
Nathan Vegdahl added
Type
Bug
 and removed
Type
Report
 labels 2023-05-08 12:05:30 +02:00
Nate Rupsis commented 2023-08-25 19:26:28 +02:00
Member
Copy Link

Okay, so pretty confident that this is related to #89339. Basically, when keying the influence, the value that's actually recorded is the currently value of the fcurve, and not the RNA property value.

The update method in the influence rna property was commented out as a hackish fix, so there are some underlying issues here.

Okay, so pretty confident that this is related to [#89339](https://projects.blender.org/blender/blender/issues/89339). Basically, when keying the influence, the value that's _actually_ recorded is the currently value of the fcurve, and not the RNA property value. The update method in the influence rna property was commented out as a [hackish fix](https://projects.blender.org/blender/blender/src/branch/main/source/blender/makesrna/intern/rna_nla.cc#L908), so there are some underlying issues here.
Nate Rupsis commented 2023-09-14 18:54:05 +02:00
Member
Copy Link

Finding:
There are some major underlying issues with the NLA influence & strip_time properties. These properties never get updates, which allows the value to actually get taken into account, since on evaluation, the rna property to actually get written is the fcurve value

Discussed in 2023-09-14 Animation & Rigging module meeting. Since this has been around for a while (based on 6mo bug triaging rules), we're deprioritizing this from a bug to a known issue.

The new animation system will solve the need for this.

Finding: There are some major underlying issues with the NLA influence & strip_time properties. These [properties](https://projects.blender.org/blender/blender/src/branch/main/source/blender/makesrna/intern/rna_nla.cc#L912) never get updates, which allows the value to actually get taken into account, since on [evaluation](https://projects.blender.org/blender/blender/src/branch/main/source/blender/makesrna/intern/rna_nla.cc#L912), the rna property to actually get written is the [fcurve](https://projects.blender.org/blender/blender/src/branch/main/source/blender/blenkernel/intern/anim_sys.cc#L574) value Discussed in [2023-09-14](https://devtalk.blender.org/t/2023-09-14-animation-rigging-module-meeting-upcoming/31122) Animation & Rigging module meeting. Since this has been around for a while (based on 6mo bug triaging rules), we're deprioritizing this from a bug to a known issue. The [new animation system](https://code.blender.org/2023/07/animation-workshop-june-2023/) will solve the need for this.
Nate Rupsis added
Type
Known Issue
 and removed
Type
Bug
 labels 2023-09-14 18:55:48 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
8 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#76549
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?