Sequencer: restructuring the code layout #77580
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
16 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#77580
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Note: This is initial proposal aimed to gather feedback. It is subject to change.
This is task to coordinate restructurization of majority of VSE code.
Goal is to break existing code to smaller files with relatively narrow scope, create layer isolating low-level BKE code from functions close to user (operators, RNA, drawing). There should be minimum functional changes in first stages, followed by cleanups with minor functional changes if necessary (logic consolidation).
Motivation:
Since this will be relatively large operation, it will have to be done in few stages:
18d7aeacf2
3baf65975c
0f43fe7fa6
01db805a82
a5a302bd18
e5df87b1b9
ea1c5a6c15
2a6a26bbd7
046ca0749a
8ec6b34b8e
9e4a4c2e99
13ca11ac52
Added subscriber: @iss
Added subscriber: @ankitm
Added subscriber: @StanislavOvcharov
Added subscriber: @razcore
Added subscriber: @pistolario
Added subscriber: @ManuelAlbert
Added subscriber: @Pipeliner
Added subscriber: @DuarteRamos
Added subscriber: @AndyCuccaro
Added subscribers: @brecht, @Sergey
Generally is super nice to have sequencer better organized from the code point of view, and de-duplicate logic as much as possible.
As for the locations of the files I don't think they belong to editors. Editor API should not be used by render pipeline, for example. To me it seems that sequencer should become more top-level folder, like
compositor
is, and used by render pipeline, sequencer space and so on.As for the approach of how to structure the changes:
Moving files can happen as a bulk operation, since that'd be annoying to keep incrementally modify entire source code. Splitting up and other changes try to keep as isolated as possible, in a stream of commits.
For the planing, it seems like this is an involved change, and we have quite reasonable amount of reports which doesn't seem to be requiring such refactor. To me it seems for 2.90 is better to do stabilization pass, and aim this refactor for 2.91. Hence i'll place this to 2.91 column. Surely, some work can start early on, but finalized (with all the cleanup and de-duplication you've mentioned) is unlikely to happen for 2.90 due to time constraints.
This is my vision anyway. Since there is some source layout/etc involved, wouldn't mind if @brecht shares his strong opinion :)
+1 to everything @Sergey said.
Thanks for input, I agree with all points here, so I will change description with more discrete steps that can be checked out. Will have to look at compositor code organization, but I suspect that I will probably want to keep alloc/free functions in BKE if I wanted to make strip a ID at some point.
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @VincentGires
Added subscriber: @tintwotin
Just curious, as I see a lot of files being moved around now for this project, but has the advantages of moving the Sequencer data out of Scene data, so Scenes can be switched without switching Sequencer contents, and vice versa, been taken into consideration?
{F8860684, size = full}
Some of the benefits:
{F8860669, size=full}
More on the advantages here on RCS: https://blender.community/c/rightclickselect/kWbbbc/
I fully support Peter's proposal of moving the sequencer out of the scene. I've been thinking a lot lately about how the sequencer fits into the Blender file/scene hierarchy (and I'll make a mockup of some ideas I have on this and on the compositor as soon as I can).
In the end, the sequence should be the final step of the production, no? Thus, I think it's more logical to have the sequence be the "parent" of the many scenes within the blend file than the other way around. And, like Peter mentions in his proposal, it could open the gates for a more streamlined workflow for storyboarding, for example.
Please, please consider doing this change.
This task is purely about restructuring the code layout, please move discussion about changes to functionality elsewhere.
Gigantic VSE refactorto Sequencer: restructing the code layoutSequencer: restructing the code layoutto Sequencer: restructuring the code layoutIt has been at RCS since aug. 2018, but no devs there to discuss it: https://blender.community/c/rightclickselect/kWbbbc/
Added subscriber: @ideasman42
As of
18d7aeacf2
there is:./source/blender/sequencer/BKE_sequencer.h
(outside of./source/blender/blenkernel
).I think we shouldn't leave partially finished module re-arrangement in this state.
While multiple commits to move and rename can be OK, it's leaving a mess to keep a module split-up and spread across different directories - longer term.
I will clean up that file on one or two commits (split + rename).
There will be still bunch fo functions with BKE prefix, so unless this is done in one go, there will have to be undesirable state for some time.
I will try to resolve this state in first place and as quickly as I can. I already got one file split, but perhaps it would be better to start with
BKE_sequencer.h
actually - it would make subsequent splits even easier.Added subscriber: @ok_what