Pressing undo unwantedly changes the active grease pencil tool #77719

System Information
Operating system: Darwin-19.3.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 580 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.5.5

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-06 14:18, hash: aed11c673e

Short description of error
Pressing undo unwantedly changes the active grease pencil tool.

Exact steps for others to reproduce the error

draw a grease pencil stroke.
switch to sculpt>push mode and alter the stroke.
press undo twice.
the active tool is now draw again (expected to remain on sculpt>push).

video showing what happens here: https://www.youtube.com/watch?v=BUH2wHr-3tw

this seems related to https:*developer.blender.org/T59544 and https:*developer.blender.org/T57750

Added subscriber: @info-27

Added subscribers: @mont29, @antoniov

I'm not sure what you expect, but the Undo is a "walk" in reverse direction of your previous steps, so if your steps are Draw->Change Mode->Sculpt the undo must be Sculpt->Change Mode->Draw

@mont29 What do you think of this?

hi Antonio. What i was expecting is that the 'active' tool/mode was independent of the undo stack (and wouldn't be changed when undoing).

This is the way it works with all other drawing/painting apps i remember using (Photoshop, Flash/Animate, Toon Boom Harmony, TVPaint, Clip Studio Paint).

Here's a video demonstrating how it's arranged in photoshop for instance https://youtu.be/yBoxrgZVMj4

More context: the grease pencil tools do work as i expected (active tool not affected by undoing) when the tools that were used before undoing were all part of the same mode (e.g. drawing and erasing). Looks like active-tool independence from undo stack was adjusted in response to this issue https://developer.blender.org/T57750

But currently when tools from different modes are used, undoing those steps adjusts the active tool and mode. This seems inconsistent.

Added subscriber: @slinkous

I like that that happens, so I'd recommend a setting where you can either enable or disable that in user prefs.

Added subscriber: @mano-wii

Changed status from 'Needs Triage' to: 'Archived'

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior.
I suggest discussing this elsewhere like devtalk: https://devtalk.blender.org/

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Pressing undo unwantedly changes the active grease pencil tool #77719