ShaderFx Missing Update Notifier #77730

New Issue

Closed

opened 2020-06-10 18:09:16 +02:00 by Hans Goudey · 6 comments

Hans Goudey commented

2020-06-10 18:09:16 +02:00

Member

Blender Version
Broken: Since ShaderFX were added
Worked: Never

Short description of error
Changing shaderFX and using their operators sends update notifications for modifiers. Presumably this is because the modifier code was duplicated without changing these lines. See these lines in object_shaderfx.c:
WM_event_add_notifier(C, NC_OBJECT | ND_MODIFIER, ob);
The properties area is only updated per tab, and since shaderFX added a new tab, there should be a corresponding ND_SHADERFX as well.

Exact steps for others to reproduce the error

Have two different property areas with the effects tab open.
Change data in one area
See the other area not update
gpencil_effect_bug-2020-06-10_12.03.57.mp4

**Blender Version** Broken: Since ShaderFX were added Worked: Never **Short description of error** Changing shaderFX and using their operators sends update notifications for modifiers. Presumably this is because the modifier code was duplicated without changing these lines. See these lines in `object_shaderfx.c`: ` WM_event_add_notifier(C, NC_OBJECT | ND_MODIFIER, ob);` The properties area is only updated per tab, and since shaderFX added a new tab, there should be a corresponding `ND_SHADERFX` as well. **Exact steps for others to reproduce the error** 1. Have two different property areas with the effects tab open. 2. Change data in one area 3. See the other area not update [gpencil_effect_bug-2020-06-10_12.03.57.mp4](https://archive.blender.org/developer/F8606203/gpencil_effect_bug-2020-06-10_12.03.57.mp4)

Hans Goudey commented

2020-06-10 18:09:16 +02:00

Author

Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly

Hans Goudey commented

2020-06-10 18:09:50 +02:00

Author

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Antonio Vazquez commented

2020-06-10 19:16:08 +02:00

Member

Added subscriber: @antoniov

Added subscriber: @antoniov

Antonio Vazquez commented

2020-06-10 19:16:08 +02:00

Member

Yes, It looks a copy & paste error.

Yes, It looks a copy & paste error.

blender-admin commented

2020-07-06 19:17:07 +02:00

This issue was referenced by a856de700b

This issue was referenced by a856de700b4274ebc1735aa349f7425c7c23cbfc

Hans Goudey commented

2020-07-06 19:17:29 +02:00

Author

Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2020-07-06 19:17:29 +02:00

Hans Goudey self-assigned this 2020-07-06 19:17:29 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#77730

No description provided.