GPencil: Compositing different sized scenes with grease pencil crushes Blender #77885

New Issue

takaaki takeda · 2020-06-15T15:43:45+02:00

takaaki takeda commented

2020-06-15 15:43:45 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: 211b6c29f7
Worked: (newest version of Blender that worked as expected)

Short description of error
Compositing different sized scenes with grease pencil crushes blender.

For exmple, mixing two render layers in composite node, from Scene.A and Scene.B,
with different resolutions (640x360 and 960x540) crushes blender if active scene is Scene.A, smaller one.
If Scene.B is active, Grease pencil is composed strangely, as an image below.

Exact steps for others to reproduce the error
Open blender and make a new scene in addition to the default one.
(Rename Scene.A and Scene.B for simplicity)

Change the resolution of the scene.
(640x360 and 960x540, for example)

Set basic objects like camera and light for new secene.
Make grease pencil object and draw some strokes for both scene.

Open Compositor and enable composition node tree.
Make render layer from both scenes and mix them as an image below.

(Note that setting for for both scenes are needed.).

If active scene is Scene.A (smaller one), rendering crushes blender.
If active scene is Scene.B, grease pencil looks strangely.
The image looks as if that the size is evaluated wrongly.

I attacht simple .blend file with above setup.
DiffSizeSimple.blend
render in Scane.A crushes blender (at least on my PC).

If grease pencil objects are removed, non-grease pencil object images are composed correctly

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86 **Blender Version** Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: `211b6c29f7` Worked: (newest version of Blender that worked as expected) **Short description of error** Compositing different sized scenes with grease pencil crushes blender. For exmple, mixing two render layers in composite node, from Scene.A and Scene.B, with different resolutions (640x360 and 960x540) crushes blender if active scene is Scene.A, smaller one. If Scene.B is active, Grease pencil is composed strangely, as an image below. ![DifferentSizeImage.png](https://archive.blender.org/developer/F8621115/DifferentSizeImage.png) **Exact steps for others to reproduce the error** Open blender and make a new scene in addition to the default one. (Rename Scene.A and Scene.B for simplicity) Change the resolution of the scene. (640x360 and 960x540, for example) Set basic objects like camera and light for new secene. Make grease pencil object and draw some strokes for both scene. Open Compositor and enable composition node tree. Make render layer from both scenes and mix them as an image below. ![CompositDifferentSize.png](https://archive.blender.org/developer/F8621129/CompositDifferentSize.png) (Note that setting for for both scenes are needed.). If active scene is Scene.A (smaller one), rendering crushes blender. If active scene is Scene.B, grease pencil looks strangely. The image looks as if that the size is evaluated wrongly. I attacht simple .blend file with above setup. [DiffSizeSimple.blend](https://archive.blender.org/developer/F8621164/DiffSizeSimple.blend) render in Scane.A crushes blender (at least on my PC). If grease pencil objects are removed, non-grease pencil object images are composed correctly

takaaki takeda commented

2020-06-15 15:43:45 +02:00

Added subscriber: @popqjp

Antonio Vazquez changed title from ~~Comositing different sized scenes with grease pencil crushes Blender~~ to Compositing different sized scenes with grease pencil crushes Blender

2020-06-15 15:56:45 +02:00

Antonio Vazquez commented

2020-06-15 15:56:45 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Antonio Vazquez commented

2020-06-15 15:57:51 +02:00

Added subscribers: @fclem, @antoniov

Antonio Vazquez commented

2020-06-15 15:57:51 +02:00

@fclem could you please take a look at this issue? you know better than me this area of the code.

Antonio Vazquez changed title from ~~Compositing different sized scenes with grease pencil crushes Blender~~ to GPencil: Compositing different sized scenes with grease pencil crushes Blender

2020-06-15 15:58:22 +02:00

Antonio Vazquez commented

2020-06-15 19:53:54 +02:00

Added subscriber: @lichtwerk

Antonio Vazquez commented

2020-06-15 19:53:54 +02:00

@lichtwerk Not sure if it's really a GPencil issue or it's a problem with compositing.

Vincent Blankfield commented

2020-06-16 03:22:32 +02:00

Added subscriber: @VincentBlankfield

Vincent Blankfield commented

2020-06-16 03:22:32 +02:00

This looks similar to ce09b93955 to me. In this case the solution would be:

diff --git a/source/blender/draw/intern/draw_manager.c b/source/blender/draw/intern/draw_manager.c
index 10ef8d9c4c8..1b76b8c873c 100644
--- a/source/blender/draw/intern/draw_manager.c
+++ b/source/blender/draw/intern/draw_manager.c
@@ -1701,7 +1701,7 @@ void DRW_render_gpencil(struct RenderEngine *engine, struct Depsgraph *depsgraph
   drw_context_state_init();

   DST.viewport = GPU_viewport_create();
-  const int size[2] = {(r->size * r->xsch) / 100, (r->size * r->ysch) / 100};
+  const int size[2] = { engine->resolution_x, engine->resolution_y };
   GPU_viewport_size_set(DST.viewport, size);

   drw_viewport_var_init();

But perhaps refactoring the duplicated code would be even better. The code in DRW_render_gpencil is almost identical to DRW_render_to_image with minor differences, and it's not immediately clear whether these differences are intentional or not.

This looks similar to ce09b93955 to me. In this case the solution would be: ``` diff --git a/source/blender/draw/intern/draw_manager.c b/source/blender/draw/intern/draw_manager.c index 10ef8d9c4c8..1b76b8c873c 100644 --- a/source/blender/draw/intern/draw_manager.c +++ b/source/blender/draw/intern/draw_manager.c @@ -1701,7 +1701,7 @@ void DRW_render_gpencil(struct RenderEngine *engine, struct Depsgraph *depsgraph drw_context_state_init(); DST.viewport = GPU_viewport_create(); - const int size[2] = {(r->size * r->xsch) / 100, (r->size * r->ysch) / 100}; + const int size[2] = { engine->resolution_x, engine->resolution_y }; GPU_viewport_size_set(DST.viewport, size); drw_viewport_var_init(); ``` But perhaps refactoring the duplicated code would be even better. The code in `DRW_render_gpencil` is almost identical to `DRW_render_to_image` with minor differences, and it's not immediately clear whether these differences are intentional or not.

Antonio Vazquez commented

2020-06-16 09:04:40 +02:00

Added subscriber: @Jeroen-Bakker