Grease Pencil Objects Override 3D View Hotkeys. #78628

Closed
opened 3 years ago by TheCGCy · 21 comments

System Information
Operating system: MacOS 10.13.6
Graphics card: Nvidia GTX 970

Blender Version
Broken: 2.83.1

Short description of error
Grease Pencil Objects will replace and messing up 3D View Hotkeys. Causing returning to object or edit mode not work until the grease pencil object is deleted. Also with grease pencil, you cannot assign hotkey to change draw mode.

Exact steps for others to reproduce the error
Create a blank grease pencil and switch to Draw Mode. All set object mode hotkey will be broken. Re-adding hotkeys doesn't work afterwards because all modes will be always be binded in to 1 single key. Object, Edit, Sculpt, Draw etc will treat as 1 mode.

Screen Shot 2020-07-05 at 1.14.11 PM.png Screen Shot 2020-07-05 at 1.17.16 PM.png

Update:
Steps to reproduce: Create Grease Pencil Stroke > Select Grease pencil object > Switch to Draw mode > Save new Keymap

Blender.mp4

**System Information** Operating system: MacOS 10.13.6 Graphics card: Nvidia GTX 970 **Blender Version** Broken: 2.83.1 **Short description of error** Grease Pencil Objects will replace and messing up 3D View Hotkeys. Causing returning to object or edit mode not work until the grease pencil object is deleted. Also with grease pencil, you cannot assign hotkey to change draw mode. **Exact steps for others to reproduce the error** Create a blank grease pencil and switch to **Draw Mode**. All set object mode hotkey will be broken. Re-adding hotkeys doesn't work afterwards because all modes will be always be binded in to 1 single key. Object, Edit, Sculpt, Draw etc will treat as 1 mode. ![Screen Shot 2020-07-05 at 1.14.11 PM.png](https://archive.blender.org/developer/F8665957/Screen_Shot_2020-07-05_at_1.14.11_PM.png) ![Screen Shot 2020-07-05 at 1.17.16 PM.png](https://archive.blender.org/developer/F8665960/Screen_Shot_2020-07-05_at_1.17.16_PM.png) **Update:** Steps to reproduce: **Create Grease Pencil Stroke** > **Select Grease pencil object** > **Switch to Draw mode** > **Save new Keymap** [Blender.mp4](https://archive.blender.org/developer/F8680330/Blender.mp4)
Poster

Added subscriber: @TheCGCy

Added subscriber: @TheCGCy
iss commented 3 years ago
Collaborator

Added subscriber: @iss

Added subscriber: @iss
iss commented 3 years ago
Collaborator

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'
iss commented 3 years ago
Collaborator

I am not sure what the problem is.

Did you create those shortcuts? How are they broken? What should I do to reproduce this issue?

I am not sure what the problem is. Did you create those shortcuts? How are they broken? What should I do to reproduce this issue?

Added subscriber: @Imaginer

Added subscriber: @Imaginer

@iss I think those shortcuts are from the Industry Compatible keymap.

@iss I think those shortcuts are from the Industry Compatible keymap.
iss commented 3 years ago
Collaborator

Even in industry compatible keymap, I can't reproduce this

Even in industry compatible keymap, I can't reproduce this
Poster

Yeah, it's a slight modify of Industry compatible keys. But it behaves the same with Blender default too. With grease pencil selected. You wont able to switch or assign other modes with hotkeys. It gets replace to blank key maps. Selecting other polygon object restores it.

Try assign a keymap to "Draw" mode in preference. Other previously "object.mode_set" assigned keypmaps with have their "Mode" become blank. If you save this keymap, it'll becomes blank next time you restart blender or switching keymaps.

Yeah, it's a slight modify of Industry compatible keys. But it behaves the same with Blender default too. With grease pencil selected. You wont able to switch or assign other modes with hotkeys. It gets replace to blank key maps. Selecting other polygon object restores it. Try assign a keymap to "**Draw**" mode in preference. Other previously "**object.mode_set**" assigned keypmaps with have their "**Mode**" become blank. If you save this keymap, it'll becomes blank next time you restart blender or switching keymaps.
Poster

Here's the demonstration of the issue. If you save the keymaps while in Draw mode. All other keymaps will mess up next blender starts.
Blender Draw mode bug.m4v

Here's the demonstration of the issue. If you save the keymaps while in **Draw** mode. All other keymaps will mess up next blender starts. [Blender Draw mode bug.m4v](https://archive.blender.org/developer/F8680212/Blender_Draw_mode_bug.m4v)
iss commented 3 years ago
Collaborator

Does this happen with keymap without any modification?

Does this happen with keymap without any modification?
Poster

Yes, both Blender Default and Industry Compatible keymaps, but Blender default doesn't have Draw hotkey binded as far as I know. Even vanilla IC keymaps are unable to switch to Draw mode by pressing 4. Since it's sharing a same keybind as object mode. If reassign Draw mode to keys like 9 for example, Object mode will be assign to 9 as well.
Screen Shot 2020-07-09 at 3.48.51 PM.png

Here's what happen if you save a new set of keymap if grease pencil is selected. Both Blender default's tab edit key, or Industrial Compatible Keymaps 1~7 all will become object mode. The video shows everything is assigned to 4 & 3 key

Steps to reproduce: Create Grease Pencil Stroke > Select Grease pencil object > Switch to Draw mode > Save new Keymap

Blender.mp4

Yes, both Blender Default and Industry Compatible keymaps, but Blender default doesn't have **Draw** hotkey binded as far as I know. Even vanilla IC keymaps are unable to switch to **Draw** mode by pressing **4**. Since it's sharing a same keybind as object mode. If reassign **Draw** mode to keys like **9** for example, Object mode will be assign to **9** as well. ![Screen Shot 2020-07-09 at 3.48.51 PM.png](https://archive.blender.org/developer/F8680324/Screen_Shot_2020-07-09_at_3.48.51_PM.png) Here's what happen if you save a new set of keymap if grease pencil is selected. Both Blender default's tab edit key, or Industrial Compatible Keymaps 1~7 all will become object mode. The video shows everything is assigned to **4** & **3** key Steps to reproduce: **Create Grease Pencil Stroke** > **Select Grease pencil object** > **Switch to Draw mode** > **Save new Keymap** [Blender.mp4](https://archive.blender.org/developer/F8680330/Blender.mp4)
iss commented 3 years ago
Collaborator

I am quite confused here.

When I select GP object keymap is set to reflect GP options.
When I select mesh, keymap will change again to reflect options for mesh.

No functionality is pernamently lost. That is with unmodified keymap

If you change this keymap it may no longer work as it should - that is limitation and it is not considered to be a bug. That's why I was asking if this happens with unmodified keymap.

I am quite confused here. When I select GP object keymap is set to reflect GP options. When I select mesh, keymap will change again to reflect options for mesh. No functionality is pernamently lost. That is with unmodified keymap If you change this keymap it may no longer work as it should - that is limitation and it is not considered to be a bug. That's why I was asking if this happens with unmodified keymap.
Poster

This comment was removed by @TheCGCy

*This comment was removed by @TheCGCy*
Poster

By default you means it's unmodified keys come with Blender. No it doesn't work at all. I have tested it by remove addons folders and factory reset all preference. Default IC keymap by Default cannot switch to Draw mode by pressing 4 but can press 4 to toggle back to object mode. Blender Default keys tabbing will toggle between edit and draw mode however.

More issues comes when save as new key set, even if you didn't modify anything, no additional, no removed keys, just save a brand new set it'll just replace all "object.mode_set" modes automatically. That definite is not intended right?

To clarify, the last video I demoed is with unmodified default keys. The bug affect both Blender default and IC keymaps

By default you means it's unmodified keys come with Blender. No it doesn't work at all. I have tested it by remove addons folders and factory reset all preference. Default IC keymap by Default cannot switch to **Draw** mode by pressing **4** but can press **4** to toggle back to object mode. Blender Default keys tabbing will toggle between edit and draw mode however. More issues comes when save as new key set, even if you didn't modify anything, no additional, no removed keys, just save a brand new set it'll just replace all "object.mode_set" modes automatically. That definite is not intended right? To clarify, the last video I demoed is with unmodified default keys. The bug affect both Blender default and IC keymaps
iss commented 3 years ago
Collaborator

I have looked at the video, but draw mode is always assigned to key 1 in my case, never to key 4.

As I said, this automatic change functionality is not supported with exported keymaps. As soon as you export keymap it should be "frozen" to state in which it was exported unless you change it manually.

I have looked at the video, but draw mode is always assigned to key 1 in my case, never to key 4. As I said, this automatic change functionality is not supported with exported keymaps. As soon as you export keymap it should be "frozen" to state in which it was exported unless you change it manually.
Poster

It's definite key 4, you might stumble one of the issue I mentioned.

  1. GP objects's Object mode and Draw mode is sharing 1 same key, you change Draw mode keys, Object mode will follows. You change Draw mode to 9, Object mode will also change to 9. This is why blender doesn't recognize draw mode because it's object mode always takes priority.

  2. Like you said. auto change functionality isnt supported, But saving hotkeys with GP objects selected will affect regular object "modes" hotkeys like edit, vertex paint etc to re-assigned to key 3. To avoid this, I have to make sure selecting polygon objects first before saving changes, but this will cause any GP object hotkeys to reassign to 3 in return.

At this stage, I cannot make any modification without scrambling GP hotkeys or vice versa. They are like having 2 conflicting rules. I really dont think this is intended design, shouldn't all unique keys supposed to be individual? They dont seems to sharing similar keys either, they are like pretending to be nice with each other until I declare a key set.

It's definite key 4, you might stumble one of the issue I mentioned. 1) GP objects's **Object mode** and **Draw mode** is sharing **1 same key**, you change Draw mode keys, Object mode will follows. You change Draw mode to 9, Object mode will also change to 9. This is why blender doesn't recognize draw mode because it's object mode always takes priority. 2) Like you said. auto change functionality isnt supported, But saving hotkeys with GP objects selected will affect regular object "modes" hotkeys like edit, vertex paint etc to re-assigned to key 3. To avoid this, I have to make sure selecting polygon objects first before saving changes, but this will cause any GP object hotkeys to reassign to 3 in return. At this stage, I cannot make any modification without scrambling GP hotkeys or vice versa. They are like having 2 conflicting rules. I really dont think this is intended design, shouldn't all unique keys supposed to be individual? They dont seems to sharing similar keys either, they are like pretending to be nice with each other until I declare a key set.
iss commented 3 years ago
Collaborator

In #78628#976708, @TheCGCy wrote:
It's definite key 4, you might stumble one of the issue I mentioned.

  1. GP objects's Object mode and Draw mode is sharing 1 same key, you change Draw mode keys, Object mode will follows. You change Draw mode to 9, Object mode will also change to 9. This is why blender doesn't recognize draw mode because it's object mode always take priority.

This shouldn't be the case and I can't reproduce this behavior:
Untitled.png

  1. Like you said. auto change functionality isnt supported, But saving hotkeys with GP objects selected will affect regular object "modes" hotkeys like edit, vertex paint etc to re-assigned to key 3. To avoid this, I have to save it by selecting polygon objects to make sure it return to normal, but this will cause any GP object hotkeys to reassign to 3 in return. Both of them is not compatible.

In this stage, I cannot make any modification without scrambling GP hotkeys or vice versa. They are like having 2 conflicting rules.

That is correct, you would have to have conflicting rules. Such behavior is not supported in custom keymaps. There are "workarounds" like custom operators that would look at what object is selected and do the decision, so replicating that behavior is not impossible. It is bit more involved though.

> In #78628#976708, @TheCGCy wrote: > It's definite key 4, you might stumble one of the issue I mentioned. > > 1) GP objects's **Object mode** and **Draw mode** is sharing 1 same key, you change Draw mode keys, Object mode will follows. You change Draw mode to 9, Object mode will also change to 9. This is why blender doesn't recognize draw mode because it's object mode always take priority. This shouldn't be the case and I can't reproduce this behavior: ![Untitled.png](https://archive.blender.org/developer/F8683783/Untitled.png) > 2) Like you said. auto change functionality isnt supported, But saving hotkeys with GP objects selected will affect regular object "modes" hotkeys like edit, vertex paint etc to re-assigned to key 3. To avoid this, I have to save it by selecting polygon objects to make sure it return to normal, but this will cause any GP object hotkeys to reassign to 3 in return. Both of them is not compatible. > > In this stage, I cannot make any modification without scrambling GP hotkeys or vice versa. They are like having 2 conflicting rules. That is correct, you would have to have conflicting rules. Such behavior is not supported in custom keymaps. There are "workarounds" like custom operators that would look at what object is selected and do the decision, so replicating that behavior is not impossible. It is bit more involved though.
Poster

This shouldn't be the case and I can't reproduce this behavior:

It is after a new keymap is created. I guess the issue is the per object keymap causing this.

So unless Keymap editor getting rework it's pretty much dead in the water huh? Should I file a feature request instead?

>This shouldn't be the case and I can't reproduce this behavior: It is after a new keymap is created. I guess the issue is the per object keymap causing this. So unless Keymap editor getting rework it's pretty much dead in the water huh? Should I file a feature request instead?
iss commented 3 years ago
Collaborator

Changed status from 'Needs User Info' to: 'Archived'

Changed status from 'Needs User Info' to: 'Archived'
iss closed this issue 3 years ago
iss self-assigned this 3 years ago
iss commented 3 years ago
Collaborator

You can definitely file feature request. I don't have very strong knowledge of keymap implementation, but just thinking about this abstractly there will have to be some scripting involved. Be it in keymap itself or in form of addon. This is because some people will want their exported keymap to be completely static, some will want "their favourite" features and not others and some will want all features from original keymap. This is not really easy to implement while making it user friendly.

Now exported keymap is truly just export - that is dumped dict of operator names with properties mapped to keys, and that is intended functionality.

So because there doesn't seem to be any bug, I will close this report. Thanks for reporting though.

You can definitely file feature request. I don't have very strong knowledge of keymap implementation, but just thinking about this abstractly there will have to be some scripting involved. Be it in keymap itself or in form of addon. This is because some people will want their exported keymap to be completely static, some will want "their favourite" features and not others and some will want all features from original keymap. This is not really easy to implement while making it user friendly. Now exported keymap is truly just export - that is dumped dict of operator names with properties mapped to keys, and that is intended functionality. So because there doesn't seem to be any bug, I will close this report. Thanks for reporting though.
Poster

Thank you for your time too. I'd say current implementation is less than ideal. If an exported keyset are replacing or modify other non related keys. I still think this is an issue needs to resolve in a way.

Thank you for your time too. I'd say current implementation is less than ideal. If an exported keyset are replacing or modify other non related keys. I still think this is an issue needs to resolve in a way.
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Pose Library Basics
legacy project/Retrospective
legacy project/Tracker Curfew
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#78628
Loading…
There is no content yet.