Missing DNA Defaults ("Reset to Default Value" sets to 0) #80164

Open
opened 2 years ago by JulianEisel · 30 comments
Collaborator

Since f5e0dfe59c, we have a simple & practical way of setting up defaults for DNA data. These defaults are used for the "Reset to Default Value" operator, available in the context menu for buttons.
Here's a helper script to extract the defaults: https://stackoverflow.com/a/55368203/432509

There are still a number of properties that don't have a default assigned. These can be reported here.

Note that these missing defaults typically appear in "groups" because the entire data-structure misses the default value definition. In that case there's no need to list each individual value, just mention where they are (e.g. Armature object, relation settings).

Since f5e0dfe59c, we have a simple & practical way of setting up defaults for DNA data. These defaults are used for the "Reset to Default Value" operator, available in the context menu for buttons. Here's a helper script to extract the defaults: https://stackoverflow.com/a/55368203/432509 There are still a number of properties that don't have a default assigned. These can be reported here. Note that these missing defaults typically appear in "groups" because the entire data-structure misses the default value definition. In that case there's no need to list each individual value, just mention where they are (e.g. Armature object, relation settings).
Poster
Collaborator

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Poster
Collaborator

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Owner

#99109 was marked as duplicate of this issue

#99109 was marked as duplicate of this issue
Owner

#93656 was marked as duplicate of this issue

#93656 was marked as duplicate of this issue

Added subscriber: @Gilberto.R

Added subscriber: @Gilberto.R

In the render properties tab, i think that Simplify is missing Default values for render and grease pencil dropdowns. Also Cycles tile sizes differ from startup file value after resetting.
In Output Properties tab it defaults output color to BW instead of RGB.
In Scene Properties tab it's missing default value for Units.
In Object Properties tab it's missing for Relations and Motion Paths.
It's also missing default values for constraints.

In the render properties tab, i think that Simplify is missing Default values for render and grease pencil dropdowns. Also Cycles tile sizes differ from startup file value after resetting. In Output Properties tab it defaults output color to BW instead of RGB. In Scene Properties tab it's missing default value for Units. In Object Properties tab it's missing for Relations and Motion Paths. It's also missing default values for constraints.

Added subscriber: @NicolaSap

Added subscriber: @NicolaSap

All the sockets (including RGBA sockets, dropdowns, etc) default to 0.000 (or first element in the list¹) in all the nodes.

¹Only excepton I've found is that, in ColorRamp, interpolation correctly defaults to "Linear"

Peek 2020-09-01 09-39.gif

Edit: Maybe the issue with nodes is based on a different root cause, so probably this is not the right Task? See also: #76704

All the sockets (including RGBA sockets, dropdowns, etc) default to 0.000 (or first element in the list¹) in all the nodes. ¹Only excepton I've found is that, in ColorRamp, interpolation correctly defaults to "Linear" ![Peek 2020-09-01 09-39.gif](https://archive.blender.org/developer/F8829161/Peek_2020-09-01_09-39.gif) Edit: Maybe the issue with nodes is based on a different root cause, so probably this is not the right Task? See also: #76704

Added subscriber: @blenderrocket

Added subscriber: @blenderrocket
Collaborator

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Collaborator

After some recent commits this should be working in more places:

There is still much more work to do. Maybe these commits could serve as helpful examples for anyone who wants to help out by making similar changes.

After some recent commits this should be working in more places: - d3b59d1358 - d6f409b862 - d3ba60b132 - e900f6ed14 - c3238bd500 - 8398050695 There is still much more work to do. Maybe these commits could serve as helpful examples for anyone who wants to help out by making similar changes.

Added subscriber: @ketanjainn

Added subscriber: @ketanjainn
ketanjainn self-assigned this 2 years ago

This comment was removed by @ketanjainn

*This comment was removed by @ketanjainn*
ketanjainn removed their assignment 2 years ago
Collaborator

Added subscriber: @sidd017

Added subscriber: @sidd017
Collaborator

Hi, Default values for radius and strength in brush properties of SculptDraw brush and detail size under dyntopo also seem to have incorrect default values. I'm new to Blender development and since this is a good first issue, I tried looking into this.

  • Radius : default on startup is 50px and reset to default value sets it to 0

  • Strength : default on startup is 0.5 and reset to default value sets it to 1

  • Dyntopo -> Detail Size : default on startup is 12.00px and reset to default value sets it to 0.00px (did annoy me a lot when I first tried sculpting)

From what I understand, default values are now defined under DNA_brush_defaults.h, but when I tried changing them it had no effect. The properties still had the old default values. I suspect some other implementation is overriding the DNA defaults, probably related to #47618 . Changing defaults like particle settings in DNA_particle_defaults.h, also seems to have no effect.
Can someone help me understand why changing default values in DNA_brush_defaults.h has no effect?

Hi, Default values for radius and strength in brush properties of SculptDraw brush and detail size under dyntopo also seem to have incorrect default values. **I'm new to Blender development** and since this is a **good first issue**, I tried looking into this. - Radius : default on startup is 50px and reset to default value sets it to 0 - Strength : default on startup is 0.5 and reset to default value sets it to 1 - Dyntopo -> Detail Size : default on startup is 12.00px and reset to default value sets it to 0.00px (did annoy me a lot when I first tried sculpting) From what I understand, default values are now defined under DNA_brush_defaults.h, but when I tried changing them it had no effect. The properties still had the old default values. I suspect some other implementation is overriding the DNA defaults, probably related to #47618 . Changing defaults like particle settings in DNA_particle_defaults.h, also seems to have no effect. Can someone help me understand why changing default values in DNA_brush_defaults.h has no effect?

Added subscriber: @gaurivn

Added subscriber: @gaurivn

I would like to work on this issue.

I would like to work on this issue.

Added subscriber: @George540

Added subscriber: @George540

This comment was removed by @George540

*This comment was removed by @George540*

Hi! I'm new to the Blender Development group and I decided to tackle this issue.

Currently changing the rna defaults for Simplify (Render Settings inCycles). The default for Texture limit dropdowns for Render and Viewport panels are at No Limit. Is that the correct default? If that's not the case, I think setting it to 2048 is ideal, since image textures already have a default size of 2048x2048 px

Hi! I'm new to the Blender Development group and I decided to tackle this issue. Currently changing the **rna defaults for Simplify** (Render Settings in**Cycles**). The default for Texture limit dropdowns for Render and Viewport panels are at *No Limit*. Is that the correct default? If that's not the case, I think setting it to 2048 is ideal, since image textures already have a default size of 2048x2048 px
Collaborator

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Collaborator

Not sure if VSE can use this system? If so, then Sequence needs to be covered, see #90406 (VSE: The blend and opacity settings that strips are created with does not match the default values they revert back to)

Not sure if VSE can use this system? If so, then `Sequence` needs to be covered, see #90406 (VSE: The blend and opacity settings that strips are created with does not match the default values they revert back to)
Collaborator

Added subscriber: @OrestisKonstantinidis

Added subscriber: @OrestisKonstantinidis

Added subscriber: @SHREY-AGGARWAL

Added subscriber: @SHREY-AGGARWAL

Added subscriber: @SteffenD

Added subscriber: @SteffenD

Added subscriber: @Diogo_Valadares

Added subscriber: @Diogo_Valadares
Collaborator

Added subscriber: @OmarEmaraDev

Added subscriber: @OmarEmaraDev
Collaborator

UnitSettings in DNA_scene needs default values. See #99109.

`UnitSettings` in `DNA_scene` needs default values. See #99109.
Collaborator

Added subscriber: @pixeltrain3d

Added subscriber: @pixeltrain3d

Added subscriber: @ralphw

Added subscriber: @ralphw
Sign in to join this conversation.
No Label
good first issue
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/2.81
legacy project/2.82
legacy project/2.83
legacy project/2.90
legacy project/2.91
legacy project/2.92
legacy project/3.0
legacy project/3.1
legacy project/3.2
legacy project/3.3
legacy project/Alembic
legacy project/Animation & Rigging
legacy project/Asset Browser
legacy project/Asset Browser (Archived)
legacy project/Asset Browser Project Overview
legacy project/Audio
legacy project/Automated Testing
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Blender Asset Bundle
legacy project/Code Quest
legacy project/Collada
legacy project/Compositing
legacy project/Core
legacy project/Cycles
legacy project/Datablocks and Libraries
legacy project/Dependency Graph
legacy project/Development Management
legacy project/Eevee
legacy project/EEVEE & Viewport
legacy project/Freestyle
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/Geometry Nodes
legacy project/Good First Issue
legacy project/GPU / Viewport
legacy project/Grease Pencil
legacy project/GSoC
legacy project/Images & Movies
legacy project/Import/Export
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Line Art
legacy project/Masking
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Modeling
legacy project/Modifiers
legacy project/Motion Tracking
legacy project/Nodes
legacy project/Nodes & Physics
legacy project/OpenGL Error
legacy project/Overrides
legacy project/Papercut
legacy project/Performance
legacy project/Physics
legacy project/Pipeline, Assets & I/O
legacy project/Platform: FreeBSD
legacy project/Platform: Linux
legacy project/Platform: macOS
legacy project/Platforms, Builds, Tests & Devices
legacy project/Platform: Windows
legacy project/Pose Library Basics
legacy project/Python API
legacy project/Render & Cycles
legacy project/Render Pipeline
legacy project/Retrospective
legacy project/Sculpt, Paint & Texture
legacy project/Text Editor
legacy project/Tracker Curfew
legacy project/Translations
legacy project/Triaging
legacy project/Undo
legacy project/USD
legacy project/User Interface
legacy project/UV Editing
legacy project/VFX & Video
legacy project/Video Sequencer
legacy project/Virtual Reality
legacy project/Wintab High Frequency
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › EEVEE & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds Tests & Devices
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Rendering & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
papercut
performance
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
16 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#80164
Loading…
There is no content yet.