Blender 2.90 Tris to Quads breaks UVs even with Compare UVs checked. #80520

New Issue

Bogdan · 2020-09-06T14:03:59+02:00

Bogdan commented

2020-09-06 14:03:59 +02:00

System Information
Operating system: Windows 10
Graphics card: Nvidia Geforce GTX 1050 Ti

Blender Version
Broken: 2.90
Worked: 2.83

Short description of error
"Compare UVs" option of Tris to Quads does not stop UV map from breaking after applying it.
Exact steps for others to reproduce the error
Press Space, then select Tris to Quads, check "Compare UVs" and you'll see that UV Map will break.
Blend file is attached.
BlenderBug.blend

Blender 2020-09-06 14-55-28.mp4

**System Information** Operating system: Windows 10 Graphics card: Nvidia Geforce GTX 1050 Ti **Blender Version** Broken: 2.90 Worked: 2.83 **Short description of error** "Compare UVs" option of Tris to Quads does not stop UV map from breaking after applying it. **Exact steps for others to reproduce the error** Press Space, then select Tris to Quads, check "Compare UVs" and you'll see that UV Map will break. Blend file is attached. [BlenderBug.blend](https://archive.blender.org/developer/F8847303/BlenderBug.blend) [Blender 2020-09-06 14-55-28.mp4](https://archive.blender.org/developer/F8847304/Blender_2020-09-06_14-55-28.mp4)

Bogdan commented

2020-09-06 14:03:59 +02:00

Added subscriber: @Shararamosh

Germano Cavalcante commented

2020-09-09 17:15:18 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-09-09 17:15:18 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-09-09 17:15:19 +02:00

I can confirm.
It seems that there is an error in the calculation of the final customdata offset.
This deserves to be investigated.

diff --git a/source/blender/bmesh/operators/bmo_join_triangles.c b/source/blender/bmesh/operators/bmo_join_triangles.c
index efb8b810581..dceb2c58625 100644
--- a/source/blender/bmesh/operators/bmo_join_triangles.c
+++ b/source/blender/bmesh/operators/bmo_join_triangles.c
@@ -166,7 +166,7 @@ static bool bm_edge_delimit_cdata(CustomData *ldata,
   r_delim_cd->cd_type = type;
   r_delim_cd->cd_size = CustomData_sizeof(r_delim_cd->cd_type);
   r_delim_cd->cd_offset = CustomData_get_n_offset(ldata, type, 0);
-  r_delim_cd->cd_offset_end = r_delim_cd->cd_size * layer_len;
+  r_delim_cd->cd_offset_end = r_delim_cd->cd_offset + r_delim_cd->cd_size * layer_len;
   return (r_delim_cd->cd_offset != -1);
 }

I can confirm. It seems that there is an error in the calculation of the final customdata offset. This deserves to be investigated. ``` diff --git a/source/blender/bmesh/operators/bmo_join_triangles.c b/source/blender/bmesh/operators/bmo_join_triangles.c index efb8b810581..dceb2c58625 100644 --- a/source/blender/bmesh/operators/bmo_join_triangles.c +++ b/source/blender/bmesh/operators/bmo_join_triangles.c @@ -166,7 +166,7 @@ static bool bm_edge_delimit_cdata(CustomData *ldata, r_delim_cd->cd_type = type; r_delim_cd->cd_size = CustomData_sizeof(r_delim_cd->cd_type); r_delim_cd->cd_offset = CustomData_get_n_offset(ldata, type, 0); - r_delim_cd->cd_offset_end = r_delim_cd->cd_size * layer_len; + r_delim_cd->cd_offset_end = r_delim_cd->cd_offset + r_delim_cd->cd_size * layer_len; return (r_delim_cd->cd_offset != -1); } ```

blender-admin commented

2020-09-21 07:01:46 +02:00

This issue was referenced by 394a287714

This issue was referenced by 394a28771429442ae2946b2b68db726522f7e59f

blender-admin commented

2020-09-21 07:01:46 +02:00

This issue was referenced by 60fbed3dba

This issue was referenced by 60fbed3dba9f7cafd134f7a6dfe2892252a2d54b

blender-admin commented

2020-09-21 07:01:46 +02:00

This issue was referenced by f5b6b82598

This issue was referenced by f5b6b825980fc59cc54e69fbc1e967eebee1ad43

Campbell Barton commented

2020-09-21 07:07:08 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2020-09-21 07:07:08 +02:00

Campbell Barton self-assigned this 2020-09-21 07:07:08 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender 2.90 Tris to Quads breaks UVs even with Compare UVs checked. #80520