Default button in File Browser does not always listen to the Return / Enter key (regression) #82002

Closed
opened 2020-10-23 13:25:26 +02:00 by Anton Raves · 31 comments

System Information
Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel HD Graphics 4000 OpenGL Engine Intel Inc. 4.1 INTEL-14.7.8

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-21 22:57, hash: b0f34eee30
Worked: 2.90

Short description of error
Default button in File Browser does not always listen to the Return / Enter key

I have demonstrated this bug / problem to @JulianEisel in person, so he already knows about this bug, he just wanted me to write a few lines into the bug reporting system as a reminder.

There is no fixed case as to when this happens exactly, but about 50 percent of the time when a File Browser is there for opening / saving files and a filename is entered into the appropriate field, Blender will not listen to the Return / Enter key to continue and do what you had in mind.

Only when one clicks on the default button itself, will Blender carry out the request to "Save" / "Open" or similar command needed at that moment.

The problem occurs both on macOS 10.15.6 as well as Fedora 32 Linux distro.

Exact steps for others to reproduce the error

  • Open Blender
  • On splash screen click on Open...
  • Enter filename, don't confirm
  • Move mouse into field with path
  • Press Enter to confirm filename input
  • Press Enter to load file
    Nothing happens. If you keep pressing enter though, sometimes it eventually load the file.
    Sometimes this happens when you press Ctrl+O, sometimes not.

This is also true for saving (where this is even more disturbing)
from #88041 (ENTER does not Save file when mouse cursor is over Save dialog text field (regression)):
When you type a new filename into the SAVE FILE dialog and the mouse cursor is still where you just placed it, i.e. IN the text field, hitting ENTER does not Save and dismiss the dialog. The user is pointlessly required to move their cursor into the file list.

**System Information** Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits Graphics card: Intel HD Graphics 4000 OpenGL Engine Intel Inc. 4.1 INTEL-14.7.8 **Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-21 22:57, hash: `b0f34eee30` Worked: 2.90 **Short description of error** Default button in File Browser does not always listen to the Return / Enter key I have demonstrated this bug / problem to @JulianEisel in person, so he already knows about this bug, he just wanted me to write a few lines into the bug reporting system as a reminder. There is no fixed case as to when this happens exactly, but about 50 percent of the time when a File Browser is there for opening / saving files and a filename is entered into the appropriate field, Blender will not listen to the Return / Enter key to continue and do what you had in mind. Only when one clicks on the default button itself, will Blender carry out the request to "Save" / "Open" or similar command needed at that moment. The problem occurs both on macOS 10.15.6 as well as Fedora 32 Linux distro. **Exact steps for others to reproduce the error** - Open Blender - On splash screen click on Open... - Enter filename, don't confirm - Move mouse into field with path - Press Enter to confirm filename input - Press Enter to load file Nothing happens. If you keep pressing enter though, sometimes it eventually load the file. Sometimes this happens when you press Ctrl+O, sometimes not. This is also true for saving (where this is even more disturbing) from #88041 (ENTER does not Save file when mouse cursor is over Save dialog text field (regression)): When you type a new filename into the SAVE FILE dialog and the mouse cursor is still where you just placed it, i.e. IN the text field, hitting ENTER does not Save and dismiss the dialog. The user is pointlessly required to move their cursor into the file list.
Author

Added subscribers: @JulianEisel, @Memento

Added subscribers: @JulianEisel, @Memento

#91196 was marked as duplicate of this issue

#91196 was marked as duplicate of this issue

#88041 was marked as duplicate of this issue

#88041 was marked as duplicate of this issue

#87542 was marked as duplicate of this issue

#87542 was marked as duplicate of this issue

#84545 was marked as duplicate of this issue

#84545 was marked as duplicate of this issue

Added subscriber: @iss

Added subscriber: @iss

I can confirm this issue, usually the problem is that mouse pointer will drift away to another field or button that will respond to pressed enter.

Or with Following steps:

  • Open Blender
  • On splash screen click on Open...
  • Enter filename, don't confirm
  • Move mouse into field with path
  • Press Enter to confirm filename input
  • Press Enter to load file
    Nothing happens. If you keep pressing enter though, sometimes it eventually load the file.
    Sometimes this happens when you press Ctrl+O, sometimes not.

As a person that opens quite significant amount of files daily, I was quite annoyed, that I can't do Ctrl+O, Ctrl+V, Enter to open file, but I can understand that my workflow may be
a bit extraordinary. Also I can make file browser to open in same window and that works quite well. I still need to make sure I don't move my mouse though.

I can confirm this issue, usually the problem is that mouse pointer will drift away to another field or button that will respond to pressed enter. Or with Following steps: - Open Blender - On splash screen click on Open... - Enter filename, don't confirm - Move mouse into field with path - Press Enter to confirm filename input - Press Enter to load file Nothing happens. If you keep pressing enter though, sometimes it eventually load the file. Sometimes this happens when you press Ctrl+O, sometimes not. As a person that opens quite significant amount of files daily, I was quite annoyed, that I can't do Ctrl+O, Ctrl+V, Enter to open file, but I can understand that my workflow may be a bit extraordinary. Also I can make file browser to open in same window and that works quite well. I still need to make sure I don't move my mouse though.

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscribers: @kanani, @rjg

Added subscribers: @kanani, @rjg
Member

Definitely seems like a weird one, but also a harmless one. Except of some user confusion, nothing happens (literally). Classifying as low priority.

Definitely seems like a weird one, but also a harmless one. Except of some user confusion, nothing happens (literally). Classifying as low priority.

Added subscriber: @Poly_Ferret

Added subscriber: @Poly_Ferret

Its consistent when you place your mouse cursor just above where you'd type in the file name (in the grey area between the file name and browser window).

Its consistent when you place your mouse cursor just above where you'd type in the file name (in the grey area between the file name and browser window).
Author

When there is a default button, that entire dialog / window should respond to pressing the "Enter" or "Return" key, not just when the mouse is in / hovering over a smaller area of that dialog / window.

There should be no obvious default button when the application only listens to a (mouse inside) smaller area or when that dialog / window is not the front dialog / window!

When there is a default button, that entire dialog / window should respond to pressing the "Enter" or "Return" key, not just when the mouse is in / hovering over a smaller area of that dialog / window. There should be no obvious default button when the application only listens to a (mouse inside) smaller area or when that dialog / window is not the front dialog / window!

In #82002#1133093, @Memento wrote:
When there is a default button, that entire dialog / window should respond to pressing the "Enter" or "Return" key, not just when the mouse is in / hovering over a smaller area of that dialog / window.

There should be no obvious default button when the application only listens to a (mouse inside) smaller area or when that dialog / window is not the front dialog / window!

I agree. Yet, its consistent when I place the mouse cursor there.

> In #82002#1133093, @Memento wrote: > When there is a default button, that entire dialog / window should respond to pressing the "Enter" or "Return" key, not just when the mouse is in / hovering over a smaller area of that dialog / window. > > There should be no obvious default button when the application only listens to a (mouse inside) smaller area or when that dialog / window is not the front dialog / window! I agree. Yet, its consistent when I place the mouse cursor there.
Philipp Oeser changed title from Default button in File Browser does not always listen to the Return / Enter key to Default button in File Browser does not always listen to the Return / Enter key (regression) 2021-05-05 15:31:35 +02:00
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Upped the priority since it is a regression

Upped the priority since it is a regression
Member

Added subscriber: @jeric_synergy

Added subscriber: @jeric_synergy
Philipp Oeser self-assigned this 2021-05-05 17:28:43 +02:00
Member

Caused by 4ba9d7d71e

In #82002#1095557, @JulianEisel wrote:
Definitely seems like a weird one, but also a harmless one.

Weird, but apparently done on purpose. By you, @JulianEisel :)
Since this apparently above commit was just meant to just prevent double-clicks interfering here, will post a fix to restricts this to double-clicks only...

Caused by 4ba9d7d71e > In #82002#1095557, @JulianEisel wrote: > Definitely seems like a weird one, but also a harmless one. Weird, but apparently done on purpose. By you, @JulianEisel :) Since this apparently above commit was just meant to just prevent double-clicks interfering here, will post a fix to restricts this to double-clicks only...

This issue was referenced by 6c8c30d865

This issue was referenced by 6c8c30d865ee8aafc3a088ce97b1caa4c4cc9ed7
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Contributor

Added subscriber: @dupoxy

Added subscriber: @dupoxy
Contributor

@JulianEisel If I could, I would vote for the fix to be in 2.93.

@JulianEisel If I could, I would vote for the fix to be in 2.93.
Philipp Oeser removed their assignment 2021-05-06 17:52:29 +02:00
Member

In #82002#1156966, @dupoxy wrote:
@JulianEisel If I could, I would vote for the fix to be in 2.93.

+1

> In #82002#1156966, @dupoxy wrote: > @JulianEisel If I could, I would vote for the fix to be in 2.93. +1
Author

Added subscriber: @ideasman42

Added subscriber: @ideasman42
Author
@JulianEisel +1
Member

I don't think the fix is safe enough to be backported to 2.93. It shouldn't but might break custom keymaps. At the very least there will be a warning printed for custom keymaps I think, because an operator property was removed.

There is however a smaller, rather hacky fix that we can do just for 2.93 that should be safe. I'll have to do that separately.

I don't think the fix is safe enough to be backported to 2.93. It shouldn't but might break custom keymaps. At the very least there will be a warning printed for custom keymaps I think, because an operator property was removed. There is however a smaller, rather hacky fix that we can do just for 2.93 that should be safe. I'll have to do that separately.
Author

@JulianEisel Why not just remove the active region for this action completely? When the File Browser is active it is already at the top of all other Blender windows and can safely "listen" to a user pressing the Enter or Return keys...

@JulianEisel Why not just remove the active region for this action completely? When the File Browser is active it is already at the top of all other Blender windows and can safely "listen" to a user pressing the Enter or Return keys...

Added subscriber: @Petri

Added subscriber: @Petri

Thanks @rjg to pointing me to here. It is strange that hovering mouse of the button do the trick :)
But what is the difference between Enter vs. Esc? As Esc is working, no matter where the mouse is.

Thanks @rjg to pointing me to here. It is strange that hovering mouse of the button do the trick :) But what is the difference between Enter vs. Esc? As Esc is working, no matter where the mouse is.

@Petri The problem has been fixed for Blender 3.0, but the patch will not be backported to 2.93.x.

@Petri The problem has been fixed for Blender 3.0, but the patch will not be backported to 2.93.x.

In #82002#1216235, @rjg wrote:
@Petri The problem has been fixed for Blender 3.0, but the patch will not be backported to 2.93.x.

That is great news ! Thanks!

> In #82002#1216235, @rjg wrote: > @Petri The problem has been fixed for Blender 3.0, but the patch will not be backported to 2.93.x. That is great news ! Thanks!
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#82002
No description provided.