Better error handling of unsupported node group inputs #82438

Closed
opened 2020-11-05 18:39:04 +01:00 by Dalai Felinto · 6 comments

Right now if you connect a geometry input in the modifier stack you get a warning in the UI:

image.png

Right now if you connect a geometry input in the modifier stack you get a warning in the UI: ![image.png](https://archive.blender.org/developer/F9210918/image.png)

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @dfelinto

Added subscriber: @dfelinto
Hans Goudey was assigned by Jacques Lucke 2020-11-12 17:04:48 +01:00

Done in {1ddd71780365796efde9c08b0aa08990d2d004a4}.

The types of errors it checks for should be clear from the strings in that commit.

Done in {1ddd71780365796efde9c08b0aa08990d2d004a4}. The types of errors it checks for should be clear from the strings in that commit.

If I connect a vector3 (e.g., Object Info -> Location) in the group output it throws an error regarding "The node group must have a single geometry output".

I don't think we should throw any error re: output nodes, unless there is NONE Geometry output. Since users can re-use the nodes as either groups or modifiers I don't think they need to be warned about the output.

Suggestion of error when there is no "Geometry Output" socket: "The node group must one geometry output".

If I connect a vector3 (e.g., Object Info -> Location) in the group output it throws an error regarding "The node group must have a single geometry output". I don't think we should throw any error re: output nodes, unless there is NONE Geometry output. Since users can re-use the nodes as either groups or modifiers I don't think they need to be warned about the output. Suggestion of error when there is no "Geometry Output" socket: "The node group must one geometry output".

96ce1e9a95 addresses this.

96ce1e9a95 addresses this.

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#82438
There is no content yet.