Fluid: Missing cache invalidation when properties on non-domain objects change. #84369

New Issue

Closed

opened 2021-01-04 12:14:23 +01:00 by Jacques Lucke · 20 comments

Jacques Lucke commented

2021-01-04 12:14:23 +01:00

Member

We get many bug reports on this topic. Usually they just differ in what property is changed. This is mainly an issue when the cache mode is set to Replay.

The issue is probably related to the fact, that the new fluid system, does not use the point cache system for caching. The domain object has a POINT_CACHE_RESET() depsgraph node, but it does not actually reset anything.

Reproduce without file:

Add Quick Smoke to default cube.
Play the simulation.
While the simulation runs, change the Flow Type of the cube to Fire.
Note that there is now fire in the simulation, but the cache has not been invalidated.

Instead of changing the Flow Type, many other properties can be changed as well. That also includes the position of the source object. The cache is only invalidated when the domain object is changed.

Bug reports with the same underlying issue can be merged into this report.

We get many bug reports on this topic. Usually they just differ in what property is changed. This is mainly an issue when the cache mode is set to Replay. The issue is probably related to the fact, that the new fluid system, does not use the point cache system for caching. The domain object has a `POINT_CACHE_RESET()` depsgraph node, but it does not actually reset anything. Reproduce without file: 1. Add Quick Smoke to default cube. 2. Play the simulation. 3. While the simulation runs, change the Flow Type of the cube to Fire. 4. Note that there is now fire in the simulation, but the cache has not been invalidated. Instead of changing the Flow Type, many other properties can be changed as well. That also includes the position of the source object. The cache is only invalidated when the domain object is changed. Bug reports with the same underlying issue can be merged into this report.

Jacques Lucke commented

2021-01-04 12:14:23 +01:00

Author

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Jacques Lucke commented

2021-01-04 12:14:23 +01:00

Author

Member

Added subscribers: @JacquesLucke, @sebbas

Added subscribers: @JacquesLucke, @sebbas

blender-admin commented

2021-01-04 12:14:23 +01:00

#89746 was marked as duplicate of this issue

#89746 was marked as duplicate of this issue

blender-admin commented

2021-01-04 12:14:23 +01:00

#84314 was marked as duplicate of this issue

#84314 was marked as duplicate of this issue

blender-admin commented

2021-01-04 12:14:23 +01:00

#78936 was marked as duplicate of this issue

#78936 was marked as duplicate of this issue

blender-admin commented

2021-01-04 12:14:23 +01:00

#76095 was marked as duplicate of this issue

#76095 was marked as duplicate of this issue

Jacques Lucke commented

2021-01-04 12:16:19 +01:00

Author

Member

Added subscribers: @NicolaSap, @jenkm, @StephenSwaney, @girafic, @RedpaX, @iss, @MahyarArdakani, @Mach, @LiborBatek, @mano-wii, @Nikhil.Net, @blenderhighschool, @lichtwerk, @ankitm

Added subscribers: @NicolaSap, @jenkm, @StephenSwaney, @girafic, @RedpaX, @iss, @MahyarArdakani, @Mach, @LiborBatek, @mano-wii, @Nikhil.Net, @blenderhighschool, @lichtwerk, @ankitm

Jacques Lucke commented

2021-01-04 12:17:17 +01:00

Author

Member

Added subscriber: @BaldingWizard

Added subscriber: @BaldingWizard

Jacques Lucke commented

2021-01-04 12:17:35 +01:00

Author

Member

Added subscribers: @eigenstryker, @rjg

Added subscribers: @eigenstryker, @rjg

kent.mai commented

2021-02-19 09:52:37 +01:00

Added subscriber: @kmai

Added subscriber: @kmai

RedMser commented

2021-02-20 13:18:32 +01:00

Contributor

Added subscriber: @RedMser

Added subscriber: @RedMser

gabe2252 commented

2021-02-25 00:34:09 +01:00

Added subscriber: @gabe2252

Added subscriber: @gabe2252

Mathis Siebert commented

2021-03-01 21:39:05 +01:00

Added subscriber: @Mathis-8

Added subscriber: @Mathis-8

Richard Antalik commented

2021-07-09 10:50:38 +02:00

Member

Added subscriber: @TheShadowMuffin

Added subscriber: @TheShadowMuffin

Raimund Klink commented

2021-12-21 09:53:38 +01:00

Contributor

Added subscriber: @Raimund58

Added subscriber: @Raimund58

lictex_ commented

2022-02-01 17:07:26 +01:00

Added subscriber: @lictex_1

Added subscriber: @lictex_1

Pavel Duong commented

2022-06-15 12:31:31 +02:00

Added subscriber: @vignette

Added subscriber: @vignette

blender-admin commented

2022-06-27 21:50:13 +02:00

This issue was referenced by 67e23b4b29

This issue was referenced by 67e23b4b29676e7cbc039eba96e3edd78a632997

Germano Cavalcante commented

2022-06-27 21:55:02 +02:00

Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'

Germano Cavalcante closed this issue

2022-06-27 21:55:02 +02:00

Germano Cavalcante self-assigned this 2022-06-27 21:55:02 +02:00

Adam Janz commented

2022-11-02 21:05:41 +01:00

Added subscriber: @AdamJanz

Added subscriber: @AdamJanz

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

12 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#84369

No description provided.