2.93 DOF refactor - artifact #85845

Closed
opened 2 years ago by tonpix · 14 comments
tonpix commented 2 years ago

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 2.93.0 Alpha, branch: eevee-dof-refactor, commit date: 2021-01-28 18:32, hash: 5db9a008b9

Short description of error
2.93's DOF sometimes confuses which parts of view should be sharp/blurred. Screenshot, video clip and simplified .blend attached to check out.

Exact steps for others to reproduce the error

  1. open .blend file
  2. use mouse scroll wheel to zoom in/out viewport (camera stays locked)
  3. you should notice artifacts disappear/appear depending on scrolling

marked 2 artifacts - image.png
video clip - https://streamable.com/5p9s0h
.blend file to download - https://drive.google.com/file/d/10oKYeV_wy0Yx5V0cdhsg4boQauaV74lq/view?usp=sharing

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 2.93.0 Alpha, branch: eevee-dof-refactor, commit date: 2021-01-28 18:32, hash: `5db9a008b9` **Short description of error** 2.93's DOF sometimes confuses which parts of view should be sharp/blurred. Screenshot, video clip and simplified .blend attached to check out. **Exact steps for others to reproduce the error** 1. open .blend file 2. use mouse scroll wheel to zoom in/out viewport (camera stays locked) 3. you should notice artifacts disappear/appear depending on scrolling marked 2 artifacts - ![image.png](https://archive.blender.org/developer/F9825519/image.png) video clip - https://streamable.com/5p9s0h .blend file to download - https://drive.google.com/file/d/10oKYeV_wy0Yx5V0cdhsg4boQauaV74lq/view?usp=sharing
tonpix commented 2 years ago
Poster

Added subscriber: @tonpix

Added subscriber: @tonpix
fclem commented 2 years ago
Collaborator

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
fclem commented 2 years ago
Collaborator

Added subscriber: @fclem

Added subscriber: @fclem
fclem commented 2 years ago
Collaborator

I could not reproduce on my AMD workstation. I will have to test on another hardware configuration.

I could not reproduce on my AMD workstation. I will have to test on another hardware configuration.

Added subscriber: @TimBrown

Added subscriber: @TimBrown

this is normal. that are the different distances from the camera.
in the old system it was the same

this is normal. that are the different distances from the camera. in the old system it was the same
tonpix commented 2 years ago
Poster

In #85845#1129410, @TimBrown wrote:
this is normal. that are the different distances from the camera.
in the old system it was the same

Could you explain it further?

> In #85845#1129410, @TimBrown wrote: > this is normal. that are the different distances from the camera. > in the old system it was the same Could you explain it further?

So im not a developer but i think of my use of the dof that the dof has steps. So i think that has to be a feature to interpolate the steps ore blend the steps into each other. Am i right?

So im not a developer but i think of my use of the dof that the dof has steps. So i think that has to be a feature to interpolate the steps ore blend the steps into each other. Am i right?
tonpix commented 2 years ago
Poster

No idea, but =<2.92 didn't have these artifacts, it's new. Dev mentioned tiles not being calculated correctly, so maybe it's a screenspace thing?

@fclem Any successes in reproducing issue on another hardware?

No idea, but =<2.92 didn't have these artifacts, it's new. Dev mentioned tiles not being calculated correctly, so maybe it's a screenspace thing? @fclem Any successes in reproducing issue on another hardware?

Added subscriber: @Sparazza

Added subscriber: @Sparazza
Collaborator

This issue was referenced by 45d3303ae4

This issue was referenced by 45d3303ae42e0b563bd164148efa516f93261ba0
fclem commented 2 years ago
Collaborator

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
fclem closed this issue 2 years ago
fclem self-assigned this 2 years ago
tonpix commented 2 years ago
Poster

@fclem That's fantastic, just checked out .blend file and I don't see artifacts originally reported in first post. However, I've noticed some strange outlines - their appearance depend on how you zoom in/out in viewport and on value of F-Stop in camera settings. Is it an known issue? Enabled Jitter in DOF settings solves it, if it helps.

At 0.2 F-stop:
image.png

At 0.1 F-stop outliner dissapears from character and appears on window frame:
image.png

EDIT:
Recorded behaviour:
https://files.catbox.moe/9us50c.mp4

EDIT2:
Seems this outline artifact doesn't seems to be apparent in renders

@fclem That's fantastic, just checked out .blend file and I don't see artifacts originally reported in first post. However, I've noticed some strange outlines - their appearance depend on how you zoom in/out in viewport and on value of F-Stop in camera settings. Is it an known issue? Enabled Jitter in DOF settings solves it, if it helps. At 0.2 F-stop: ![image.png](https://archive.blender.org/developer/F10113151/image.png) At 0.1 F-stop outliner dissapears from character and appears on window frame: ![image.png](https://archive.blender.org/developer/F10113154/image.png) EDIT: Recorded behaviour: https://files.catbox.moe/9us50c.mp4 EDIT2: Seems this outline artifact doesn't seems to be apparent in renders
tonpix commented 2 years ago
Poster

image.png

I've noticed also jagged artifact, camera height position and viewport zoom in/out affect it - there's recording:

https://files.catbox.moe/biz6p4.mp4

Forgot to add blender/system info - it's for this and previous post:
System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.11

Blender Version
Broken: version: 2.93.0 Beta, branch: master, commit date: 2021-05-15 16:29, hash: 610c0ecc3b

EDIT:
I've quickly tested DOF parameters in Render properties:

  • lowering or upping Neighbout Rejection mitigates it (albeit with different looks)
  • setting Denoise Amount to 0.95-1 mitigates it
![image.png](https://archive.blender.org/developer/F10113266/image.png) I've noticed also jagged artifact, camera height position and viewport zoom in/out affect it - there's recording: https://files.catbox.moe/biz6p4.mp4 Forgot to add blender/system info - it's for this and previous post: **System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.11 **Blender Version** Broken: version: 2.93.0 Beta, branch: master, commit date: 2021-05-15 16:29, hash: `610c0ecc3b` EDIT: I've quickly tested DOF parameters in Render properties: - lowering or upping Neighbout Rejection mitigates it (albeit with different looks) - setting Denoise Amount to 0.95-1 mitigates it
ThomasDinges added this to the 2.93 LTS milestone 3 days ago
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Pipeline, Assets & I/O
Interest/Translations
Interest/Undo
Interest/USD
Interest/Video Sequencer
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Physics
legacy project/Platforms, Builds, Tests & Devices
legacy project/Pose Library Basics
legacy project/Python API
legacy project/Render & Cycles
legacy project/Render Pipeline
legacy project/Retrospective
legacy project/Sculpt, Paint & Texture
legacy project/Text Editor
legacy project/Tracker Curfew
legacy project/Triaging
legacy project/User Interface
legacy project/UV Editing
legacy project/VFX & Video
legacy project/Virtual Reality
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#85845
Loading…
There is no content yet.