Round end-caps on Freestyle lines not working properly #88015

New Issue

Tom Hartley · 2021-05-04T04:25:46+02:00

Tom Hartley commented

2021-05-04 04:25:46 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: Intel(R) HD Graphics 620 Intel 4.5.0 - Build 27.20.100.8682

Blender Version
Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: 02948a2cab
Worked: (none)

Short description of error
ROUND end-caps of Freestyle lines are currently not working properly. Please see attached images.

(Tested on the 4th of May 2021 in Blender 2.92 and 3.0 Alpha.)

[Screenshots of this bug exposed two more bugs, submitted separately:

Freestyle Lines Stopping Short of Vertices & Partially Failing https://developer.blender.org/T88014
Erroneous gap between object and its shadow https://developer.blender.org/T88013 ]

Exact steps for others to reproduce the error
Open attached .blend file and press F12 ('Render')

BUG_Freestyle_ROUND_Endcaps_01.blend

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: Intel(R) HD Graphics 620 Intel 4.5.0 - Build 27.20.100.8682 **Blender Version** Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: (none) **Short description of error** ROUND end-caps of Freestyle lines are currently not working properly. Please see attached images. (Tested on the 4th of May 2021 in Blender 2.92 and 3.0 Alpha.) **** [Screenshots of this bug exposed two more bugs, submitted separately: - Freestyle Lines Stopping Short of Vertices & Partially Failing https://developer.blender.org/T88014 - Erroneous gap between object and its shadow https://developer.blender.org/T88013 ] **** **Exact steps for others to reproduce the error** Open attached .blend file and press F12 ('Render') ![BlenderFreestyleBug_Round_End-caps-02.png](https://archive.blender.org/developer/F10052215/BlenderFreestyleBug_Round_End-caps-02.png) ![BlenderFreestyleBug_Round_End-caps-01.png](https://archive.blender.org/developer/F10052216/BlenderFreestyleBug_Round_End-caps-01.png) [BUG_Freestyle_ROUND_Endcaps_01.blend](https://archive.blender.org/developer/F10052218/BUG_Freestyle_ROUND_Endcaps_01.blend)

Tom Hartley commented

2021-05-04 04:25:46 +02:00

Added subscriber: @Quix

Philipp Oeser commented

2021-05-06 17:21:13 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-05-06 17:21:13 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Philipp Oeser commented

2021-05-06 17:21:13 +02:00

Not sure, I can see a clear difference:

Butt

Round

Are you not seeing this difference?

Not sure, I can see a clear difference: Butt ![image.png](https://archive.blender.org/developer/F10056612/image.png) Round ![image.png](https://archive.blender.org/developer/F10056614/image.png) Are you not seeing this difference?

Tom Hartley commented

2021-05-07 01:45:14 +02:00

Would someone please fix this ASAP.

(The current negligible, microscopic difference is obviously insufficient and not what users want or expect.
The inset in the bottom-left corner of the following image illustrates how 'butt', 'round' and 'square' endcaps should appear: https://developer.blender.org/F10052216 .)

In writing, that is:
Where 'e' is the line's endpoint and 'd' is the thickness of the line at e,

BUTT: The line should stop abruptly at e.
ROUND: A disc of diameter d should be printed with e as its centre.
SQUARE: A square of side-length d should be printed with e as its centre.

If someone would be kind enough to fix this, that would be much appreciated.
Thanks in advance.

Would someone please fix this ASAP. (The current negligible, microscopic difference is obviously insufficient and not what users want or expect. The inset in the bottom-left corner of the following image illustrates how 'butt', 'round' and 'square' endcaps should appear: https://developer.blender.org/F10052216 .) In writing, that is: Where 'e' is the line's endpoint and 'd' is the thickness of the line at e, BUTT: The line should stop abruptly at e. ROUND: A disc of diameter d should be printed with e as its centre. SQUARE: A square of side-length d should be printed with e as its centre. If someone would be kind enough to fix this, that would be much appreciated. Thanks in advance.

Philipp Oeser commented

2021-05-21 12:54:29 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Philipp Oeser commented

2021-05-21 13:22:01 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-05-21 13:22:01 +02:00

OK, also looking at the documentation it becomes apparent that this is not a "half circle centered at the end point of the line" (but instead more of a squashed version of it)
https://docs.blender.org/manual/en/dev/render/freestyle/parameter_editor/line_style/strokes.html#caps

So will confirm, culprit is RoundCapShader(StrokeShader) for anyone wanting to have a look at this.

OK, also looking at the documentation it becomes apparent that this is not a "half circle centered at the end point of the line" (but instead more of a squashed version of it) https://docs.blender.org/manual/en/dev/render/freestyle/parameter_editor/line_style/strokes.html#caps ![image.png](https://archive.blender.org/developer/F10133778/image.png) So will confirm, culprit is `RoundCapShader(StrokeShader)` for anyone wanting to have a look at this.

blender-admin commented

2021-05-21 13:42:13 +02:00

This issue was referenced by b529a84ec3

This issue was referenced by b529a84ec3864f83a00dd75e884598786134e563

blender-admin commented

2021-05-21 13:42:13 +02:00

This issue was referenced by 7b6c77aa84

This issue was referenced by 7b6c77aa84803e4268406e394aa4556ebf7980b0

Philipp Oeser commented

2021-05-21 13:48:46 +02:00

With patch:

With patch: ![image.png](https://archive.blender.org/developer/F10133842/image.png)