GP/Annotation UI: Wrong icon and behaviour in the wrong regions #88617

New Issue

tintwotin · 2021-05-27T09:43:59+02:00

tintwotin commented

2021-05-27 09:43:59 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30

Blender Version
Broken: version: 3.0.0 Alpha, branch: master (modified), commit date: 2021-05-26 18:32, hash: 2c607ec2f6

Short Description
As I was asked to make a new report on this GP UI issues in D11347, here it is:
In Sequencer/Preview mode the mouse cursor changes into the pen in the area where you can't draw(the strip area), and if you try to draw in that area, a point will light up in the preview area

Steps to Reproduce

Open default scene
Switch to video sequencer editor and select Sequencer & Preview
Select annotation tool and hover the mouse on preview area (pen cursor is not present)
{F10135003,size=full}

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master (modified), commit date: 2021-05-26 18:32, hash: `2c607ec2f6` **Short Description** As I was asked to make a new report on this GP UI issues in [D11347](https://archive.blender.org/developer/D11347), here it is: In Sequencer/Preview mode the mouse cursor changes into the pen in the area where you can't draw(the strip area), and if you try to draw in that area, a point will light up in the preview area **Steps to Reproduce** - Open default scene - Switch to video sequencer editor and select `Sequencer & Preview` - Select annotation tool and hover the mouse on preview area (pen cursor is not present) {[F10135003](https://archive.blender.org/developer/F10135003/wrong_icon_and_position.gif),size=full}

tintwotin commented

2021-05-27 09:43:59 +02:00

Added subscriber: @tintwotin

kathybowing commented

2021-05-27 13:18:28 +02:00

(Migrated from localhost:3001)

Added subscriber: @kathybowing

Philipp Oeser commented

2021-05-27 16:10:13 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2021-06-05 06:56:40 +02:00

Added subscriber: @PratikPB2123

Antonio Vazquez commented

2021-06-10 19:33:12 +02:00

Added subscribers: @ideasman42, @antoniov

Antonio Vazquez commented

2021-06-10 19:33:12 +02:00

@ideasman42 Do you know how to fix this?

tintwotin commented

2021-09-03 18:36:48 +02:00

Removed subscriber: @tintwotin

tintwotin commented

2021-10-26 08:52:57 +02:00

Changed status from 'Confirmed' to: 'Archived'

tintwotin closed this issue

2021-10-26 08:52:57 +02:00

tintwotin commented

2021-10-26 08:52:57 +02:00

As I do not have anymore time or motivation for a continued investment in the Blender project, I'm giving up on this report for now.

Philipp Oeser commented

2021-10-26 09:12:30 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-10-26 09:12:30 +02:00

Changed status from 'Archived' to: 'Confirmed'

Philipp Oeser reopened this issue

2021-10-26 09:12:30 +02:00

Philipp Oeser commented

2021-10-26 09:12:30 +02:00

Sorry to hear (thx again reporting). In my opinion we should not sweep this under the carpet (esp. since this already been confirmed), there is still a chance to get this fixed in the future and others might be affected by this issue as well.
Feel free to unsubscribe though.

Sorry to hear (thx again reporting). In my opinion we should not sweep this under the carpet (esp. since this already been confirmed), there is still a chance to get this fixed in the future and others might be affected by this issue as well. Feel free to unsubscribe though.

Pratik Borhade commented

2022-12-26 13:52:48 +01:00

This happens because: cursor is set to default for the regions other than window. A quick fix would be to add preview region to change the cursor type as per the selected tool

index f7c030db1cd..74e760013fd 100644
    - a/source/blender/windowmanager/intern/wm_cursors.c
+++ b/source/blender/windowmanager/intern/wm_cursors.c
@@ -173,7 +173,7 @@ void WM_cursor_set(wmWindow *win, int curs)

 bool WM_cursor_set_from_tool(struct wmWindow *win, const ScrArea *area, const ARegion *region)
 {
- if (region && (region->regiontype != RGN_TYPE_WINDOW)) {
+  if (region && !ELEM(region->regiontype, RGN_TYPE_WINDOW, RGN_TYPE_PREVIEW)) {

return false;
}```

- - -
But this doesn't completely fix the issue. `WM_CURSOR_PAINT_BRUSH` cursor still appear when hovered over sequencer region.
I'll give a try to fix this

This happens because: cursor is set to default for the regions other than `window`. A quick fix would be to add preview region to change the cursor type as per the selected tool ```diff --git a/source/blender/windowmanager/intern/wm_cursors.c b/source/blender/windowmanager/intern/wm_cursors.c index f7c030db1cd..74e760013fd 100644 - a/source/blender/windowmanager/intern/wm_cursors.c +++ b/source/blender/windowmanager/intern/wm_cursors.c @@ -173,7 +173,7 @@ void WM_cursor_set(wmWindow *win, int curs) bool WM_cursor_set_from_tool(struct wmWindow *win, const ScrArea *area, const ARegion *region) { - if (region && (region->regiontype != RGN_TYPE_WINDOW)) { + if (region && !ELEM(region->regiontype, RGN_TYPE_WINDOW, RGN_TYPE_PREVIEW)) { ``` return false; }``` ``` - - - But this doesn't completely fix the issue. `WM_CURSOR_PAINT_BRUSH` cursor still appear when hovered over sequencer region. I'll give a try to fix this

Pratik Borhade self-assigned this 2022-12-28 14:29:08 +01:00

Pratik Borhade commented

2023-01-16 12:05:24 +01:00

Removed subscriber: @kathybowing