Redesign Graph editor Header and Menus to 2.80 Blender UI standards #89069

Open
opened 2021-06-11 20:13:53 +02:00 by bassam kurdali · 14 comments
Member

The current graph editor menus have slowly evolved and not been evaluated carefully. As a result, the header menus are a bit of a mess:
viewmenu_graph_editor.png
Here some options are really hard to parse and arranged oddly (for intance, Show Handles and Show "Only Selected Keyframe Handles" are related, but seperated from each other, and it is really hard to parse what they do, some options like "AutoMerge Keyframes" don't belong at all in View.
This design task is to work towards making the header area in the graph editor match blender design, so that options are found in an expected place, similar to e.g. the 3D View header which has received more attention:

  • Reorganize the header so that similar items are in similar places, e.g. pivot and snapping options should be centered
  • Add an overlay menu and organize some of the clutter in the view menu so it makes more sense, and fits a (Blender) users expectations of where things should be
  • Reorganize all the menus if needed, and move items that don't belong (e.g. the aforementioned AutoMerge Keyframes) to a logical place
  • Potentially upgrade the editor to use the tool system and have two lines in the header for options, etc.
The current graph editor menus have slowly evolved and not been evaluated carefully. As a result, the header menus are a bit of a mess: ![viewmenu_graph_editor.png](https://archive.blender.org/developer/F10167310/viewmenu_graph_editor.png) Here some options are really hard to parse and arranged oddly (for intance, Show Handles and Show "Only Selected Keyframe Handles" are related, but seperated from each other, and it is really hard to parse what they do, some options like "AutoMerge Keyframes" don't belong at all in View. This design task is to work towards making the header area in the graph editor match blender design, so that options are found in an expected place, similar to e.g. the 3D View header which has received more attention: - Reorganize the header so that similar items are in similar places, e.g. pivot and snapping options should be centered - Add an overlay menu and organize some of the clutter in the view menu so it makes more sense, and fits a (Blender) users expectations of where things should be - Reorganize all the menus if needed, and move items that don't belong (e.g. the aforementioned AutoMerge Keyframes) to a logical place - Potentially upgrade the editor to use the tool system and have two lines in the header for options, etc.
Author
Member

Added subscriber: @BassamKurdali

Added subscriber: @BassamKurdali
Author
Member

Current Appearance:
grapheditor_current.png

  • Snapping options and Proportional editing are right justified, whereas they are centered in the 3D View
  • There is no overlays drop down

The view menu is confusing, and almost requires careful reading with every use. Some options don't really belong there.

**Current Appearance:** ![grapheditor_current.png](https://archive.blender.org/developer/F10167322/grapheditor_current.png) - Snapping options and Proportional editing are right justified, whereas they are centered in the 3D View - There is no overlays drop down # The view menu is confusing, and almost requires careful reading with every use. Some options don't really belong there.
Author
Member

Mockup 1
grapheditor_mockup_1.png

  • Centered Pivot, snapping and proportional editing header buttons, matching 3D View and other editors
  • Added Overlays menu to the right
  • Moved Markers and 2D Cursor from View to the overlays
  • Moved Curve extrapolation from View to the overlays
  • Moved "Only selected Curves Keyframes" from View to overlays and renamed slightly
  • Removed "Show Handles" and "Only Selected Keyframes Handles" And replaced it in overlays with an Enum Menu that has "None, All, Selected" options.

Removed "Automerge Keyframes" - there are several places where it could go, and the View menu isn't one of them. (It could go in the Key menu, in the "Options" button if graph editor goes to a tools system, or the sidebar, or some/all of the above)

**Mockup 1** ![grapheditor_mockup_1.png](https://archive.blender.org/developer/F10167325/grapheditor_mockup_1.png) - Centered Pivot, snapping and proportional editing header buttons, matching 3D View and other editors - Added Overlays menu to the right - Moved Markers and 2D Cursor from View to the overlays - Moved Curve extrapolation from View to the overlays - Moved "Only selected Curves Keyframes" from View to overlays and renamed slightly - Removed "Show Handles" and "Only Selected Keyframes Handles" And replaced it in overlays with an Enum Menu that has "None, All, Selected" options. # Removed "Automerge Keyframes" - there are several places where it could go, and the View menu isn't one of them. (It could go in the Key menu, in the "Options" button if graph editor goes to a tools system, or the sidebar, or some/all of the above)
Author
Member

Mockup 2
grapheditor_mockup_2.png
Based on suggestions from Hans Goudey, replaced "Only Selected Curves Keyframes" with an enum - the boolean is a bit confusing as turning it ON turns OFF keyframes on unselected curves. The enum currently has "All" and "Selected" as options, it could be "Selected Curves" if that is too cryptic.

**Mockup 2** ![grapheditor_mockup_2.png](https://archive.blender.org/developer/F10167331/grapheditor_mockup_2.png) Based on suggestions from Hans Goudey, replaced "Only Selected Curves Keyframes" with an enum - the boolean is a bit confusing as turning it ON turns OFF keyframes on unselected curves. The enum currently has "All" and "Selected" as options, it could be "Selected Curves" if that is too cryptic.

Added subscriber: @GeorgiaPacific

Added subscriber: @GeorgiaPacific
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'
Member

Think there is not much to be done from the triaging side of things, will let the devs decide to set status to confirmed.

Think there is not much to be done from the triaging side of things, will let the devs decide to set status to confirmed.

Added subscriber: @ChristiaanMoleman

Added subscriber: @ChristiaanMoleman

One suggestion I would make, regardless of where they end up in the UI, is to make Only Selected Curve Keyframes (and perhaps also Handles) default to ON, because this is extremely confusing to new users and the first thing I have to tell people to enable if they're doing animation and working in the graph editor. For most animators, you pretty much never want to select ALL curves. If you wanted to manipulate more than one curve at once you would manually select multiple curves. Normally you focus on one curve at a time. The default behaviour should be only selected.

Related: https://blender.community/c/rightclickselect/xsgbbc/

This RCS entry is about how locked curves should NOT be selectable, but it stems from the same problem of users accidentally selecting curves and keys they don't want with default settings.

One suggestion I would make, regardless of where they end up in the UI, is to make *Only Selected Curve Keyframes* (and perhaps also *Handles*) default to **ON**, because this is *extremely* confusing to new users and the first thing I have to tell people to enable if they're doing animation and working in the graph editor. For most animators, you pretty much never want to select ALL curves. If you wanted to manipulate more than one curve at once you would manually select multiple curves. Normally you focus on one curve at a time. The default behaviour should be **only selected**. Related: https://blender.community/c/rightclickselect/xsgbbc/ This RCS entry is about how locked curves should NOT be selectable, but it stems from the same problem of users accidentally selecting curves and keys they don't want with default settings.

Added subscriber: @LucianoMunoz

Added subscriber: @LucianoMunoz

Added subscriber: @AndyCuccaro

Added subscriber: @AndyCuccaro
Author
Member

I kinda agree here. The problem (too many handles) is less likely to occur with simple animations/new users, and not worth the confusion. More advanced animators should have an easier time/tendency to customize to their liking / task at hand.

I kinda agree here. The problem (too many handles) is less likely to occur with simple animations/new users, and not worth the confusion. More advanced animators should have an easier time/tendency to customize to their liking / task at hand.
Contributor

Added subscriber: @Nika-Kutsniashvili

Added subscriber: @Nika-Kutsniashvili
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:35:34 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#89069
No description provided.