Eevee instant crash with a custom node from template example #89260

New Issue

Pedro A. · 2021-06-18T09:51:45+02:00

Pedro A. commented

2021-06-18 09:51:45 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.27

Blender Version
Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: 84da05a8b8
Worked: (newest version of Blender that worked as expected)
Caused by e125305af4

Short description of error
Instant Blender crash when custom node template have defined some node with a enumerator property, and this property is named 'default_value'.
Not any problem if the property have different name, i.e. 'my_enum_prop' in the original template

Exact steps for others to reproduce the error

Load the attached scene
open script editor
run the current loaded script, this add a custom node entry in the node editor
change to node editor
add a custom node
try to render with Cycles: OK
try to render with Eevee: crash

[Based on the default startup or an attached .blend file (as simple as possible)]

eevee_crash.blend

I added an small video to explain. Sorry for my bad english!
eevee_crash.mp4

The blender_crash.txt generated..
blender.crash.txt

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.27 **Blender Version** Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: `84da05a8b8` Worked: (newest version of Blender that worked as expected) Caused by e125305af4 **Short description of error** Instant Blender crash when custom node template have defined some node with a enumerator property, and this property is named 'default_value'. Not any problem if the property have different name, i.e. 'my_enum_prop' in the original template **Exact steps for others to reproduce the error** - Load the attached scene - open script editor - run the current loaded script, this add a custom node entry in the node editor - change to node editor - add a custom node - try to render with Cycles: OK - try to render with Eevee: crash [Based on the default startup or an attached .blend file (as simple as possible)] [eevee_crash.blend](https://archive.blender.org/developer/F10179607/eevee_crash.blend) I added an small video to explain. Sorry for my bad english! [eevee_crash.mp4](https://archive.blender.org/developer/F10179612/eevee_crash.mp4) The blender_crash.txt generated.. [blender.crash.txt](https://archive.blender.org/developer/F10179631/blender.crash.txt)

Pedro A. commented

2021-06-18 09:51:45 +02:00

Added subscriber: @povmaniac

Pedro A. changed title from ~~Eevee instant crash whit a custom node from template example~~ to Eevee instant crash with a custom node from template example

2021-06-18 10:01:10 +02:00

Jeroen Bakker commented

2021-06-18 10:20:53 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker self-assigned this 2021-06-18 10:20:53 +02:00

Jeroen Bakker commented

2021-06-18 10:20:53 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2021-06-18 10:20:53 +02:00

Issue seems to be that the node compiler handles custom sockets as floats. float sockets has a default_value attribute but is stored in a different way, hence an error occurs.

Issue seems that the socket isn't marked with SOCK_CUSTOM.

Issue seems to be that the node compiler handles custom sockets as floats. float sockets has a default_value attribute but is stored in a different way, hence an error occurs. Issue seems that the socket isn't marked with SOCK_CUSTOM.

Jeroen Bakker removed their assignment 2021-06-18 10:42:11 +02:00

Pratik Borhade commented

2021-06-23 15:05:17 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-06-23 15:05:17 +02:00

Regression: Working fine with commit on master de06cb8559. Will bisect to find the culprit shortly :)

Regression: Working fine with commit on master de06cb8559. Will bisect to find the culprit shortly :)

Pratik Borhade commented

2021-06-27 13:26:18 +02:00

Here is the first bad commit: e125305af4

Working fine with commit on master de06cb8559

Looks like I was wrong up here, maybe I checked that with Cycles render engine :p

Here is the first bad commit: e125305af4 >Working fine with commit on master `de06cb8559` Looks like I was wrong up here, maybe I checked that with Cycles render engine :p

Campbell Barton commented

2021-07-21 06:12:22 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2021-07-21 06:12:22 +02:00

The error is that an enum property is being accessed as a float which shouldn't be happening.

e125305af41a7360c52b9a38024b7e24fde06d70 changed the layout of EnumPropertyRNA so the error was hidden before this (although it would assert in debug builds).

Support for enum sockets needs to be added or at the very least - skip them to avoid crashing.

The error is that an enum property is being accessed as a float which shouldn't be happening. `e125305af41a7360c52b9a38024b7e24fde06d70` changed the layout of `EnumPropertyRNA` so the error was hidden before this (although it would assert in debug builds). Support for enum sockets needs to be added or at the very least - skip them to avoid crashing.

Raimund Klink commented

2021-09-20 22:46:33 +02:00

Added subscriber: @Raimund58

Pedro A. commented

2021-09-22 11:41:39 +02:00

In #89260#1194020, @ideasman42 wrote:
The error is that an enum property is being accessed as a float which shouldn't be happening.

I can't understand this..
The code that I use in the attached scene is from the template examples included into Blender.
Can you explain in what part of the attached example code the enumproperty is accessed as a float ??
Best regards..
Pedro.

> In #89260#1194020, @ideasman42 wrote: > The error is that an enum property is being accessed as a float which shouldn't be happening. I can't understand this.. The code that I use in the attached scene is from the template examples included into Blender. Can you explain in what part of the attached example code the enumproperty is accessed as a float ?? Best regards.. Pedro.

Pedro A. commented

2021-09-22 12:07:57 +02:00

In #89260#1178699, @Jeroen-Bakker wrote:
Issue seems that the socket isn't marked with SOCK_CUSTOM.

I can't understand this.. where is it supposed to be marked as SOCK_CUSTOM, in the addon part or in the core of Blender?
Thanks for any explanation.
Cheers..

> In #89260#1178699, @Jeroen-Bakker wrote: > Issue seems that the socket isn't marked with SOCK_CUSTOM. I can't understand this.. where is it supposed to be marked as SOCK_CUSTOM, in the addon part or in the core of Blender? Thanks for any explanation. Cheers..

Pedro A. commented

2021-09-26 17:57:09 +02:00

I have investigate a bit this problem. There are the result:
A simple custom node with a enum property, called 'default_value' is enough to cause a crash, even if these node are disconnected from any node tree.
So the main question: why Eevee try to process a node, even not linked in the node tree, and created from other render engine???
The 'normal' behaviour, at least from all my addons is:

search for a 'output' node type
when is selected, the code check for any other node connected to these 'output' node.
if not any node connected, the search is stopped and these 'output' node is ignored.

Never, in any case, a isolated node is processed, except if is a output node type. And for more safety operation, each engine only search for they own output node types
I think Cycles does the same behavior, but why Eevee not?

The above defined policy allow create a multiple node trees into the editor, one for each engine, without issues.

Each engine only read your own nodes.

@ideasman42 @Jeroen-Bakker what do you think, guys? Any other clue are welcome.

I have investigate a bit this problem. There are the result: A simple custom node with a enum property, called 'default_value' is enough to cause a crash, even if these node are disconnected from any node tree. So the main question: why Eevee try to process a node, even not linked in the node tree, and created from other render engine??? The 'normal' behaviour, at least from all my addons is: - search for a 'output' node type - when is selected, the code check for any other node connected to these 'output' node. - if not any node connected, the search is stopped and these 'output' node is ignored. Never, in any case, a isolated node is processed, except if is a output node type. And for more safety operation, each engine only search for they own output node types I think Cycles does the same behavior, but why Eevee not? The above defined policy allow create a multiple node trees into the editor, one for each engine, without issues. ![imagen.png](https://archive.blender.org/developer/F10611147/imagen.png) Each engine only read your own nodes. @ideasman42 @Jeroen-Bakker what do you think, guys? Any other clue are welcome.

blender-admin commented

2021-11-15 08:07:11 +01:00

This issue was referenced by 419b4e0b00

This issue was referenced by 419b4e0b00c6e4191d1fd70925040e0215dd933d

blender-admin commented

2021-11-15 08:07:11 +01:00

This issue was referenced by a5c59fb90e

This issue was referenced by a5c59fb90ef9c3e330556703c86e720740cf2c8d

Jeroen Bakker commented

2021-11-15 08:15:37 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue