Improve Cycles OSL nodes interface #89741

New Issue

Pedro A. · 2021-07-08T20:20:15+02:00

Pedro A. commented

2021-07-08 20:20:15 +02:00

I have found that the interface of the OSL nodes has certain limitations. I think some of them could have a relatively easy solution. For example, change how vectors are displayed in the node. This simple change will improve the appearance of the larger nodes. Another aspect to improve is the interface for image files. Using a 'string' field allow to introducing typographical errors by the user. I think a PointerProperty to bpy.types.Image would be more convenient.
I hope these proposals make sense.

Main task list:

- Add code to processing the parameter metadata if exist.
- Define the correct node socket for a boolean case.
- Expand the code to processing the boolean socket value.
- Modify 'node_find_input_by_name' function code to use a 'identifier'.
- Redefine the function that remove the node inputs when the type don't match.
  Sub tasks:
- Add the properly metadata for booleans and maybe also for labels, into the OSL shaders included with Cycles.

I have found that the interface of the OSL nodes has certain limitations. I think some of them could have a relatively easy solution. For example, change how vectors are displayed in the node. This simple change will improve the appearance of the larger nodes. Another aspect to improve is the interface for image files. Using a 'string' field allow to introducing typographical errors by the user. I think a PointerProperty to bpy.types.Image would be more convenient. I hope these proposals make sense. ![vectors.png](https://archive.blender.org/developer/F10217283/vectors.png) Main task list: - - [x] Add code to processing the parameter metadata if exist. - - [x] Define the correct node socket for a boolean case. - - [x] Expand the code to processing the boolean socket value. - - [x] Modify 'node_find_input_by_name' function code to use a 'identifier'. - - [x] Redefine the function that remove the node inputs when the type don't match. Sub tasks: - - [ ] Add the properly metadata for booleans and maybe also for labels, into the OSL shaders included with Cycles.

Pedro A. commented

2021-07-08 20:20:15 +02:00

Added subscriber: @povmaniac

Pedro A. self-assigned this 2021-07-08 20:52:08 +02:00

Simon Sommer commented

2021-07-19 22:52:29 +02:00

Added subscriber: @CreatorSiSo

Pedro A. commented

2021-07-21 09:15:37 +02:00

I think the first step to improve how some options are drawn in the interface is to add a suitable definition for each option within the OSL code.
For example, for Booleans.

int zup = 0 [[ string widget = "checkBox", string label = "Z-Up", int connectable = 0 ]],

Without this definition, it is quite difficult to deduce when an option is a Boolean or an integer.

I think the first step to improve how some options are drawn in the interface is to add a suitable definition for each option within the OSL code. For example, for Booleans. ``` int zup = 0 [[ string widget = "checkBox", string label = "Z-Up", int connectable = 0 ]], ``` Without this definition, it is quite difficult to deduce when an option is a Boolean or an integer.

Brecht Van Lommel commented

2021-07-21 15:25:49 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2021-07-21 15:25:49 +02:00

Vector input: it's unclear how that relates to OSL metadata. With horizontal X/Y/Z values there is not enough space in typical node sizes, and it's unclear how this is different for OSL than any other type of node.
Image datablocks: these have more information than just a filepath string. The image may be packed, dynamically generated, and have additional parameters such as frame number or layer/pass. How that would map to OSL parameters (or not) would need to be defined. It also relates to this discussion: https://devtalk.blender.org/t/input-socket-for-image-texture-shader-node/19601
Boolean input: this is the easiest one, just needs minor changes to handle boolean sockets as integers in the Cycles/Eevee code

* Vector input: it's unclear how that relates to OSL metadata. With horizontal X/Y/Z values there is not enough space in typical node sizes, and it's unclear how this is different for OSL than any other type of node. * Image datablocks: these have more information than just a filepath string. The image may be packed, dynamically generated, and have additional parameters such as frame number or layer/pass. How that would map to OSL parameters (or not) would need to be defined. It also relates to this discussion: https://devtalk.blender.org/t/input-socket-for-image-texture-shader-node/19601 * Boolean input: this is the easiest one, just needs minor changes to handle boolean sockets as integers in the Cycles/Eevee code

Pedro A. commented

2021-07-21 15:59:32 +02:00

Thanks for your tips, Brecht.
Vector input: the idea is save vertical space in the node, but yes, in the 'normal' node sizes the horizontal space maybe is not enough. But the user can extend the node size easily.
Image datablock: currently I use the typicall 'template_ID' image file interface for my nodes, that is not perfect but is very clossely to the used in the Blender texture node.
{F10231931, width=100%}

Thanks for your tips, Brecht. Vector input: the idea is save vertical space in the node, but yes, in the 'normal' node sizes the horizontal space maybe is not enough. But the user can extend the node size easily. Image datablock: currently I use the typicall 'template_ID' image file interface for my nodes, that is not perfect but is very clossely to the used in the Blender texture node. {[F10231931](https://archive.blender.org/developer/F10231931/image_data.png), width=100%}

Pedro A. commented

2021-07-26 14:55:40 +02:00

After some testing, I have verified that the definition of each property added in the .osl file is processed and added in metadata format inside the .oso file

shader node_ies_light(int use_mapping = 0 [[ string label="Use Mapping", string widget="checkBox" ]],

This generates the following metadata:

param int use_mapping 0 %meta{string,label,"Use Mapping"} %meta{string,widget,"checkBox"}  %read{2,2} %write{2147483647,-1}

The next step is to add the property definition in some cases like booleans or image files.
Later, we can advise users to do the same when using their own OSL code.

After some testing, I have verified that the definition of each property added in the .osl file is processed and added in metadata format inside the .oso file ``` shader node_ies_light(int use_mapping = 0 [[ string label="Use Mapping", string widget="checkBox" ]], ``` This generates the following metadata: ``` param int use_mapping 0 %meta{string,label,"Use Mapping"} %meta{string,widget,"checkBox"} %read{2,2} %write{2147483647,-1} ``` The next step is to add the property definition in some cases like booleans or image files. Later, we can advise users to do the same when using their own OSL code.

Pedro A. commented

2021-07-29 10:39:51 +02:00

I have created a first patch for review by the Blender developers. https://developer.blender.org/D12074

Pedro A. commented

2021-07-30 10:53:08 +02:00

@brecht I applied all the required changes and I added the blender_shader.cpp part that I think is necessary modify. https://developer.blender.org/D12074?id=40152
Thanks..

@brecht I applied all the required changes and I added the blender_shader.cpp part that I think is necessary modify. https://developer.blender.org/D12074?id=40152 Thanks..

blender-admin commented

2021-08-11 14:49:48 +02:00

This issue was referenced by e6bbbd965a

This issue was referenced by e6bbbd965a447249393a27f911a1b29595c439ab

Brecht Van Lommel added this to the Render & Cycles project 2023-02-07 19:08:35 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Improve Cycles OSL nodes interface #89741