Image Editor not sampling color from the the currently selected pass #90772

New Issue

Philipp Oeser · 2021-08-19T12:09:47+02:00

Philipp Oeser commented

2021-08-19 12:09:47 +02:00

System Information
Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.33.9000 64 Bits
Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.31

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-19 07:56, hash: 4db4123409
Broken: 2.92.0
Worked: 2.91.2

Caused by ebaa3fcedd

Short description of error
Image Editor not sampling color from the the currently selected pass

Exact steps for others to reproduce the error
from the default startup scene:

change the 3D view to an Image Editor
open EXR from below
in the header, change the layer from Composite to View Layer
sample a color from the image using {key LMB} (note the status bar doing this)
in the header, change the pass from Combined to AOV
note in the status bar that we are still sampling from the Combined pass
interestingly, when file is saved in that state and reverted: all is fine (you can now change passes / layers and sampling takes this into account correctly)

**System Information** Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.33.9000 64 Bits Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.31 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-19 07:56, hash: `4db4123409` Broken: 2.92.0 Worked: 2.91.2 Caused by ebaa3fcedd **Short description of error** Image Editor not sampling color from the the currently selected pass **Exact steps for others to reproduce the error** from the default startup scene: - change the 3D view to an Image Editor - open EXR from below - in the header, change the layer from `Composite` to `View Layer` - sample a color from the image using {key LMB} (note the status bar doing this) - in the header, change the pass from `Combined` to `AOV` - note in the status bar that we are still sampling from the `Combined` pass - interestingly, when file is saved in that state and reverted: all is fine (you can now change passes / layers and sampling takes this into account correctly) ![0001_30.exr](https://archive.blender.org/developer/F10291325/0001_30.exr)

Philipp Oeser commented

2021-08-19 12:09:47 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-08-19 12:10:22 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser self-assigned this 2021-08-19 12:10:22 +02:00

Philipp Oeser commented

2021-08-19 12:10:22 +02:00

Will check on this a bit myself.

blender-admin commented

2021-08-19 14:03:48 +02:00

This issue was referenced by 1af6e0daaf

This issue was referenced by 1af6e0daaf6ba47c083e9cd451fe145f7545bc79

blender-admin commented

2021-08-19 14:03:48 +02:00

This issue was referenced by 5aa3167e48

This issue was referenced by 5aa3167e48b202f4883ce948ba8e3469e3eaf3ec

Philipp Oeser commented

2021-08-19 14:05:20 +02:00

Added subscriber: @Jeroen-Bakker

Philipp Oeser commented

2021-08-19 14:05:20 +02:00

This will need a bit more investigation, but here are some notes/questions for now:

this reason for all this is that we are looking up a cached image buffer via an index (and this index is not right in our case)
depending on the type of image this index can have different meaning (stereo image, layers&passes, ...)
this index is usually taken from an ImageUser (the ImageEditor is such a user -- and in its UI you can pick the displayed layer/pass for example via template_image_layers), this is stored in ImageUser->multi_index
this is where I need more research (procedure of updating ImageEditor ImageUser seems weird -- when changing something in the UI the template acts on a copy of the original ImageUser, the real ImageUser gets updated when aquiring the ImageBuf? [see e.g. usages of BKE_image_multilayer_index / BKE_image_multiview_index])
so summing it up for now: the ImageEditor ImageUser is not really up-to-date when starting the sampling, it has a multi_index of zero (and with this [false] index, it finds a [false] cached image -- the wrong pass)
also need to check why this was not a problem in 2.91

that being said, D12267 is already working (making sure we dont overwrite multi_index with something wrong)

This will need a bit more investigation, but here are some notes/questions for now: - this reason for all this is that we are looking up a cached image buffer via an index (and this index is not right in our case) - depending on the type of image this index can have different meaning (stereo image, layers&passes, ...) - this index is usually taken from an ImageUser (the ImageEditor is such a user -- and in its UI you can pick the displayed layer/pass for example via `template_image_layers`), this is stored in `ImageUser->multi_index` - this is where I need more research (procedure of updating `ImageEditor` `ImageUser` seems weird -- when changing something in the UI the template acts on a copy of the original `ImageUser`, the real `ImageUser` gets updated when aquiring the ImageBuf? [see e.g. usages of `BKE_image_multilayer_index` / `BKE_image_multiview_index`]) - so summing it up for now: the `ImageEditor` `ImageUser` is not really up-to-date when starting the sampling, it has a multi_index of zero (and with this [false] index, it finds a [false] cached image -- the wrong pass) - also need to check why this was not a problem in 2.91 that being said, [D12267](https://archive.blender.org/developer/D12267) is already working (making sure we dont overwrite `multi_index` with something wrong)

Philipp Oeser commented

2021-08-23 13:58:09 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2021-08-23 13:58:09 +02:00

Falk David referenced this issue

2023-02-10 13:03:22 +01:00

Blender LTS: Maintenance Task 2.93 #88449

Sign in to join this conversation.