Symmetrize Armature should symmetrize transform of custom bone shape #91871

New Issue

Sybren A. Stüvel · 2021-10-01T12:55:14+02:00

Sybren A. Stüvel commented

2021-10-01 12:55:14 +02:00

Status: waiting for a developer to implement this.

Team
Commissioner: @Mets
Project leader: @dr.sybren

Description
Big picture: Symmetrize Armature (manual & python docs) does not yet take the new transform parameters of custom bone shapes (fc5bf09fd8) into account.

**Status:** waiting for a developer to implement this. **Team** **Commissioner:** @Mets **Project leader:** @dr.sybren **Description** **Big picture:** *Symmetrize Armature* ([manual](https:*docs.blender.org/manual/en/dev/animation/armatures/bones/editing/symmetrize.html) & [python docs](https:*docs.blender.org/api/master/bpy.ops.armature.html#bpy.ops.armature.symmetrize)) does not yet take the new transform parameters of custom bone shapes (fc5bf09fd8) into account.

Sybren A. Stüvel commented

2021-10-01 12:55:14 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel commented

2021-10-01 12:55:14 +02:00

Added subscribers: @Mets, @dr.sybren

AquaticNightmare commented

2021-10-02 17:16:16 +02:00

Added subscriber: @AquaticNightmare

Paolo Acampora commented

2021-11-25 18:03:31 +01:00

Added subscriber: @PaoloAcampora

Paolo Acampora commented

2021-11-26 20:08:01 +01:00

the task is not too complicated per se, perhaps there are some implications that should be discussed.

The function updateDuplicateCustomBoneShapes() looks for existing symmetric shapes. If a bone has mirrored a custom shape named "MyShape.R", and "MyShape.L" is found, the latter will be used.

What is the operator supposed to do in that case? If there is a Symmetric shape in the scene, this will likely be symmetric already.

I propose that the transforms are left untouched if a shape for the mirrorred side is found.

Also, I wonder if we should have a boolean or even an enumerator property:

Boolean proposal:
- Symmetrize Custom Shape Transform:
- False: Old Behaviour
- True: Symmetrize (If no symmetric shape is found)

Enum proposal:
- No Shape Simmetry
- Symmetrize Same Shape
- Symmetrize Always

Would that be useful, or are we ok with silently symmetrizing same shapes?

the task is not too complicated per se, perhaps there are some implications that should be discussed. The function *updateDuplicateCustomBoneShapes()* looks for existing symmetric shapes. If a bone has mirrored a custom shape named "MyShape.R", and "MyShape.L" is found, the latter will be used. What is the operator supposed to do in that case? If there is a Symmetric shape in the scene, this will likely be symmetric already. I propose that the transforms are left untouched if a shape for the mirrorred side is found. Also, I wonder if we should have a boolean or even an enumerator property: Boolean proposal: - Symmetrize Custom Shape Transform: - False: Old Behaviour - True: Symmetrize (If no symmetric shape is found) Enum proposal: - No Shape Simmetry - Symmetrize Same Shape - Symmetrize Always Would that be useful, or are we ok with silently symmetrizing same shapes?

Paolo Acampora commented

2021-11-29 19:07:18 +01:00

Uploaded a diff [here (D13416)](https://developer.blender.org/D13416)

Uploaded a diff [here ([D13416](https://archive.blender.org/developer/D13416))](https://developer.blender.org/D13416)

Sybren A. Stüvel commented

2022-01-06 12:11:33 +01:00

@PaoloAcampora or @Mets do you have an example file with non-symmetrical custom shapes that gets symmetrized correctly with D13416?

@PaoloAcampora or @Mets do you have an example file with non-symmetrical custom shapes that gets symmetrized correctly with [D13416](https://archive.blender.org/developer/D13416)?

Paolo Acampora commented

2022-01-06 15:57:46 +01:00

Hi @dr.sybren, Demeter jas uploaded a .blend with four possible scenarios on diff page, is that good?

https://dev-files.blender.org/file/download/5ctpllqpn232spfp3qsj/PHID-FILE-a5j6ybnjjaltnpitdxy5/symmetrize_custom_shape_transform_test3.blend

Hi @dr.sybren, Demeter jas uploaded a .blend with four possible scenarios on diff page, is that good? https://dev-files.blender.org/file/download/5ctpllqpn232spfp3qsj/PHID-FILE-a5j6ybnjjaltnpitdxy5/symmetrize_custom_shape_transform_test3.blend

blender-admin commented

2022-02-08 18:08:12 +01:00

This issue was referenced by 452a7f6731

This issue was referenced by 452a7f673190e5161c96ec8a53631a1c89d127b9

Sybren A. Stüvel commented

2022-02-08 18:12:10 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2022-02-08 18:12:10 +01:00

Sybren A. Stüvel self-assigned this 2022-02-08 18:12:10 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Symmetrize Armature should symmetrize transform of custom bone shape #91871