File selector dialog: long file extension filtering does not work #92610

New Issue

Thomas Lachmann · 2021-10-29T14:02:17+02:00

Thomas Lachmann commented

2021-10-29 14:02:17 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: Intel(R) HD Graphics 615 Intel 4.5.0 - Build 27.20.100.8854

Blender Version
Broken:
version: 3.0.0 Beta, branch: master, commit date: 2021-10-27 22:07, hash: b838eaf2b9
version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: a791bdabd0
Worked: probably never

Short description of error
If you try to filter files inside the file selector with filter_glob, this only works for extensions with a max. length of 15 chars including *.

Because today some file extensions are much longer, I would suggest to increase the maximum allowed file extension length.

Exact steps for others to reproduce the error
Create a file with the extension .12345678901234567890
Load the attached script and navigfate to the folder where you created the file.
It will not displayed in the file selector.

operator_file_import_test.py

Solution
In path_util.c in the function BLI_path_extension_check_glob the search pattern is limited to 16 chars.
I would suggest to increase this value to 33 chars.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: Intel(R) HD Graphics 615 Intel 4.5.0 - Build 27.20.100.8854 **Blender Version** Broken: version: 3.0.0 Beta, branch: master, commit date: 2021-10-27 22:07, hash: `b838eaf2b9` version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: `a791bdabd0` Worked: probably never **Short description of error** If you try to filter files inside the file selector with filter_glob, this only works for extensions with a max. length of 15 chars including `*.` Because today some file extensions are much longer, I would suggest to increase the maximum allowed file extension length. **Exact steps for others to reproduce the error** Create a file with the extension `.12345678901234567890` Load the attached script and navigfate to the folder where you created the file. It will not displayed in the file selector. ![Screenshot.PNG](https://archive.blender.org/developer/F11596771/Screenshot.PNG) [operator_file_import_test.py](https://archive.blender.org/developer/F11596645/operator_file_import_test.py) **Solution** In [path_util.c ](https://developer.blender.org/diffusion/B/browse/master/source/blender/blenlib/intern/path_util.c) in the function `BLI_path_extension_check_glob` the search pattern is limited to 16 chars. I would suggest to increase this value to 33 chars.

Thomas Lachmann commented

2021-10-29 14:02:17 +02:00

Added subscriber: @Lachi

Harley Acheson commented

2021-10-29 17:46:58 +02:00

Added subscriber: @Harley

Harley Acheson commented

2021-10-29 17:46:58 +02:00

@Lachi - Because today some file extensions are much longer…

Could you include some real-world examples of some that are longer? The longest I’ve seen anywhere are “crdownload”, “psppalette”, “symboliclink”, “vbox-extpack”, “witness-campaign”

> @Lachi - Because today some file extensions are much longer… Could you include some real-world examples of some that are longer? The longest I’ve seen anywhere are “crdownload”, “psppalette”, “symboliclink”, “vbox-extpack”, “witness-campaign”

Thomas Lachmann commented

2021-10-29 20:45:04 +02:00

In #92610#1244313, @Harley wrote:

@Lachi - Because today some file extensions are much longer…

Could you include some real-world examples of some that are longer? The longest I’ve seen anywhere are “crdownload”, “psppalette”, “symboliclink”, “vbox-extpack”, “witness-campaign”

I've an inhouse appilcation here where the file extension is .ILDRenderOptimization.
But I've also found a workaround, so I guess this could be closed.

> In #92610#1244313, @Harley wrote: >> @Lachi - Because today some file extensions are much longer… > > Could you include some real-world examples of some that are longer? The longest I’ve seen anywhere are “crdownload”, “psppalette”, “symboliclink”, “vbox-extpack”, “witness-campaign” I've an inhouse appilcation here where the file extension is .ILDRenderOptimization. But I've also found a workaround, so I guess this could be closed.

Bastien Montagne commented

2021-11-01 15:50:39 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2021-11-01 15:50:39 +01:00

@Harley please only tag a specific release if it is either a regression from previous release, or well known-and-agreed to be worked on said release. Also filebrowser is not #core, but #pipeline_assets_i_o

Harley Acheson commented

2021-11-01 16:12:44 +01:00

@mont29 - please only tag a specific release...

I didn't set or change any tags here. That was OP.

> @mont29 - please only tag a specific release... I didn't set or change any tags here. That was OP.

Bastien Montagne commented

2021-11-01 16:53:08 +01:00

@Harley woops, my bad... Then @Lachi please do not do any specific triaging/tagging/etc. on a report, unless you are absolutely sure to be doing the right thing. This is the job of the triaging and/or dev team.

Thomas Lachmann commented

2021-11-02 13:23:50 +01:00

In #92610#1245882, @mont29 wrote:
@Harley woops, my bad... Then @Lachi please do not do any specific triaging/tagging/etc. on a report, unless you are absolutely sure to be doing the right thing. This is the job of the triaging and/or dev team.

sure, I will do this in the future

> In #92610#1245882, @mont29 wrote: > @Harley woops, my bad... Then @Lachi please do not do any specific triaging/tagging/etc. on a report, unless you are absolutely sure to be doing the right thing. This is the job of the triaging and/or dev team. sure, I will do this in the future

Germano Cavalcante commented

2021-11-04 15:17:39 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne added this to the Pipeline, Assets & IO project 2023-02-09 15:40:39 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

File selector dialog: long file extension filtering does not work #92610