Custom node sockets don't get relinked when dropping a node on an existing link #93430

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49

Blender Version
Broken: version: 3.0.0 Release Candidate, branch: master, commit date: 2021-11-25 17:24, hash: 2fb8c6805a
Worked: version: 3.0.0 Beta, branch: master, commit date: 2021-11-07 23:44, hash: 56ee96349d (maybe also with a bit newer versions, that was the last one I was using before updating to the release candidate)

Short description of error
When creating custom python nodes that have only custom sockets, the node can't be dropped onto an existing link. This is not the case if the node has normal blender sockets, only with custom ones. It also doesn't happen if the node has blender and custom sockets as the blender sockets will be connected and the custom ones ignored.

Exact steps for others to reproduce the error

Open the attached file and run the script in the text editor (this is the default custom node template with the blender internal sockets removed from the demo node)
Drop the free floating node in the custom node editor onto the link between the other two nodes
The node will not be linked up with the other nodes

If the same process is repeated in the version marked as working above the node is connected to the other two. If the same thing is done with the original default custom node template, the custom sockets will be ignored and the blender internal sockets will connect.

custom node tree.blend

Added subscriber: @JoshuaKnauber

#93438 was marked as duplicate of this issue

Added subscriber: @lichtwerk

Has also been reported in #93438 (Custom nodes no longer get inserted in between two linked nodes)

This issue was referenced by 61fe0d6264

This issue was referenced by ab2a7aa0da

Added subscriber: @PratikPB2123

Changed status from 'Needs Triage' to: 'Resolved'

Can confirm this has been fixed by: ab2a7aa0da

Will close the report. Feel free to reopen if you are still able to reproduce. And thanks for the report :)

Added subscriber: @valera-8

@PratikPB2123 @OmarEmaraDev

This is still broken for my add-on in 3.0.0, can you take a look at it please?

terrain_nodes_demo.zip

@valera-8 This fix didn't make it in 3.0 unfortunately, we only fixed it a few days before the 3.0 release.

This comment was removed by @JoshuaKnauber

@lichtwerk , would it be safe to add this fix for 3.0.1? (Commit did not break anything so far)

In #93430#1270259, @OmarEmaraDev wrote:
@valera-8 This fix didn't make it in 3.0 unfortunately, we only fixed it a few days before the 3.0 release.

This should definitely be in 3.0.1, thanks for the fix much appreciated!

On the list now #93479 (3.0 Potential candidates for corrective releases)

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Custom node sockets don't get relinked when dropping a node on an existing link #93430