Custom node sockets don't get relinked when dropping a node on an existing link #93430

Closed
opened 2021-11-27 16:44:33 +01:00 by Joshua Knauber · 16 comments

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49

Blender Version
Broken: version: 3.0.0 Release Candidate, branch: master, commit date: 2021-11-25 17:24, hash: 2fb8c6805a
Worked: version: 3.0.0 Beta, branch: master, commit date: 2021-11-07 23:44, hash: 56ee96349d (maybe also with a bit newer versions, that was the last one I was using before updating to the release candidate)

Short description of error
When creating custom python nodes that have only custom sockets, the node can't be dropped onto an existing link. This is not the case if the node has normal blender sockets, only with custom ones. It also doesn't happen if the node has blender and custom sockets as the blender sockets will be connected and the custom ones ignored.

Exact steps for others to reproduce the error

  • Open the attached file and run the script in the text editor (this is the default custom node template with the blender internal sockets removed from the demo node)
  • Drop the free floating node in the custom node editor onto the link between the other two nodes
  • The node will not be linked up with the other nodes

If the same process is repeated in the version marked as working above the node is connected to the other two. If the same thing is done with the original default custom node template, the custom sockets will be ignored and the blender internal sockets will connect.

custom node tree.blend

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49 **Blender Version** Broken: version: 3.0.0 Release Candidate, branch: master, commit date: 2021-11-25 17:24, hash: `2fb8c6805a` Worked: version: 3.0.0 Beta, branch: master, commit date: 2021-11-07 23:44, hash: `56ee96349d` (maybe also with a bit newer versions, that was the last one I was using before updating to the release candidate) **Short description of error** When creating custom python nodes that have only custom sockets, the node can't be dropped onto an existing link. This is not the case if the node has normal blender sockets, only with custom ones. It also doesn't happen if the node has blender and custom sockets as the blender sockets will be connected and the custom ones ignored. **Exact steps for others to reproduce the error** - Open the attached file and run the script in the text editor (this is the default custom node template with the blender internal sockets removed from the demo node) - Drop the free floating node in the custom node editor onto the link between the other two nodes - The node will not be linked up with the other nodes If the same process is repeated in the version marked as working above the node is connected to the other two. If the same thing is done with the original default custom node template, the custom sockets will be ignored and the blender internal sockets will connect. [custom node tree.blend](https://archive.blender.org/developer/F12434623/custom_node_tree.blend)
Author

Added subscriber: @JoshuaKnauber

Added subscriber: @JoshuaKnauber

#93438 was marked as duplicate of this issue

#93438 was marked as duplicate of this issue
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Has also been reported in #93438 (Custom nodes no longer get inserted in between two linked nodes)

Has also been reported in #93438 (Custom nodes no longer get inserted in between two linked nodes)

This issue was referenced by 61fe0d6264

This issue was referenced by 61fe0d626441fbe07020e1478fba95983e7c94e5

This issue was referenced by ab2a7aa0da

This issue was referenced by ab2a7aa0da81678b19e3362b93f89e8302da65d8
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Resolved'

Changed status from 'Needs Triage' to: 'Resolved'
Omar Emara was assigned by Pratik Borhade 2021-11-29 13:40:21 +01:00
Member

Can confirm this has been fixed by: ab2a7aa0da

Will close the report. Feel free to reopen if you are still able to reproduce. And thanks for the report :)

Can confirm this has been fixed by: ab2a7aa0da Will close the report. Feel free to reopen if you are still able to reproduce. And thanks for the report :)
Member

Added subscriber: @valera-8

Added subscriber: @valera-8

@PratikPB2123 @OmarEmaraDev

This is still broken for my add-on in 3.0.0, can you take a look at it please?

terrain_nodes_demo.zip

@PratikPB2123 @OmarEmaraDev This is still broken for my add-on in 3.0.0, can you take a look at it please? [terrain_nodes_demo.zip](https://archive.blender.org/developer/F12727484/terrain_nodes_demo.zip)
Member

@valera-8 This fix didn't make it in 3.0 unfortunately, we only fixed it a few days before the 3.0 release.

@valera-8 This fix didn't make it in 3.0 unfortunately, we only fixed it a few days before the 3.0 release.
Author

This comment was removed by @JoshuaKnauber

*This comment was removed by @JoshuaKnauber*
Member

@lichtwerk , would it be safe to add this fix for 3.0.1? (Commit did not break anything so far)

@lichtwerk , would it be safe to add this fix for 3.0.1? (Commit did not break anything so far)

In #93430#1270259, @OmarEmaraDev wrote:
@valera-8 This fix didn't make it in 3.0 unfortunately, we only fixed it a few days before the 3.0 release.

This should definitely be in 3.0.1, thanks for the fix much appreciated!

> In #93430#1270259, @OmarEmaraDev wrote: > @valera-8 This fix didn't make it in 3.0 unfortunately, we only fixed it a few days before the 3.0 release. This should definitely be in 3.0.1, thanks for the fix much appreciated!
Member

On the list now #93479 (3.0 Potential candidates for corrective releases)

On the list now #93479 (3.0 Potential candidates for corrective releases)
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#93430
No description provided.