Support warnings for field input nodes #94039

New Issue

Hans Goudey · 2021-12-14T01:05:45+01:00

Hans Goudey commented

2021-12-14 01:05:45 +01:00

Field input nodes evaluate in a context, but currently they give no warning if they do not support
a particular context. The initial goal is to add a warning like "Input node does not support geometry type: Mesh" on the spline parameter node in the following situation:

{F12738459 size=full}

Implementation

A potential implementation isn't clear.
It seems there needs to be a way to keep track of which node (bNode, NodeRef, DNode, etc.) the field input node came from.
Then the field evaluation system should have a way to collect errors and return them to the caller. Or maybe the caller can pass a
"logger" class to the field evaluation system. That generalization could allow more specific breakdowns of node timing in the future.

Field input nodes evaluate in a context, but currently they give no warning if they do not support a particular context. The initial goal is to add a warning like "Input node does not support geometry type: Mesh" on the spline parameter node in the following situation: {[F12738459](https://archive.blender.org/developer/F12738459/image.png) size=full} ### Implementation A potential implementation isn't clear. It seems there needs to be a way to keep track of which node (`bNode`, `NodeRef`, `DNode`, etc.) the field input node came from. Then the field evaluation system should have a way to collect errors and return them to the caller. Or maybe the caller can pass a "logger" class to the field evaluation system. That generalization could allow more specific breakdowns of node timing in the future.

Hans Goudey commented

2021-12-14 01:05:45 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2021-12-14 01:05:45 +01:00

Added subscriber: @HooglyBoogly

Yuro commented

2021-12-14 04:22:11 +01:00

Added subscriber: @Yuro

Paul Larson commented

2021-12-15 02:51:20 +01:00

Added subscriber: @GeorgiaPacific

Hans Goudey was assigned by Jacques Lucke

2021-12-20 14:14:36 +01:00

Iliya Katushenock commented

2022-09-03 22:44:21 +02:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-09-03 22:44:21 +02:00

I think the most noticeable detail is that this message should not be for a host. This is a connection error. That is, the message on the connection curve will be the most informative (as red is now for fields and singles). That is, the user (preferably right before the field evaluation node itself) sees that the connection contains 1 (or many) unsupported in context inputs. Or it could be for a socket, but I think that way the socket will be overloaded.

Hans Goudey added this to the Nodes & Physics project 2023-02-15 22:21:15 +01:00

Hans Goudey removed their assignment 2023-02-15 22:21:22 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Support warnings for field input nodes #94039

Implementation