Saved keymap changes do not remove "Restore" button #94178

Open
opened 1 year ago by Rawalanche · 5 comments

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76

Blender Version
Broken: version: 3.0.0, branch: SelectThrough (modified), commit date: 2021-12-15 12:21, hash: 6349dd43b1
Worked: (newest version of Blender that worked as expected)

Short description of error
When editing Keymaps, the keymaps very often incorrectly show "Restore" button even though there is no difference between saved and active keymap. This is very frustrating as it constantly keeps the user uncertain about the state of the keymap and often leads to corruption of keymaps due to unintended changes.

Exact steps for others to reproduce the error

  1. Make a copy of a default keymap and save it under a new name.
  2. Make modifications to this new keymap
  3. Using the + button, save the the modified keymap under the same name to overwrite it
  4. Notice the "Restore" buttons under keymap entries are still present
  5. Open any section with the "Restore" button and then click it. Observe no changes to the section.
    Result: Restore button is still present but it does not restore any changes. This makes user think the given section is modified, while it is not.
    Expected: Restore buttons do not appear next to section with no changed entries.

OR:

  1. Make a copy of a default keymap and save it under a new name.
  2. Make modifications to this new keymap
  3. Export this new keymap into a file
  4. Import this keymap back from the file to overwrite it
  5. Notice the "Restore" buttons under keymap entries are still present
  6. Open any section with the "Restore" button and then click it. Observe no changes to the section.
    Result: Restore button is still present but it does not restore any changes. This makes user think the given section is modified, while it is not.
    Expected: Restore buttons do not appear next to section with no changed entries.
**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76 **Blender Version** Broken: version: 3.0.0, branch: SelectThrough (modified), commit date: 2021-12-15 12:21, hash: `6349dd43b1` Worked: (newest version of Blender that worked as expected) **Short description of error** When editing Keymaps, the keymaps very often incorrectly show "Restore" button even though there is no difference between saved and active keymap. This is very frustrating as it constantly keeps the user uncertain about the state of the keymap and often leads to corruption of keymaps due to unintended changes. **Exact steps for others to reproduce the error** 1. Make a copy of a default keymap and save it under a new name. 2. Make modifications to this new keymap 3. Using the + button, save the the modified keymap under the same name to overwrite it 4. Notice the "Restore" buttons under keymap entries are still present 5. Open any section with the "Restore" button and then click it. Observe no changes to the section. Result: Restore button is still present but it does not restore any changes. This makes user think the given section is modified, while it is not. Expected: Restore buttons do not appear next to section with no changed entries. OR: 1. Make a copy of a default keymap and save it under a new name. 2. Make modifications to this new keymap 3. Export this new keymap into a file 4. Import this keymap back from the file to overwrite it 5. Notice the "Restore" buttons under keymap entries are still present 6. Open any section with the "Restore" button and then click it. Observe no changes to the section. Result: Restore button is still present but it does not restore any changes. This makes user think the given section is modified, while it is not. Expected: Restore buttons do not appear next to section with no changed entries.
Poster

Added subscriber: @Rawalanche

Added subscriber: @Rawalanche
Collaborator

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Collaborator

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123

Added subscriber: @Hologram

Added subscriber: @Hologram

Yesterday, I noticed that there were still keymaps from the Booltool present in my keymap, after having uninstalled the addon over a year ago. When I removed the entries, I could not remove one of the items. Though after saving my preferences, the restore button was still there, when I clicked on it, all of the booltool shortcuts I had previously removed, returned. So this can have unforseen consequences even after saving preferences!

Yesterday, I noticed that there were still keymaps from the Booltool present in my keymap, after having uninstalled the addon over a year ago. When I removed the entries, I could not remove one of the items. Though after saving my preferences, the restore button was still there, when I clicked on it, all of the booltool shortcuts I had previously removed, returned. So this can have unforseen consequences even after saving preferences!
lichtwerk removed the
legacy module/User Interface
label 5 hours ago
lichtwerk removed the
Interest/User Interface
label 5 hours ago
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Pose Library Basics
legacy project/Retrospective
legacy project/Tracker Curfew
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#94178
Loading…
There is no content yet.