GP Lineart ignores subdivision modifier with GPU subdivisions on #95470

Closed
opened 2022-02-03 13:56:59 +01:00 by Aleš Jelovčan · 12 comments

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce MX330/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.42

Blender Version
Broken: version: 3.2.0 Alpha, branch: asset-greasepencil, commit date: 2022-01-30 10:24, hash: 8eab21729b
Worked: 3.1

Caused by eed45d2a23

Short description of error
See image:
image.png
It works correctly when GPU subdivisions are turned OFF
Exact steps for others to reproduce the error
Add Scene lineart and subdivide default cube

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce MX330/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.42 **Blender Version** Broken: version: 3.2.0 Alpha, branch: asset-greasepencil, commit date: 2022-01-30 10:24, hash: `8eab21729b` Worked: 3.1 Caused by eed45d2a23 **Short description of error** See image: ![image.png](https://archive.blender.org/developer/F12843643/image.png) It works correctly when GPU subdivisions are turned OFF **Exact steps for others to reproduce the error** Add Scene lineart and subdivide default cube

Added subscriber: @frogstomp-4

Added subscriber: @frogstomp-4
Member
Added subscribers: @ChengduLittleA, @kevindietrich, @antoniov, @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Similar to #94479 (GPU Subdivision surface modifier does not apply to Cycles renders ), but this time for lineart.
Will set to High prio here as well, not sure if @kevindietrich can handle this, too?

CC @ChengduLittleA , @antoniov

Similar to #94479 (GPU Subdivision surface modifier does not apply to Cycles renders ), but this time for lineart. Will set to High prio here as well, not sure if @kevindietrich can handle this, too? CC @ChengduLittleA , @antoniov
YimingWu self-assigned this 2022-02-07 14:58:40 +01:00
Member

Thanks for the head up. I shall take a look. Not entirely sure how GPU subdiv evaluation works... If can spit out actual Mesh in CPU side for latter modifiers, then I believe this is easily fixable.

Thanks for the head up. I shall take a look. Not entirely sure how GPU subdiv evaluation works... If can spit out actual `Mesh` in CPU side for latter modifiers, then I believe this is easily fixable.

@ChengduLittleA I think you can fix this by calling BKE_object_get_evaluated_mesh̀ instead of directly accessing Object.data to get the mesh. This will ensure that the subdivision is also computed on the CPU side.

@ChengduLittleA I think you can fix this by calling `BKE_object_get_evaluated_mesh̀` instead of directly accessing `Object.data` to get the mesh. This will ensure that the subdivision is also computed on the CPU side.
Member

Thank you! @kevindietrich I shall try this!

Thank you! @kevindietrich I shall try this!

This issue was referenced by de886884c0

This issue was referenced by de886884c07f1fcb5ad9473035cc2e471d3b13c8

This issue was referenced by 991781c8ea

This issue was referenced by 991781c8eabefbcadc534bce3af32c4a7c61b59f

Added subscriber: @ThomasDinges

Added subscriber: @ThomasDinges

@ChengduLittleA Please always mention the Txxxx in a commit, when it fixes a bug report. It will automatically close the task then.

Also this should have been commited to the 3.1 branch, instead of master.

@ChengduLittleA Please always mention the Txxxx in a commit, when it fixes a bug report. It will automatically close the task then. Also this should have been commited to the 3.1 branch, instead of master.
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#95470
No description provided.