Split Asset and File Browser frontend, implement Grid View #95653

Open
opened 2022-02-09 17:57:26 +01:00 by Julian Eisel · 5 comments
Member

Having the Asset Browser be a sub-editor of the File Browser turned out to cause a whole number of issues. These are not easy to fix in the existing code, which is hard to work with additionally. The Asset Browser shouldn't be based on the File Browser's file-list design, but on the asset system.

In context, this works towards this architecture: Architecture Design - Planned Design (WIP).jpg
Essentially, this task covers the following:

  • Split the Asset and File Browser into separate editors
  • Introduce a new grid view system (similar to the new tree-views ) providing general UI functionality and optimized display of big data-sets.
  • The grid view would support features like activating, selecting (including box select, walk select, etc.), drag & drop controllers, custom context menus, filtering, sorting, ...
  • Use and improve performance of custom previews/icons
    The File Browser can be ported to the new view based design as well, some initial work is done for that already.

Work on this is ongoing in the asset-browser-grid-view branch.


  • New Asset Browser space type
  • Basic grid view
  • Support reading and writing the editor
  • Support active item
  • Selection
    • Select all
    • Mouse (incl ctrl)
    • Mouse range select (shift)
    • Walk select
    • Box select
  • Add metadata sidebar
  • Asset import method toggle
  • Fix too bright mouse hover highlight
  • Add Editor pulldown menus back
  • Show fallback previews/icons for assets without preview
  • Asset dragging
  • Add filtering
  • Useful operators (period to jump to active, etc.)
  • Context menu
  • Catalog filtering per asset list user (per asset browser/view)
  • Preview size toggle
  • Update industry compatible keymap
  • Performance:
    • Preview icon loading from OS thumbnail cache (731c1be92a, D14144)
    • Initial preview icon loading (not yet in OS cache)
    • Prioritize icons that are currently in view, or don't generate icons that are not in view anymore (e.g. when just scrolling over assets)
    • Avoid O(n^2) comparisons of grid-view items in AbstractGridView::update_from_old() (9ae2259db5)
  • Polish:
    • Scrollbars (hide horizontal one for grid view)
    • Reduce drawing size of view-item tiles (leave more space between them)

Nice-to-have:

  • Improved preview lazy-loading (UI level) -- (done I think? 16ab6111f7)
  • Show loading icon for previews while loading

Bugs:

  • UI doesn't redraw/refresh(?) while loading library (878477f250)
  • Some previews don't load sometimes
  • Disabled hints missing in tooltips (catalog tree view, "All" library).

Addresses the following:

  • #89783 (Files don't appear in File Browser while Asset Browser loads assets)
  • #93726 (Fix preview flickering when using "Adjust Last Operation")
  • Blender becoming unresponsive (pretty much unusable) when loading big asset library (~3000 assets)
  • Blender becoming unresponsive for seconds when changing catalogs of a big asset library.
Having the Asset Browser be a sub-editor of the File Browser turned out to cause a whole number of issues. These are not easy to fix in the existing code, which is hard to work with additionally. The Asset Browser shouldn't be based on the File Browser's file-list design, but on the asset system. In context, this works towards this architecture: ![Architecture Design - Planned Design (WIP).jpg](https://archive.blender.org/developer/F13123121/Architecture_Design_-_Planned_Design__WIP_.jpg) Essentially, this task covers the following: - Split the Asset and File Browser into separate editors - Introduce a new grid view system (similar to the new [tree-views ](https://wiki.blender.org/wiki/Source/Interface/Views/Tree_Views)) providing general UI functionality and optimized display of big data-sets. - The grid view would support features like activating, selecting (including box select, walk select, etc.), drag & drop controllers, custom context menus, filtering, sorting, ... - Use and improve performance of custom previews/icons The File Browser can be ported to the new [view ](https://wiki.blender.org/wiki/Source/Interface/Views) based design as well, some initial work is done for that already. Work on this is ongoing in the `asset-browser-grid-view` branch. ---- - [x] New Asset Browser space type - [x] Basic grid view - [x] Support reading and writing the editor - [x] Support active item - [ ] Selection - [x] Select all - [x] Mouse (incl ctrl) - [ ] Mouse range select (shift) - [ ] Walk select - [ ] Box select - [x] Add metadata sidebar - [ ] Asset import method toggle - [x] Fix too bright mouse hover highlight - [x] Add Editor pulldown menus back - [ ] Show fallback previews/icons for assets without preview - [ ] Asset dragging - [ ] Add filtering - [ ] Useful operators (period to jump to active, etc.) - [ ] Context menu - [ ] Catalog filtering per asset list user (per asset browser/view) - [ ] Preview size toggle - [ ] Update industry compatible keymap - Performance: - [x] Preview icon loading from OS thumbnail cache (731c1be92a, [D14144](https://archive.blender.org/developer/D14144)) - [ ] Initial preview icon loading (not yet in OS cache) - [ ] Prioritize icons that are currently in view, or don't generate icons that are not in view anymore (e.g. when just scrolling over assets) - [x] Avoid O(n^2) comparisons of grid-view items in `AbstractGridView::update_from_old()` (9ae2259db5) - [ ] Polish: - [x] Scrollbars (hide horizontal one for grid view) - [ ] Reduce drawing size of view-item tiles (leave more space between them) Nice-to-have: - [x] Improved preview lazy-loading (UI level) -- (done I think? 16ab6111f75) - [ ] Show loading icon for previews while loading Bugs: - [x] UI doesn't redraw/refresh(?) while loading library (878477f250) - [ ] Some previews don't load sometimes - [ ] Disabled hints missing in tooltips (catalog tree view, "All" library). ---- Addresses the following: - #89783 (Files don't appear in File Browser while Asset Browser loads assets) - #93726 (Fix preview flickering when using "Adjust Last Operation") - Blender becoming unresponsive (pretty much unusable) when loading big asset library (~3000 assets) - Blender becoming unresponsive for seconds when changing catalogs of a big asset library.
Julian Eisel self-assigned this 2022-02-09 17:57:26 +01:00
Author
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

@JulianEisel : I assume all newly created TODOs from your side are confirmed?

@JulianEisel : I assume all newly created TODOs from your side are confirmed?
Author
Member

We currently don't really use the "Confirmed" status for development task organization in the assets project. So for TODO or design tasks it doesn't matter much, at least to me.

We currently don't really use the "Confirmed" status for development task organization in the assets project. So for TODO or design tasks it doesn't matter much, at least to me.
Julian Eisel changed title from Split Asset and File Browser, implement Grid View to Split Asset and File Browser frontend, implement Grid View 2022-12-12 21:52:57 +01:00
Julian Eisel added
Interest
Asset System
and removed
Legacy
Asset Browser Project
labels 2024-05-31 15:34:45 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#95653
No description provided.