Panning Broken in the Image Editor (Image Editor: Incorrect Image Offsets) #96543

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-16 23:08, hash: ea0c86e961
Caused by 33409f9f1c

Short description of error
The image offsets are incorrectly calculated for the image editor.
This is the cause of a few problems.
Most notably, panning is broken in the image editor.

Steps to Reproduce
Just add any image in UV/Image editor and try to pan it
2022-03-17_11-51-39.mp4

Added subscriber: @Ethan-Hall

#96607 was marked as duplicate of this issue

#96597 was marked as duplicate of this issue

#96592 was marked as duplicate of this issue

#96578 was marked as duplicate of this issue

#96570 was marked as duplicate of this issue

#96554 was marked as duplicate of this issue

#96549 was marked as duplicate of this issue

Added subscriber: @PratikPB2123

Changed status from 'Needs Triage' to: 'Confirmed'

Hi, thanks for the report.
Is broken, yes. Will check if that commit is actually responsible for this issue to happen. (Zoom operation is also affected)

https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/image/image_space_image.hh$166-167

Removing the the offset_x and offset_y from these two lines seems to fix it.
I am not sure about what changing this breaks though.

Added subscriber: @Jeroen-Bakker

After removing these offsets, the compositor and image editor both seemed to work like normal.

Since I do not know why these offsets were calculated or what they were intended for, @Jeroen-Bakker should take a look at it.

Added subscriber: @zazizizou

Yes, that commit is responsible.
Also poking @zazizizou

Also, note that there is an indention error in that same block of code.
And a space in sima ->zoom

Added subscriber: @IliaKovalev

Added subscriber: @dfelinto

Confirmed here as well.

Added subscriber: @SteffenD

Added subscriber: @marianobasti

Added subscriber: @Nurb2Kea

Added subscriber: @Shady.Hamza

Added subscribers: @user1, @bent

Added subscribers: @kursadk, @LloydAlmeida

Centering the images with the home key is also broken, I am guessing they are related.

This issue was referenced by 7fed213ba4

Changed status from 'Confirmed' to: 'Resolved'

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Panning Broken in the Image Editor (Image Editor: Incorrect Image Offsets) #96543