Panning Broken in the Image Editor (Image Editor: Incorrect Image Offsets) #96543

Closed
opened 2022-03-17 05:56:33 +01:00 by Ethan-Hall · 29 comments

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-16 23:08, hash: ea0c86e961
Caused by 33409f9f1c

Short description of error
The image offsets are incorrectly calculated for the image editor.
This is the cause of a few problems.
Most notably, panning is broken in the image editor.

Steps to Reproduce
Just add any image in UV/Image editor and try to pan it
2022-03-17_11-51-39.mp4

**Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-16 23:08, hash: `ea0c86e961` Caused by 33409f9f1c **Short description of error** The image offsets are incorrectly calculated for the image editor. This is the cause of a few problems. Most notably, panning is broken in the image editor. **Steps to Reproduce** Just add any image in UV/Image editor and try to pan it [2022-03-17_11-51-39.mp4](https://archive.blender.org/developer/F12931262/2022-03-17_11-51-39.mp4)
Author

Added subscriber: @Ethan-Hall

Added subscriber: @Ethan-Hall

#96607 was marked as duplicate of this issue

#96607 was marked as duplicate of this issue

#96597 was marked as duplicate of this issue

#96597 was marked as duplicate of this issue

#96592 was marked as duplicate of this issue

#96592 was marked as duplicate of this issue

#96578 was marked as duplicate of this issue

#96578 was marked as duplicate of this issue

#96570 was marked as duplicate of this issue

#96570 was marked as duplicate of this issue

#96554 was marked as duplicate of this issue

#96554 was marked as duplicate of this issue

#96549 was marked as duplicate of this issue

#96549 was marked as duplicate of this issue
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Hi, thanks for the report.
Is broken, yes. Will check if that commit is actually responsible for this issue to happen. (Zoom operation is also affected)

Hi, thanks for the report. Is broken, yes. Will check if that commit is actually responsible for this issue to happen. (Zoom operation is also affected)
Author

https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/image/image_space_image.hh$166-167

Removing the the offset_x and offset_y from these two lines seems to fix it.
I am not sure about what changing this breaks though.

https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/image/image_space_image.hh$166-167 Removing the the offset_x and offset_y from these two lines seems to fix it. I am not sure about what changing this breaks though.
Author

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker
Author

After removing these offsets, the compositor and image editor both seemed to work like normal.

Since I do not know why these offsets were calculated or what they were intended for, @Jeroen-Bakker should take a look at it.

After removing these offsets, the compositor and image editor both seemed to work like normal. Since I do not know why these offsets were calculated or what they were intended for, @Jeroen-Bakker should take a look at it.
Member

Added subscriber: @zazizizou

Added subscriber: @zazizizou
Member

Yes, that commit is responsible.
Also poking @zazizizou

Yes, that commit is responsible. Also poking @zazizizou
Author

Also, note that there is an indention error in that same block of code.
And a space in sima ->zoom

Also, note that there is an indention error in that same block of code. And a space in `sima ->zoom`
Habib Gahbiche was assigned by Pratik Borhade 2022-03-17 09:58:42 +01:00
Member

Added subscriber: @IliaKovalev

Added subscriber: @IliaKovalev

Added subscriber: @dfelinto

Added subscriber: @dfelinto

Confirmed here as well.

Confirmed here as well.
Member

Added subscriber: @SteffenD

Added subscriber: @SteffenD

Added subscriber: @marianobasti

Added subscriber: @marianobasti

Added subscriber: @Nurb2Kea

Added subscriber: @Nurb2Kea
Member

Added subscriber: @Shady.Hamza

Added subscriber: @Shady.Hamza

Added subscribers: @user1, @bent

Added subscribers: @user1, @bent

Added subscribers: @kursadk, @LloydAlmeida

Added subscribers: @kursadk, @LloydAlmeida
Member

Centering the images with the home key is also broken, I am guessing they are related.

Centering the images with the home key is also broken, I am guessing they are related.
Ethan-Hall changed title from Panning Broken in the Image Editor to Panning Broken in the Image Editor (Image Editor: Incorrect Image Offsets) 2022-03-19 00:12:32 +01:00

This issue was referenced by 7fed213ba4

This issue was referenced by 7fed213ba40d6f36282b09245ea459b22d4f6c5b

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#96543
No description provided.