Regression: When making a collection real, curves with depth in the collection are instantiated twice #99088

New Issue

thomas pahler · 2022-06-22T12:57:52+02:00

thomas pahler commented

2022-06-22 12:57:52 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.77

Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: e05e1e3691
Broken: 3.0
Worked: 2.93

Caused by b9febb54a4

Short description of error
when making a collection real, curves where geometry/bevel/depth is not zero are created twice.
curves that do not have this property set are only created once.

Exact steps for others to reproduce the error

open the attached file
curves_file.blend
select the collection instance
object -> apply -> make instances real

What should happen

every object of the collection appears once

What happens

the "BezierCurveWithDepth" appears twice in the hierachy

this also is the case, when exporting the instanced collection, without making it real

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.77 **Blender Version** Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: `e05e1e3691` Broken: 3.0 Worked: 2.93 Caused by b9febb54a4 **Short description of error** when making a collection real, curves where geometry/bevel/depth is not zero are created twice. curves that do not have this property set are only created once. **Exact steps for others to reproduce the error** - open the attached file [curves_file.blend](https://archive.blender.org/developer/F13216489/curves_file.blend) - select the collection instance - object -> apply -> make instances real **What should happen** - every object of the collection appears once **What happens** - the "BezierCurveWithDepth" appears twice in the hierachy this also is the case, when exporting the instanced collection, without making it real

thomas pahler commented

2022-06-22 12:57:52 +02:00

Added subscriber: @thomason1005

blender-admin commented

2022-06-22 12:57:52 +02:00

#101629 was marked as duplicate of this issue

Omar Emara commented

2022-06-22 14:06:07 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Omar Emara changed title from ~~when making a collection real, curves appear duplicated~~ to When making a collection real, curves with depth in the collection are instantiated twice

2022-06-22 14:06:52 +02:00

Philipp Oeser changed title from ~~When making a collection real, curves with depth in the collection are instantiated twice~~ to Regression: When making a collection real, curves with depth in the collection are instantiated twice

2022-06-22 22:39:52 +02:00

Philipp Oeser commented

2022-06-22 23:13:05 +02:00

Added subscribers: @HooglyBoogly, @lichtwerk

Philipp Oeser commented

2022-06-22 23:13:05 +02:00

Caused by b9febb54a4

I know some of the consequences of that commit have been "accepted" as Known Issues, I am not sure this issue reported here should (or could not be prevented) @HooglyBoogly ?
Will set to High prio since it is a regression until further notice by the module.

Caused by b9febb54a4 I know some of the consequences of that commit have been "accepted" as Known Issues, I am not sure this issue reported here should (or could not be prevented) @HooglyBoogly ? Will set to High prio since it is a regression until further notice by the module.

Thomas Dinges commented

2022-06-28 16:07:09 +02:00

Added subscriber: @ThomasDinges

Thomas Dinges commented

2022-06-28 16:07:09 +02:00

Blender 3.2.1 is scheduled for release soon. Any chance to fix this still? @HooglyBoogly

Hans Goudey commented

2022-06-28 16:49:40 +02:00

I'm not sure I see a clear way to fix this at the moment, nothing I'd think of safe enough for 3.2.

Hans Goudey commented

2022-09-06 06:41:18 +02:00

I think there are two ways to solve this:

Add some flag to instances so we can tell when they correspond to a geometry component that doesn't match the original object type (the instances used for the geometry component system), and skip those instances here.
Don't use the object "dupli list" for this feature. Instead look into the InstancesComponent of the evaluated geometry set.

Personally I prefer the second approach. The first is working around the problem and ending up with something more complicated and fragile, the second seems like a real step forwards in the features we want to support in this area (realizing geometry instances to objects, etc).
The problem with that approach is that the instances from the "Instances" panel aren't included in the InstancesComponent. However, we've talked about versioning away that panel for a while. Maybe now is the time to look into that...

EDIT: The task for that last part: #105321

I think there are two ways to solve this: 1. Add some flag to instances so we can tell when they correspond to a geometry component that doesn't match the original object type (the instances used for the geometry component system), and skip those instances here. 2. Don't use the object "dupli list" for this feature. Instead look into the `InstancesComponent` of the evaluated geometry set. Personally I prefer the second approach. The first is working around the problem and ending up with something more complicated and fragile, the second seems like a real step forwards in the features we want to support in this area (realizing geometry instances to objects, etc). The problem with that approach is that the instances from the "Instances" panel aren't included in the `InstancesComponent`. However, we've talked about versioning away that panel for a while. Maybe now is the time to look into that... EDIT: The task for that last part: #105321

Philipp Oeser commented

2022-10-06 13:38:15 +02:00

Added subscribers: @The5, @mano-wii

👍 1

Hans Goudey commented

2022-11-11 01:41:21 +01:00

For this bug, since it can be worked around relatively easily, I think I will wait to implement the fix with the second option I mentioned. In the meantime I'll make this a known issue, because I don't know exactly when we'll be able to do that.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: When making a collection real, curves with depth in the collection are instantiated twice #99088