MSVC: lower C4100 warning level from 4 to 3 #104409

Germano Cavalcante · 2023-02-07T17:52:32+01:00

2023-02-07 17:52:32 +01:00

With the C4100 warning, we better align with OSX/Linux warnings.

Although __pragma(warning(suppress:4100)) is not the same as __attribute__((__unused__)) in gcc (which only affects the attribute instead of the line), it still seems to be better to use it than to hide the warning entirely.

So, after lowering the warning level, adding this pragma to the existing UNUSED definitions suppressed most of the warnings.

In some projects, such as those in extern, this warning is suppressed via the cmake macros remove_strict_flags() and remove_extra_strict_flags(). So to handle those in MSVC too, it was enough to add remove_cc_flag(/w34100) to these macros.

Other cases the warning was specially suppressed for "GNUC" and "Clang" but missing for "MSVC". In these cases the corresponding MSVC pragma has been added.

Lastly, two projects had to be handled differently in MSVC because the warning appears in the windows libraries. These projects are Alembic and USD.

(Note that some C++ files used only for windows have been edited to silence the warning).

With the C4100 warning, we better align with OSX/Linux warnings. --- Although `__pragma(warning(suppress:4100))` is not the same as `__attribute__((__unused__))` in gcc (which only affects the attribute instead of the line), it still seems to be better to use it than to hide the warning entirely. So, after lowering the warning level, adding this `pragma` to the existing `UNUSED` definitions suppressed most of the warnings. In some projects, such as those in extern, this warning is suppressed via the cmake macros `remove_strict_flags()` and `remove_extra_strict_flags()`. So to handle those in MSVC too, it was enough to add `remove_cc_flag(/w34100)` to these macros. Other cases the warning was specially suppressed for "GNUC" and "Clang" but missing for "MSVC". In these cases the corresponding MSVC pragma has been added. Lastly, two projects had to be handled differently in MSVC because the warning appears in the windows libraries. These projects are `Alembic` and `USD`. (Note that some C++ files used only for windows have been edited to silence the warning).

Germano Cavalcante added this to the 3.5 milestone 2023-02-07 17:52:32 +01:00

Germano Cavalcante added the

Platform

Windows

label 2023-02-07 17:52:32 +01:00

Germano Cavalcante self-assigned this 2023-02-07 17:52:32 +01:00

Germano Cavalcante added 1 commit 2023-02-07 17:52:34 +01:00

94398c1304 MSVC: lower C4100 warning level from 4 to 3

This better aligns with OSX/Linux warnings.

---
Although `__pragma(warning(suppress:4100))` is not the same as `__attribute__((__unused__))` in gcc (which only affects the attribute instead of the line), it still seems to be better to use it than to hide the warning entirely.

So, after lowering the warning level, adding this `pragma` to the existing `UNUSED` definitions suppressed most of the warnings.

In some projects, such as those in extern, this warning is suppressed via the cmake macros `remove_strict_flags()` and `remove_extra_strict_flags()`. So to handle those in MSVC too, it was enough to add `remove_cc_flag(/w34100)` to these macros.

Other cases the warning was specially suppressed for "GNUC" and "Clang" but missing for "MSVC". In these cases the corresponding MSVC pragma has been added.

Lastly, two projects had to be handled differently in MSVC because the warning appears in the windows libraries. These projects are `Alembic` and `USD`.

(Note that some C++ files used only for windows have been edited to silence the warning).

Germano Cavalcante requested review from Ray molenkamp 2023-02-07 17:54:02 +01:00

Germano Cavalcante commented

2023-02-07 20:03:56 +01:00

The formal parameters that appear only for MSVC due to the USD and Alembic projects are:

bf_usd

formal parameter	source	include
`dummy`	`.\source\blender\io\usd\intern\usd_reader_mesh.cc`	`.\lib\win64_vc15\usd\include\pxr\base\tf\weakPtrFacade.h`
`tp`, `tp`	`.\source\blender\io\usd\intern\usd_capi_export.cc`	`.\lib\win64_vc15\usd\include\pxr\base\vt\value.h`
`tp`, `tp`	`.\source\blender\io\usd\intern\usd_writer_abstract.cc`	`.\lib\win64_vc15\usd\include\pxr\base\vt\value.h`
`tp`, `tp`	`.\source\blender\io\usd\intern\usd_writer_material.cc`	`.\lib\win64_vc15\usd\include\pxr\base\vt\value.h`
`tp`, `tp`	`.\source\blender\io\usd\intern\usd_writer_camera.cc`	`.\lib\win64_vc15\usd\include\pxr\base\vt\value.h`
`tp`, `tp`	`.\source\blender\io\usd\intern\usd_reader_camera.cc`	`.\lib\win64_vc15\usd\include\pxr\base\vt\value.h`
`tp`, `tp`	`.\source\blender\io\usd\intern\usd_writer_hair.cc`	`.\lib\win64_vc15\usd\include\pxr\base\vt\value.h`
`tp`, `tp`	`.\source\blender\io\usd\intern\usd_writer_mesh.cc`	`.\lib\win64_vc15\usd\include\pxr\base\vt\value.h`
`tp`, `tp`	`.\source\blender\io\usd\intern\usd_reader_material.cc`	`.\lib\win64_vc15\usd\include\pxr\base\vt\value.h`

bf_alembic

formal parameter	source	include
`iFlag`	`.\source\blender\io\alembic\intern\abc_reader_camera.cc`	`.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h`
`iFlag`	`.\source\blender\io\alembic\intern\abc_reader_transform.cc`	`.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h`
`iFlag`	`.\source\blender\io\alembic\intern\abc_reader_nurbs.cc`	`.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h`
`iFlag`	`.\source\blender\io\alembic\intern\abc_reader_curves.cc`	`.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h`
`iFlag`	`.\source\blender\io\alembic\intern\abc_reader_object.cc`	`.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h`
`iFlag`	`.\source\blender\io\alembic\intern\abc_reader_points.cc`	`.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h`
`iFlag`	`.\source\blender\io\alembic\intern\abc_reader_mesh.cc`	`.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h`

The graph of includes for these projects is quite complex.
The includes are inside others that are inside others that always end in:

...\lib\win64_vc15\usd\include\pxr\base\tf\weakPtrFacade.h
...\lib\win64_vc15\usd\include\pxr\base\vt\value.h
...\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h

The formal parameters that appear only for MSVC due to the `USD` and `Alembic` projects are: ## bf_usd | formal parameter | source | include | | -------- | -------- | -------- | | `dummy` | `.\source\blender\io\usd\intern\usd_reader_mesh.cc` | `.\lib\win64_vc15\usd\include\pxr\base\tf\weakPtrFacade.h` | | `tp`, `tp` | `.\source\blender\io\usd\intern\usd_capi_export.cc` | `.\lib\win64_vc15\usd\include\pxr\base\vt\value.h` | | `tp`, `tp` | `.\source\blender\io\usd\intern\usd_writer_abstract.cc` | `.\lib\win64_vc15\usd\include\pxr\base\vt\value.h` | | `tp`, `tp` | `.\source\blender\io\usd\intern\usd_writer_material.cc` | `.\lib\win64_vc15\usd\include\pxr\base\vt\value.h` | | `tp`, `tp` | `.\source\blender\io\usd\intern\usd_writer_camera.cc` | `.\lib\win64_vc15\usd\include\pxr\base\vt\value.h` | | `tp`, `tp` | `.\source\blender\io\usd\intern\usd_reader_camera.cc` | `.\lib\win64_vc15\usd\include\pxr\base\vt\value.h` | | `tp`, `tp` | `.\source\blender\io\usd\intern\usd_writer_hair.cc` | `.\lib\win64_vc15\usd\include\pxr\base\vt\value.h` | | `tp`, `tp` | `.\source\blender\io\usd\intern\usd_writer_mesh.cc` | `.\lib\win64_vc15\usd\include\pxr\base\vt\value.h` | | `tp`, `tp` | `.\source\blender\io\usd\intern\usd_reader_material.cc` | `.\lib\win64_vc15\usd\include\pxr\base\vt\value.h` | ## bf_alembic | formal parameter | source | include | | -------- | -------- | -------- | | `iFlag` | `.\source\blender\io\alembic\intern\abc_reader_camera.cc` | `.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h` | | `iFlag` | `.\source\blender\io\alembic\intern\abc_reader_transform.cc` | `.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h` | | `iFlag` | `.\source\blender\io\alembic\intern\abc_reader_nurbs.cc` | `.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h` | | `iFlag` | `.\source\blender\io\alembic\intern\abc_reader_curves.cc` | `.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h` | | `iFlag` | `.\source\blender\io\alembic\intern\abc_reader_object.cc` | `.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h` | | `iFlag` | `.\source\blender\io\alembic\intern\abc_reader_points.cc` | `.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h` | | `iFlag` | `.\source\blender\io\alembic\intern\abc_reader_mesh.cc` | `.\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h` | The graph of includes for these projects is quite complex. The includes are inside others that are inside others that always end in: - `...\lib\win64_vc15\usd\include\pxr\base\tf\weakPtrFacade.h` - `...\lib\win64_vc15\usd\include\pxr\base\vt\value.h` - `...\lib\win64_vc15\alembic\include\Alembic\Abc\ISchemaObject.h`

Germano Cavalcante closed this pull request

2023-02-07 23:11:35 +01:00

Ray molenkamp commented

2023-02-14 16:03:08 +01:00

I fixed the warns coming out of the lib folder in 4cc94679dd if you merge main, you should be able to get rid of the changes needed for alembic and USD

I fixed the warns coming out of the lib folder in 4cc94679ddb0d538493ead9e360ca38da0d58b3c if you merge main, you should be able to get rid of the changes needed for alembic and USD

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

MSVC: lower C4100 warning level from 4 to 3 #104409

bf_usd

bf_alembic

Pull request closed