Nodes: Avoid updating topology cache when changing properties #104431

Closed
Hans Goudey wants to merge 1 commits from HooglyBoogly:node-update-property-avoid-topology-cache into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Changing a property on a node or socket doesn't change the topology
of the node tree directly, so when only those tags are present, we don't
have to tag the topology cache dirty and update it.

This can save a few milliseconds per update when editing a large node tree.
Note that the topology cache still has to be recreated for the CoW node tree
though, so this doesn't resolve all of the unnecessary calculation.

Changing a property on a node or socket doesn't change the topology of the node tree directly, so when only those tags are present, we don't have to tag the topology cache dirty and update it. This can save a few milliseconds per update when editing a large node tree. Note that the topology cache still has to be recreated for the CoW node tree though, so this doesn't resolve all of the unnecessary calculation.
Hans Goudey added 1 commit 2023-02-07 20:08:13 +01:00
cea6dd9a07 Nodes: Avoid updating topology cache when changing properties
Changing a property on a node or socket doesn't change the topology
of the node tree directly, so when only those tags are present, we don't
have to tag the topology cache dirty and update it.

This can save a few milliseconds per update when editing a large node tree.
Note that the topology cache still has to be recreated for the CoW node tree
though, so this doesn't resolve all of the unnecessary calculation.
Hans Goudey requested review from Jacques Lucke 2023-02-07 20:08:23 +01:00
Jacques Lucke requested changes 2023-02-10 20:24:27 +01:00
@ -51,0 +54,4 @@
static bool flag_affects_topology_cache(const eNodeTreeChangedFlag flag)
{
const uint32_t allowed_flags = NTREE_CHANGED_NODE_PROPERTY | NTREE_CHANGED_SOCKET_PROPERTY;
Member

Something is wrong here, there is no return value?

Something is wrong here, there is no return value?
@ -1122,3 +1139,3 @@
void BKE_ntree_update_tag_socket_availability(bNodeTree *ntree, bNodeSocket *socket)
{
add_socket_tag(ntree, socket, NTREE_CHANGED_SOCKET_PROPERTY);
add_socket_tag(ntree, socket, NTREE_CHANGED_ADDED_SOCKET);
Member

This tag is wrong. Changing socket availability does not add/remove sockets. And if you say that making a socket available is adding the socket, then making it unavailable would also delete it.

This tag is wrong. Changing socket availability does not add/remove sockets. And if you say that making a socket available is adding the socket, then making it unavailable would also delete it.
Brecht Van Lommel added this to the Nodes & Physics project 2023-02-13 09:20:14 +01:00
Hans Goudey closed this pull request 2024-01-11 21:39:27 +01:00
Hans Goudey deleted branch node-update-property-avoid-topology-cache 2024-01-11 21:39:51 +01:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104431
No description provided.