Cycles: Replace resolution divider loop with an analytical formula #104450

Merged
Sergey Sharybin merged 2 commits from Alaska/blender:replace-divider-loop-with-formula into main 2023-02-13 13:02:56 +01:00
Member

As a side effect of this change, more resolution divisions are now available.
Before this patch the possible resolution divisions were all powers of two.
Now the possible resolution divisions are the multiples of pixel_size.

This increase in possible resolution divisions is the same idea proposed in https://ro.developer.blender.org/D13590.
In that patch there were concerns that this will increase the time between a user navigating
and seeing the 1:1 render. To my knowledge this is a non-issue and there should be
little to no increase in time between those two events.

As a side effect of this change, more resolution divisions are now available. Before this patch the possible resolution divisions were all powers of two. Now the possible resolution divisions are the multiples of pixel_size. This increase in possible resolution divisions is the same idea proposed in https://ro.developer.blender.org/D13590. In that patch there were concerns that this will increase the time between a user navigating and seeing the 1:1 render. To my knowledge this is a non-issue and there should be little to no increase in time between those two events.
Alaska added 1 commit 2023-02-08 03:36:41 +01:00
buildbot/vexp-code-patch-coordinator Build done. Details
bd7e460aae
Replace resolution divider loop with a formula
Alaska requested review from Brecht Van Lommel 2023-02-08 03:37:07 +01:00

@blender-bot build

@blender-bot build
Brecht Van Lommel added this to the Render & Cycles project 2023-02-08 03:45:33 +01:00
Alaska changed title from Replace resolution divider loop with an analytical formula to Cycles: Replace resolution divider loop with an analytical formula 2023-02-08 03:47:45 +01:00
Alaska requested review from Sergey Sharybin 2023-02-09 01:35:59 +01:00
Author
Member

Sorry for adding Sergey late. I couldn't add two reviewers at once earlier.

Sorry for adding Sergey late. I couldn't add two reviewers at once earlier.
Alaska added 1 commit 2023-02-09 09:08:59 +01:00

Unfortunately, I can not verify the code now because the build is currently broken (unrelated to this change).

I've tested the version of the patch from Phabricator and it worked fine. I didn't see a much difference on my machine, but it does sound very appealing that we can now have lower dividers!

Unfortunately, I can not verify the code now because the build is currently broken (unrelated to this change). I've tested the version of the patch from Phabricator and it worked fine. I didn't see a much difference on my machine, but it does sound very appealing that we can now have lower dividers!
Sergey Sharybin requested changes 2023-02-13 11:57:06 +01:00
Sergey Sharybin left a comment
Owner

Can you please rebase your patch on top of the main branch instead of merging he branch? This will align with the way how we work with the linear history of the main branch for the new features.

Also the commit message needs to be expanded. The one from the Phabricator was more describptive.
Basically, keep it so that the commit message is sufficient to understand what's going on, without need to go to the code review section to get details.

Can you please rebase your patch on top of the main branch instead of merging he branch? This will align with the way how we work with the linear history of the main branch for the new features. Also the commit message needs to be expanded. The one from the Phabricator was more describptive. Basically, keep it so that the commit message is sufficient to understand what's going on, without need to go to the code review section to get details.

Actually merging is fine, when using either squash commit or rebase and fast forward any merge commits will be eliminated.

Merging and adding new commits has some benefits as it allows seeing what changed between updates.

Actually merging is fine, when using either squash commit or rebase and fast forward any merge commits will be eliminated. Merging and adding new commits has some benefits as it allows seeing what changed between updates.

@Alaska Never mind then. Seems that we can take of the message and merge commit from the UI now.

Lemme test the patch again, and if there will be no issues we'll just merge the change :)

@Alaska Never mind then. Seems that we can take of the message and merge commit from the UI now. Lemme test the patch again, and if there will be no issues we'll just merge the change :)
Sergey Sharybin approved these changes 2023-02-13 12:39:42 +01:00
Sergey Sharybin left a comment
Owner

Tested it and it still works fine!

Tested it and it still works fine!
Sergey Sharybin merged commit 9fecf1f8b8 into main 2023-02-13 13:02:56 +01:00
Sergey Sharybin deleted branch replace-divider-loop-with-formula 2023-02-13 13:02:56 +01:00
Brecht Van Lommel added the
Module
Render & Cycles
label 2023-02-17 14:17:15 +01:00
Brecht Van Lommel removed this from the Render & Cycles project 2023-02-17 14:17:19 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104450
No description provided.