WIP: USD: add velocity to USD importer #104462

Draft
Sonny Campbell wants to merge 3 commits from SonnyCampbell_Unity/blender:unity/T96182-usd-reader-velocity into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Depends on #104459

Velocity is already handled in the usd exporter implementation, and for the alembic importer/exporter. I copied the existing alembic importer implementation.

This was raised because a user noticed that motion blur was not working for a fluid sim when imported with USD.

Original reviews and comments are here:
https://archive.blender.org/developer/D15430

Fixes #96182

Depends on https://projects.blender.org/blender/blender/pulls/104459 Velocity is already handled in the usd exporter implementation, and for the alembic importer/exporter. I copied the existing alembic importer implementation. This was raised because a user noticed that motion blur was not working for a fluid sim when imported with USD. Original reviews and comments are here: https://archive.blender.org/developer/D15430 Fixes #96182
Sonny Campbell added 3 commits 2023-02-08 13:02:48 +01:00
This is a small initial refactor to extract the `USDGeomReader.read_mesh` parameters into a separate struct. This will allow for adding extra paramters to handle importing velocities for T91369
Velocity already handled in the usd exporter implementation, and for the alembic importer/exporter. I copied the existing alembic importer implementation.

This was raised because a user noticed that motion blur was not working for a fluid sim when imported with USD.
Sonny Campbell requested review from Sybren A. Stüvel 2023-02-08 13:02:58 +01:00
Hans Goudey added this to the Pipeline, Assets & IO project 2023-02-08 14:35:36 +01:00
Brecht Van Lommel changed title from T96182: Add velocity to usd importer to USD: add velocity to USD importer 2023-02-09 12:46:52 +01:00
Bastien Montagne added the
Interest
USD
label 2023-02-10 12:25:55 +01:00
Bastien Montagne modified the project from Pipeline, Assets & IO to USD 2023-02-10 12:26:05 +01:00
Sybren A. Stüvel changed title from USD: add velocity to USD importer to WIP: USD: add velocity to USD importer 2023-02-10 12:38:02 +01:00

I marked this PR as 'WIP' as it contains the commits of #104459 as well, making it hard to review.

I marked this PR as 'WIP' as it contains the commits of #104459 as well, making it hard to review.

I'll hand over the review to @makowalski , as I'm no longer directly involved with USD development.

@SonnyCampbell_Unity if you want to get this reviewed, please remove the 'WIP:' prefix -- that's an indicator that says "this is not ready for review yet".

I'll hand over the review to @makowalski , as I'm no longer directly involved with USD development. @SonnyCampbell_Unity if you want to get this reviewed, please remove the 'WIP:' prefix -- that's an indicator that says "this is not ready for review yet".
Sybren A. Stüvel requested review from Michael Kowalski 2023-09-26 11:34:00 +02:00
Sybren A. Stüvel refused to review 2023-09-26 11:34:03 +02:00
This pull request has changes conflicting with the target branch.
  • source/blender/io/usd/intern/usd_capi_import.cc
  • source/blender/io/usd/intern/usd_reader_curve.cc
  • source/blender/io/usd/intern/usd_reader_curve.h
  • source/blender/io/usd/intern/usd_reader_geom.h
  • source/blender/io/usd/intern/usd_reader_mesh.cc
  • source/blender/io/usd/intern/usd_reader_mesh.h
  • source/blender/io/usd/intern/usd_reader_nurbs.cc
  • source/blender/io/usd/intern/usd_reader_nurbs.h
  • source/blender/io/usd/intern/usd_reader_prim.h
  • source/blender/io/usd/usd.h

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u unity/T96182-usd-reader-velocity:SonnyCampbell_Unity-unity/T96182-usd-reader-velocity
git checkout SonnyCampbell_Unity-unity/T96182-usd-reader-velocity
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104462
No description provided.