From 40d12296cb6b0325c027ac9803fd33625d5a6fa8 Mon Sep 17 00:00:00 2001
From: Damien Picard <dam.pic@free.fr>
Date: Wed, 12 Oct 2022 22:59:54 +0200
Subject: [PATCH] I18n: write messages of the vertex group lock operator
 explicitly

The operator's description used a format string like:

```
BLI_sprintfN(TIP_("%s %s vertex groups of the active object"),
             action_str, target_str)
```

which is almost guaranteed to be impossible to properly localize to
some languages -- I know there are a couple of issues for French
already.

So instead of hoping formatting works, write all possible strings
explicitly, even if it looks stupidly verbose.
---
 .../blender/editors/object/object_vgroup.cc   | 80 ++++++++++---------
 1 file changed, 44 insertions(+), 36 deletions(-)

diff --git a/source/blender/editors/object/object_vgroup.cc b/source/blender/editors/object/object_vgroup.cc
index 987fb545264..23140afc701 100644
--- a/source/blender/editors/object/object_vgroup.cc
+++ b/source/blender/editors/object/object_vgroup.cc
@@ -3446,55 +3446,63 @@ static char *vertex_group_lock_description(bContext * /*C*/,
   int action = RNA_enum_get(params, "action");
   int mask = RNA_enum_get(params, "mask");
 
-  const char *action_str, *target_str;
-
+  /* NOTE: constructing the following string literals can be done in a less verbose way,
+   * however the resulting strings can't be usefully translated, (via `TIP_`). */
   switch (action) {
     case VGROUP_LOCK:
-      action_str = TIP_("Lock");
+      switch (mask) {
+        case VGROUP_MASK_ALL:
+          return BLI_strdup(TIP_("Lock all vertex groups of the active object"));
+        case VGROUP_MASK_SELECTED:
+          return BLI_strdup(TIP_("Lock selected vertex groups of the active object"));
+        case VGROUP_MASK_UNSELECTED:
+          return BLI_strdup(TIP_("Lock unselected vertex groups of the active object"));
+        case VGROUP_MASK_INVERT_UNSELECTED:
+          return BLI_strdup(
+              TIP_("Lock selected and unlock unselected vertex groups of the active object"));
+      }
       break;
     case VGROUP_UNLOCK:
-      action_str = TIP_("Unlock");
+      switch (mask) {
+        case VGROUP_MASK_ALL:
+          return BLI_strdup(TIP_("Unlock all vertex groups of the active object"));
+        case VGROUP_MASK_SELECTED:
+          return BLI_strdup(TIP_("Unlock selected vertex groups of the active object"));
+        case VGROUP_MASK_UNSELECTED:
+          return BLI_strdup(TIP_("Unlock unselected vertex groups of the active object"));
+        case VGROUP_MASK_INVERT_UNSELECTED:
+          return BLI_strdup(
+              TIP_("Unlock selected and lock unselected vertex groups of the active object"));
+      }
       break;
     case VGROUP_TOGGLE:
-      action_str = TIP_("Toggle locks of");
+      switch (mask) {
+        case VGROUP_MASK_ALL:
+          return BLI_strdup(TIP_("Toggle locks of all vertex groups of the active object"));
+        case VGROUP_MASK_SELECTED:
+          return BLI_strdup(TIP_("Toggle locks of selected vertex groups of the active object"));
+        case VGROUP_MASK_UNSELECTED:
+          return BLI_strdup(TIP_("Toggle locks of unselected vertex groups of the active object"));
+        case VGROUP_MASK_INVERT_UNSELECTED:
+          return BLI_strdup(TIP_(
+              "Toggle locks of all and invert unselected vertex groups of the active object"));
+      }
       break;
     case VGROUP_INVERT:
-      action_str = TIP_("Invert locks of");
-      break;
-    default:
-      return nullptr;
-  }
-
-  switch (mask) {
-    case VGROUP_MASK_ALL:
-      target_str = TIP_("all");
-      break;
-    case VGROUP_MASK_SELECTED:
-      target_str = TIP_("selected");
-      break;
-    case VGROUP_MASK_UNSELECTED:
-      target_str = TIP_("unselected");
-      break;
-    case VGROUP_MASK_INVERT_UNSELECTED:
-      switch (action) {
-        case VGROUP_INVERT:
-          target_str = TIP_("selected");
-          break;
-        case VGROUP_LOCK:
-          target_str = TIP_("selected and unlock unselected");
-          break;
-        case VGROUP_UNLOCK:
-          target_str = TIP_("selected and lock unselected");
-          break;
-        default:
-          target_str = TIP_("all and invert unselected");
+      switch (mask) {
+        case VGROUP_MASK_ALL:
+          return BLI_strdup(TIP_("Invert locks of all vertex groups of the active object"));
+        case VGROUP_MASK_SELECTED:
+        case VGROUP_MASK_INVERT_UNSELECTED:
+          return BLI_strdup(TIP_("Invert locks of selected vertex groups of the active object"));
+        case VGROUP_MASK_UNSELECTED:
+          return BLI_strdup(TIP_("Invert locks of unselected vertex groups of the active object"));
       }
       break;
     default:
       return nullptr;
   }
-
-  return BLI_sprintfN(TIP_("%s %s vertex groups of the active object"), action_str, target_str);
+  return nullptr;
 }
 
 void OBJECT_OT_vertex_group_lock(wmOperatorType *ot)
-- 
2.30.2