UI: Make text nomenclature and ordering consistent #104493

Josh Maros · 2023-02-09T01:42:58+01:00

Josh Maros commented

2023-02-09 01:42:58 +01:00

"Center" -> "Middle" when describing vertical alignment.
"Align X" -> "Text Horizontal Align"
"Align Y" -> "Text Vertical Align"
Vertical alignment options rearranged to be consistently top-most to
bottom-most.

Conversation about which strings to use.

Conversation about how to not break everything in the process.

"Center" -> "Middle" when describing vertical alignment. "Align X" -> "Text Horizontal Align" "Align Y" -> "Text Vertical Align" Vertical alignment options rearranged to be consistently top-most to bottom-most. --- [Conversation about which strings to use.](https://devtalk.blender.org/t/should-i-fix-this-inconsistency-in-which-direction-should-i-fix-it/27531/4) [Conversation about how to not break everything in the process.](https://devtalk.blender.org/t/how-to-make-property-enum-names-consistent-without-breaking-everything/27524)

Josh Maros added 1 commit 2023-02-09 01:43:00 +01:00

89690a2b28 Make text nomenclature and ordering consistent

"Center" -> "Middle" when describing vertical alignment.
"Align X" -> "Text Horizontal Align"
"Align Y" -> "Text Vertical Align"
Vertical alignment options rearranged to be consistently top-most to
bottom-most.

Josh Maros changed title from ~~Make text nomenclature and ordering consistent~~ to UI: Make text nomenclature and ordering consistent

2023-02-09 01:43:12 +01:00

Josh Maros changed title from ~~UI: Make text nomenclature and ordering consistent~~ to WIP: UI: Make text nomenclature and ordering consistent

2023-02-09 01:44:44 +01:00

Josh Maros commented

2023-02-09 01:46:57 +01:00

Problem: There is a mismatch between the nomenclature used in text object settings and the corresponding settings in geometry nodes.

Solution: Adjust strings as recommended in the linked thread.

Alternate solutions: None I can think of.

Limitations: None I am aware of, the solution reuses existing strings so no localization has to be rewritten.

Problem: There is a mismatch between the nomenclature used in text object settings and the corresponding settings in geometry nodes. Solution: Adjust strings as recommended in the linked thread. Alternate solutions: None I can think of. Limitations: None I am aware of, the solution reuses existing strings so no localization has to be rewritten.

Josh Maros requested review from Erik Abrahamsson 2023-02-09 01:57:49 +01:00

Josh Maros changed title from ~~WIP: UI: Make text nomenclature and ordering consistent~~ to UI: Make text nomenclature and ordering consistent

2023-02-09 01:57:58 +01:00

Erik Abrahamsson commented

2023-02-09 10:43:27 +01:00

Thanks for the PR.

I think I would prefer "Horizontal Alignment" over "Text Horizontal Align".
We already know this is about text, and "Align" is a verb, right?

@HooglyBoogly what do you think about this change?

Thanks for the PR. I think I would prefer "Horizontal Alignment" over "Text Horizontal Align". We already know this is about text, and "Align" is a verb, right? @HooglyBoogly what do you think about this change?

👍 1

Hans Goudey commented

2023-02-09 14:26:28 +01:00

This would be much easier to review if it included screenshots of the areas changed. That's helpful for most UI changes.

I agree with Erik that Horizontal Alignment would be better.

This would be much easier to review if it included screenshots of the areas changed. That's helpful for most UI changes. I agree with Erik that `Horizontal Alignment` would be better.

👍 1

Josh Maros added 1 commit 2023-02-10 03:56:18 +01:00

542129b474 Remove "Text", replace "Align" -> "Alignment"

Josh Maros commented

2023-02-10 04:12:18 +01:00

Thanks for the feedback, those are good points. Here is what the UI looks like in 3.4.1:

And here is the proposed change:

Thanks for the feedback, those are good points. Here is what the UI looks like in 3.4.1: ![Text object options](/attachments/a21897e7-080e-46b9-802b-8c69ebeb23b5) ![Geometry nodes text to curves options](/attachments/069b1309-5340-4e1e-a193-181f3533aca1) And here is the proposed change: ![New text object options](/attachments/6dd888c0-ffaa-4e2e-91bf-dd5e30b15e96) ![New geometry nodes text to curves options](/attachments/785c0d10-4f3b-410c-8a35-f6c78f67765f)

Screenshot_20230209_191116.png

26 KiB

Screenshot_20230209_185652.png

22 KiB

Screenshot_20230209_185716.png

23 KiB

Screenshot_20230209_191051.png

21 KiB

Josh Maros added 1 commit 2023-02-10 08:47:11 +01:00

a7c290d066 Remove inconsistent hyphen, rephrase tooltips.

Erik Abrahamsson approved these changes 2023-02-10 18:57:01 +01:00

Erik Abrahamsson merged commit 5c4e1ed578 into main