Geometry Nodes: Select by Component node #104602

Open
Iliya Katushenock wants to merge 6 commits from mod_moder/blender:for_component_new into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

The node makes it possible to make different
implementations of field generation groups
for different components. The use cases mostly
boil down to smart group assets that take on
the task of doing different results for the
user without forcing them to think about it themselves.

image

The node makes it possible to make different implementations of field generation groups for different components. The use cases mostly boil down to smart group assets that take on the task of doing different results for the user without forcing them to think about it themselves. ![image](/attachments/f6e6e6b4-516f-4b3f-ade2-485de0880cb7)
Iliya Katushenock added 1 commit 2023-02-11 01:00:06 +01:00
Iliya Katushenock requested review from Jacques Lucke 2023-02-11 01:00:24 +01:00
Iliya Katushenock requested review from Hans Goudey 2023-02-11 01:00:25 +01:00
Hans Goudey reviewed 2023-02-11 01:07:45 +01:00
Hans Goudey left a comment
Member

I want to test this before I accept it, but the code looks good, thanks for working on this.

I want to test this before I accept it, but the code looks good, thanks for working on this.
@ -286,6 +286,7 @@ DefNode(GeometryNode, GEO_NODE_ATTRIBUTE_STATISTIC, def_geo_attribute_statistic,
DefNode(GeometryNode, GEO_NODE_BLUR_ATTRIBUTE, def_geo_blur_attribute, "BLUR_ATTRIBUTE", BlurAttribute, "Blur Attribute", "Mix attribute values of neighboring elements")
DefNode(GeometryNode, GEO_NODE_BOUNDING_BOX, 0, "BOUNDING_BOX", BoundBox, "Bounding Box", "Calculate the limits of a geometry's positions and generate a box mesh with those dimensions")
DefNode(GeometryNode, GEO_NODE_CAPTURE_ATTRIBUTE, def_geo_attribute_capture,"CAPTURE_ATTRIBUTE", CaptureAttribute, "Capture Attribute", "Store the result of a field on a geometry and output the data as a node socket. Allows remembering or interpolating data as the geometry changes, such as positions before deformation")
DefNode(GeometryNode, GEO_NODE_SELECT_BY_COMPONENT, 0, "SELECT_BY_COMPONENT", SelectByComponent, "Select by Component", "")
Member

For the description, how about Find the type of the currently evaluated geometry?

For the description, how about `Find the type of the currently evaluated geometry`?
mod_moder marked this conversation as resolved
@ -0,0 +11,4 @@
static void node_declare(NodeDeclarationBuilder &b)
{
b.add_output<decl::Bool>(N_("Is Mesh")).field_source_reference_all();
b.add_output<decl::Bool>(N_("Is Curve")).field_source_reference_all();
Member

I think Is Curves would be more consistent with the current design for namingfor (still have to update other nodes for that though).

I think `Is Curves` would be more consistent with the current design for namingfor (still have to update other nodes for that though).
mod_moder marked this conversation as resolved
Iliya Katushenock added 1 commit 2023-02-11 01:28:06 +01:00
Brecht Van Lommel added this to the Nodes & Physics project 2023-02-13 09:17:56 +01:00
Hans Goudey added the
Module
Nodes & Physics
Interest
Geometry Nodes
labels 2023-02-16 21:22:57 +01:00
Iliya Katushenock added 1 commit 2023-02-19 21:50:04 +01:00
Author
Member

@JacquesLucke Can we expect that someday it will be able to get the geometry (in the node group) from the context of the field evaluation, and ask for its component type from it, for example?

@JacquesLucke Can we expect that someday it will be able to get the geometry (in the node group) from the context of the field evaluation, and ask for its component type from it, for example?
Iliya Katushenock added 1 commit 2023-03-21 20:01:20 +01:00
Iliya Katushenock added 1 commit 2023-03-21 20:01:47 +01:00
Iliya Katushenock added 1 commit 2023-06-01 00:53:44 +02:00
Iliya Katushenock changed title from Geometry Node: Select by Component node to Geometry Nodes: Select by Component node 2023-06-01 00:53:58 +02:00
This pull request has changes conflicting with the target branch.
  • scripts/startup/bl_ui/node_add_menu_geometry.py
  • source/blender/blenkernel/BKE_node.h
  • source/blender/nodes/NOD_static_types.h
  • source/blender/nodes/geometry/CMakeLists.txt
  • source/blender/nodes/geometry/node_geometry_register.cc
  • source/blender/nodes/geometry/node_geometry_register.hh

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u for_component_new:mod_moder-for_component_new
git checkout mod_moder-for_component_new
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104602
No description provided.