UI: Widen Search Boxes When Necessary #104603

Harley Acheson · 2023-02-11T02:13:14+01:00

Harley Acheson commented

2023-02-11 02:13:14 +01:00

Make floating search boxes wider when there is a linked scene or are
otherwise showing more information than a simple list.

This patch serves a similar purpose to this one by Phil Stopford https://archive.blender.org/developer/D16857

While that patch widened all search boxes, this one only does so when needed - the list has UI_MENU_ITEM_SEPARATOR_SHORTCUT or if any of the items have UI_BUT_HAS_SEP_CHAR. If either these is true then an amount is added to the width of 12 * data->fstyle.points * U.dpi_fac

The use of style.points is an accessibility issue in that it gains extra width than just the UI scale if the user has also increased the text style font points. This is done by some users with vision disabilities. Following shows a complaint about the search box by such a user (last image in comment): #86974 (comment)

Note that these search boxes are initiated in two different ways. One is from a menu item (the block will have UI_BLOCK_SEARCH_MENU), in which case the caller directly specifies the width at the call site. This patch does not change the width they are directly requesting.

The other way these searches are initiated is usually part of a larger UI item. In these cases the caller can not specify the width, it is just automatically the same width. It is for this type that this patch checks the type and content and makes it wider if needed.

This might look like a fair big change, but it is really just adding a layout callback to the region and then moving all the code to do with sizing into it.

Following shows the change in size of two of these search boxes, as animated GIFs showing before and after:

Make floating search boxes wider when there is a linked scene or are otherwise showing more information than a simple list. --- This patch serves a similar purpose to this one by Phil Stopford https://archive.blender.org/developer/D16857 While that patch widened all search boxes, this one only does so when needed - the list has UI_MENU_ITEM_SEPARATOR_SHORTCUT or if any of the items have UI_BUT_HAS_SEP_CHAR. If either these is true then an amount is added to the width of `12 * data->fstyle.points * U.dpi_fac` The use of style.points is an accessibility issue in that it gains extra width than just the UI scale if the user has also increased the text style font points. This is done by some users with vision disabilities. Following shows a complaint about the search box by such a user (last image in comment): https://projects.blender.org/blender/blender/issues/86974#issuecomment-873353 Note that these search boxes are initiated in two different ways. One is from a menu item (the block will have UI_BLOCK_SEARCH_MENU), in which case the caller directly specifies the width at the call site. This patch does not change the width they are directly requesting. The other way these searches are initiated is usually part of a larger UI item. In these cases the caller can not specify the width, it is just automatically the same width. It is for this type that this patch checks the type and content and makes it wider if needed. This might look like a fair big change, but it is really just adding a `layout` callback to the region and then moving all the code to do with sizing into it. Following shows the change in size of two of these search boxes, as animated GIFs showing before and after: ![Search1.gif](/attachments/5f5f6f43-9160-4f79-90c0-b504f6427cc2) ![Search2.gif](/attachments/c7aacc1d-c805-4464-8a56-b88956237033)

Search1.gif

90 KiB

Search2.gif

92 KiB

👍 3 ❤️ 1 🎉 1

Harley Acheson requested review from Julian Eisel 2023-02-11 02:14:14 +01:00

Harley Acheson requested review from Brecht Van Lommel 2023-02-11 02:14:25 +01:00

Brecht Van Lommel added this to the Module: User Interface project 2023-02-13 09:10:08 +01:00

Brecht Van Lommel requested changes 2023-02-17 15:46:04 +01:00

Brecht Van Lommel left a comment

Looks fine overall.

source/blender/editors/interface/interface_region_search.cc

						
				@ -742,0 +711,4 @@

				                                               UI_MENU_ITEM_SEPARATOR_SHORTCUT :

				                                               UI_MENU_ITEM_SEPARATOR_NONE;

				  if (separator_type == UI_MENU_ITEM_SEPARATOR_NONE && !data->preview) {

				    for (int a = 0; a < MIN2(data->items.totitem, 30); a++) {

Brecht Van Lommel commented

2023-02-17 15:45:49 +01:00

I don't think we should limit this to 30. There's no particular reason to expect the user to need to select an item from the first 30 more often than the others.

Harley marked this conversation as resolved

Harley Acheson force-pushed SearchWidth from 1444b4918b to a176ff2d11

2023-02-22 22:25:04 +01:00

Compare

Brecht Van Lommel approved these changes 2023-02-23 17:50:26 +01:00

Harley Acheson added 1 commit 2023-02-23 21:23:47 +01:00

Merge branch 'main' into SearchWidth

buildbot/vexp-code-patch-coordinator Build done.

Details

381e8833c5

Harley Acheson commented

2023-02-23 21:24:58 +01:00