Geometry Node: Edge Rings node #104623

Open
Iliya Katushenock wants to merge 17 commits from mod_moder/blender:edge_rings into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Geometry node analog of edit mode edge rings selections operator.

image

image

Geometry node analog of edit mode edge rings selections operator. ![image](/attachments/4e4c901d-c0a5-4114-ac53-76b2d8a8836d) ![image](/attachments/d0de2a97-ce44-416a-860c-c574f4b57425)
201 KiB
811 KiB
Iliya Katushenock added 1 commit 2023-02-11 17:53:59 +01:00
Iliya Katushenock requested review from Jacques Lucke 2023-02-11 17:54:11 +01:00
Iliya Katushenock requested review from Hans Goudey 2023-02-11 17:54:11 +01:00
Brecht Van Lommel added this to the Nodes & Physics project 2023-02-13 09:09:49 +01:00
Hans Goudey requested changes 2023-02-16 20:42:22 +01:00
Hans Goudey left a comment
Member

I think this is a really nice idea, and I like the possibilities it brings. However, like the last comment on Phabricator mentioned, in order to be a compelling PR, it really should have more use-case oriented examples of how this can be used in real-world procedural modeling tasks. The examples currently in the description make sense, but beyond being interesting, they don't make a strong case for why the node should be included.

I think this is a really nice idea, and I like the possibilities it brings. However, like the last comment on Phabricator mentioned, in order to be a compelling PR, it really should have more use-case oriented examples of how this can be used in real-world procedural modeling tasks. The examples currently in the description make sense, but beyond being interesting, they don't make a strong case for why the node should be included.
Iliya Katushenock added 1 commit 2023-02-19 21:53:31 +01:00
Iliya Katushenock added 1 commit 2023-02-26 11:23:04 +01:00
Iliya Katushenock added 1 commit 2023-05-15 13:59:25 +02:00
Iliya Katushenock added 1 commit 2023-05-15 17:29:51 +02:00
Iliya Katushenock added 2 commits 2023-06-01 00:10:42 +02:00
Iliya Katushenock added the
Interest
Geometry Nodes
label 2023-06-01 00:17:40 +02:00
Iliya Katushenock added 1 commit 2023-08-18 02:41:34 +02:00
Iliya Katushenock added 1 commit 2023-08-18 02:44:03 +02:00
Iliya Katushenock added 2 commits 2023-08-22 02:02:29 +02:00
Iliya Katushenock added 2 commits 2023-08-22 20:46:06 +02:00
progress
Some checks failed
buildbot/vexp-code-patch-coordinator Build done.
e54e504146
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR104623) when ready.
Contributor

A couple of use cases I can think of:

  1. Identifying incorrect topology.
  2. Applying a node tool to a specific edge ring.
  3. (somehow? ) Implementing the 'follow quad' UV algorithm.

image

A couple of use cases I can think of: 1. Identifying incorrect topology. 2. Applying a node tool to a specific edge ring. 3. (somehow? ) Implementing the 'follow quad' UV algorithm. ![image](/attachments/f561840d-d50d-45ec-8c1f-849d39d28f15)
Iliya Katushenock added 1 commit 2023-08-30 21:25:38 +02:00
Iliya Katushenock added 3 commits 2024-05-08 13:12:01 +02:00
fix
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
92c5a1a198
Author
Member

Just for indexing of edges in chain propose i did some speedups of Shortest Edge Path nodes. As i can see, only way to make this in general is to use path finder algorithm.

Just for indexing of edges in chain propose i did some speedups of Shortest Edge Path nodes. As i can see, only way to make this in general is to use path finder algorithm.
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR104623) when ready.
First-time contributor

I think this node could be useful in a scenarios where the base geometry is generated with GN and there is a need for specific selection without going out of the procedural workflow. Same goes for storing attributes base on that selection.

Examples:

  1. Making random selection that goes in specific direction and wraps around the model. If the base mesh is skewed or rotated Edge Rings node could be useful in selecting such edges.

  2. Selecting specific parts of the mesh after joining multiple meshes together. For example after using Mesh Boolean node, but same could go after any remesh operation.

  3. Same as nr 2. but after Volume to Mesh or Grid to Mesh

  4. Selecting specific segments of an extruded curve along its tangent. Could be useful for ropes.

  5. Selecting segments of pseudo-parametric surfaces made with GN and Curve Objects. Note that the extruded curves are not the same ones that are used for generating surface geometry.

  6. Selecting layered parts of the geometry that is not aligned with X/Y/Z axis (similar to example nr 1). Could be useful for masking and selecting parts of procedurally generated cliffs.

I think that this node can be very useful in nodetools too, but I haven't tested it in that context.

I think this node could be useful in a scenarios where the base geometry is generated with GN and there is a need for specific selection without going out of the procedural workflow. Same goes for storing attributes base on that selection. Examples: 1. Making random selection that goes in specific direction and wraps around the model. If the base mesh is skewed or rotated `Edge Rings` node could be useful in selecting such edges. 2. Selecting specific parts of the mesh after joining multiple meshes together. For example after using `Mesh Boolean` node, but same could go after any remesh operation. 3. Same as nr 2. but after `Volume to Mesh` or `Grid to Mesh` 4. Selecting specific segments of an extruded curve along its tangent. Could be useful for ropes. 5. Selecting segments of pseudo-parametric surfaces made with GN and Curve Objects. Note that the extruded curves are not the same ones that are used for generating surface geometry. 6. Selecting layered parts of the geometry that is not aligned with X/Y/Z axis (similar to example nr 1). Could be useful for masking and selecting parts of procedurally generated cliffs. I think that this node can be very useful in nodetools too, but I haven't tested it in that context.
First-time contributor

I think this node could be useful in a scenarios where the base geometry is generated with GN and there is a need for specific selection without going out of the procedural workflow. Same goes for storing attributes base on that selection.

I have to say, just watching the screenshots, they mostly seem too abstract to be applaudable.
I don't think a function is really desired if you leave others behind. I mean those architectural artists, environmental artists, FX artists, mograph, stylized arts, etc.
I only see 6th example to be a little interesting, which reminds me river generation.
but I don't think 6th example has to live with edge ring node.
there can potentially be other more general approaches that doesn't restrict themselves on topology, but more freely variable with random seeds.

Here I am not saying edge ring node isn't good.
I just don't think the provided use-cases promote anything.

> I think this node could be useful in a scenarios where the base geometry is generated with GN and there is a need for specific selection without going out of the procedural workflow. Same goes for storing attributes base on that selection. I have to say, just watching the screenshots, they mostly seem too abstract to be applaudable. I don't think a function is really desired if you leave others behind. I mean those architectural artists, environmental artists, FX artists, mograph, stylized arts, etc. I only see 6th example to be a little interesting, which reminds me river generation. but I don't think 6th example has to live with edge ring node. there can potentially be other more general approaches that doesn't restrict themselves on topology, but more freely variable with random seeds. Here I am not saying edge ring node isn't good. I just don't think the provided use-cases promote anything.
First-time contributor

Would love to see this implemented!

I've definitely had a couple of occasions over the past year where I wanted this node to exist. It seems like a pretty basic form of selection that should be available in procedural modelling, without there being any need to find specific examples to justify it's existence.

There will always be numerous use cases that are hard to anticipate or provide as some sort of generic examples, as every user will have their own specific needs, especially when it comes to a building block node like this.

Would love to see this implemented! I've definitely had a couple of occasions over the past year where I wanted this node to exist. It seems like a pretty basic form of selection that should be available in procedural modelling, without there being any need to find specific examples to justify it's existence. There will always be numerous use cases that are hard to anticipate or provide as some sort of generic examples, as every user will have their own specific needs, especially when it comes to a building block node like this.
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
This pull request has changes conflicting with the target branch.
  • source/blender/blenkernel/BKE_node.hh

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u edge_rings:mod_moder-edge_rings
git checkout mod_moder-edge_rings
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
8 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104623
No description provided.