UI: UIList Hover Highlighting #104677

Harley Acheson · 2023-02-13T02:34:28+01:00

Harley Acheson commented

2023-02-13 02:34:28 +01:00

Show highlight when hovering rows in UILists

This adds a highlight when hovering over items in UILists. It works in both list mode and preview tile mode:

It also works correctly when hovering over list-row nested buttons:

Show highlight when hovering rows in UILists --- This adds a highlight when hovering over items in UILists. It works in both list mode and preview tile mode: ![ListHover1.gif](/attachments/2c37f567-b5cf-4653-864d-4a83ea07791e) It also works correctly when hovering over list-row nested buttons: ![ListHover2.gif](/attachments/19e76a48-827b-4473-a3fd-fc32dfc311bc)

ListHover1.gif

109 KiB

ListHover2.gif

121 KiB

👍 1 ❤️ 6 🎉 2 🚀 1

Brecht Van Lommel requested changes 2023-02-13 08:50:19 +01:00

Brecht Van Lommel left a comment

Behavior looks fine to me.

source/blender/editors/interface/interface_handlers.cc

						
				@ -11277,6 +11277,19 @@ static int ui_region_handler(bContext *C, const wmEvent *event, void * /*userdat

				  uiBut *but = ui_region_find_active_but(region);

				  uiBut *listbox = ui_list_find_mouse_over(region, event);

				  LISTBASE_FOREACH (uiBlock *, block, &region->uiblocks) {

Brecht Van Lommel commented

2023-02-13 08:48:49 +01:00

What does this code do, and why is it here?

This is the main handler for UI input events, logic for handling some specific type of UI button I would expect to be near other code implementing that type.

Of course our UI code is weak and sometimes hacks are needed, but would like to see if this is really necessary.

What does this code do, and why is it here? This is the main handler for UI input events, logic for handling some specific type of UI button I would expect to be near other code implementing that type. Of course our UI code is weak and sometimes hacks are needed, but would like to see if this is really necessary.

Harley Acheson commented

2023-02-13 22:38:58 +01:00

That bit of code was almost identical to code that was called later in that function - ui_handle_view_items_hover, which removes any already-highlighted view items and then adds just the one being hovered. But the stuff I added was specific to UILists instead.

But I don't like that it was confusing. Or that there was this block of code for one thing, but a function for another. So I altered ui_handle_view_items_hover to handle both views and uilists and then renamed the function.

It is definitaly less confusing this way, but the patch looks messier - especially the way it is shown here.

That bit of code was almost identical to code that was called later in that function - `ui_handle_view_items_hover`, which removes any already-highlighted view items and then adds just the one being hovered. But the stuff I added was specific to UILists instead. But I don't like that it was confusing. Or that there was this block of code for one thing, but a function for another. So I altered `ui_handle_view_items_hover` to handle both views and uilists and then renamed the function. It is definitaly less confusing this way, but the patch looks messier - especially the way it is shown here.

brecht marked this conversation as resolved

Brecht Van Lommel added this to the User Interface project 2023-02-13 09:06:29 +01:00

Brecht Van Lommel approved these changes 2023-02-13 22:43:02 +01:00

Brecht Van Lommel left a comment

Thanks, this is much easier to understand now that it's just the same thing for one more button type.

nazir referenced this pull request

2023-02-18 11:38:13 +01:00

The highlighting of the list items does not work. Feature from #104677 #104914

Brecht Van Lommel referenced this pull request from infrastructure/blender-projects-platform

2023-02-19 23:30:07 +01:00

Merging conflict checking takes a long time #43

Brecht Van Lommel commented