UI: Improvement to screen_find_area_xy #104680

Harley Acheson · 2023-02-13T03:23:06+01:00

Harley Acheson commented

2023-02-13 03:23:06 +01:00

In BKE_screen_area_map_find_area_xy (find a ScrArea by 2D location),
ignore edges by using screen verts instead of totrct

We sometimes want to know which editor (ScrArea) is under the current mouse location. However the function treats the editor edges (black borders) as unknown no-mans land belonging to nobody. In the following capture you will see that the Join Area operator gives a "stopsign" cursor at the very middle of the shared edge:

But this isn't correct behavior in that screen edges are just a visual construct. Editors do not really have any gaps between them, not even a pixel. Every part of every window is covered by some editor, bounded by their (often shared) screen verts. It is just that we inset from that outer boundary to create a totrct that contains the inner bounds.

This patch just uses the area's screen verts (outer bounds) instead of the inner bounds, and therefore always ignores edges when finding areas:

In BKE_screen_area_map_find_area_xy (find a ScrArea by 2D location), ignore edges by using screen verts instead of totrct --- We sometimes want to know which editor (ScrArea) is under the current mouse location. However the function treats the editor edges (black borders) as unknown no-mans land belonging to nobody. In the following capture you will see that the Join Area operator gives a "stopsign" cursor at the very middle of the shared edge: ![FindArea1.gif](/attachments/e40357e9-e661-401f-a61f-5d9a64cf84ec) But this isn't correct behavior in that screen edges are just a visual construct. Editors do not really have any gaps between them, not even a pixel. Every part of every window is covered by some editor, bounded by their (often shared) screen verts. It is just that we inset from that outer boundary to create a totrct that contains the inner bounds. This patch just uses the area's screen verts (outer bounds) instead of the inner bounds, and therefore always ignores edges when finding areas: ![FindArea2.gif](/attachments/04d3315f-f9fb-4992-8f5b-96029f934ff0)

FindArea2.gif

177 KiB

FindArea1.gif

211 KiB

👍 2

Brecht Van Lommel approved these changes 2023-02-13 08:35:56 +01:00

Brecht Van Lommel added this to the User Interface project 2023-02-13 09:06:29 +01:00

Harley Acheson force-pushed FindArea from a7b162a883 to 6ce4f2f895

2023-02-16 01:17:35 +01:00

Compare

Harley Acheson commented

2023-02-16 01:19:53 +01:00