Curves: Add remove_selection function #104813

Merged
Falk David merged 5 commits from filedescriptor/blender:curves-remove-selection-function into blender-v3.5-release 2023-02-16 15:26:24 +01:00
Member

This adds a remove_selection function that can be used by other
objects that make use of CurvesGeometry.

This adds a `remove_selection` function that can be used by other objects that make use of `CurvesGeometry`.
Falk David added 1 commit 2023-02-16 12:09:36 +01:00
f16c091dd9 Curves: Add remove_selection function
This adds a `remove_selection` function that can be used by other
objects that make use of `CurvesGeometry`.
Falk David requested review from Hans Goudey 2023-02-16 12:10:23 +01:00
Hans Goudey approved these changes 2023-02-16 14:22:19 +01:00
Hans Goudey left a comment
Member

Looks great, thanks!

Looks great, thanks!
@ -1115,3 +1100,1 @@
BLI_assert_unreachable();
}
if (attributes.domain_size(domain) != domain_size_orig) {
Member

Picky: might as well remove this newline here too, doesn't seem helpful anymore

Picky: might as well remove this newline here too, doesn't seem helpful anymore
filedescriptor marked this conversation as resolved
@ -188,0 +189,4 @@
/** \name Editing
* \{ */
bool remove_selection(bke::CurvesGeometry &curves, eAttrDomain selection_domain);
Member
/**
 * Remove (dissolve) selected curves or points based on the ".selection" attribute.
 */
``` /** * Remove (dissolve) selected curves or points based on the ".selection" attribute. */ ```
filedescriptor marked this conversation as resolved
Hans Goudey added this to the Nodes & Physics project 2023-02-16 14:22:34 +01:00
Member

Might as well commit this to 3.5, since it fixes the default value too.

Might as well commit this to 3.5, since it fixes the default value too.
Author
Member

So should I change this PR to be merged into blender-v3.5-release?

So should I change this PR to be merged into `blender-v3.5-release`?
Member

If it's not too hard and you think it's reasonable, yeah, I think so. Otherwise I can fix the default value separately in 3.5.

If it's not too hard and you think it's reasonable, yeah, I think so. Otherwise I can fix the default value separately in 3.5.
filedescriptor changed target branch from main to blender-v3.5-release 2023-02-16 15:16:40 +01:00
Falk David merged commit 47934b5c2b into blender-v3.5-release 2023-02-16 15:26:24 +01:00
Falk David deleted branch curves-remove-selection-function 2023-02-16 15:26:25 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104813
No description provided.