Fix #104810: Appending a camera does not pull in background movie clip #104815

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:104810 into blender-v3.5-release 2023-02-17 09:36:30 +01:00
Member

This was broken even before 0649e63716 and was always expanding the
Image, not the movie clip (even if the source was set to
CAM_BGIMG_SOURCE_MOVIE)

Now the rule here seems to be to always expand unconditionally, so
remove checking the source and always expand image and movie clip.

This was broken even before 0649e6371629 and was always expanding the `Image`, not the movie clip (even if the source was set to `CAM_BGIMG_SOURCE_MOVIE`) Now the rule here seems to be to always expand unconditionally, so remove checking the source and always expand image and movie clip.
Philipp Oeser added this to the Core project 2023-02-16 12:22:28 +01:00
Philipp Oeser requested review from Bastien Montagne 2023-02-16 12:22:38 +01:00
Bastien Montagne requested changes 2023-02-16 12:46:26 +01:00
Bastien Montagne left a comment
Owner

The logic in this code is also wrong, these two pointers should be expanded, regardless of the source setting.

The logic in this code is also wrong, these two pointers should be expanded, regardless of the source setting.
Philipp Oeser force-pushed 104810 from c5f83ff2ee to f8e1bb23a3 2023-02-16 13:33:57 +01:00 Compare
Philipp Oeser requested review from Bastien Montagne 2023-02-16 14:00:36 +01:00
Bastien Montagne approved these changes 2023-02-16 16:03:14 +01:00
Bastien Montagne left a comment
Owner

LGTM now indeed. :)

LGTM now indeed. :)
Philipp Oeser merged commit c624e56ffc into blender-v3.5-release 2023-02-17 09:36:30 +01:00
Bastien Montagne removed this from the Core project 2023-07-03 12:49:01 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104815
No description provided.