Fix #104785: Quick fur keeps asset status of appended node groups #104828

Merged
Hans Goudey merged 2 commits from HooglyBoogly/blender:fix-quick-fur-append-node-group into blender-v3.5-release 2023-02-16 18:14:58 +01:00
Member

When appending assets it isn't expected for the asset tags and meta-data
to be include. Add an option to the append operator to disable that and
use it in the "Fur" operator.

When appending assets it isn't expected for the asset tags and meta-data to be include. Add an option to the append operator to disable that and use it in the "Fur" operator.
Hans Goudey added this to the 3.5 milestone 2023-02-16 16:56:58 +01:00
Hans Goudey added the
Module
Pipeline, Assets & IO
Interest
Geometry Nodes
labels 2023-02-16 16:56:58 +01:00
Hans Goudey added this to the Pipeline, Assets & IO project 2023-02-16 16:57:52 +01:00
Hans Goudey requested review from Julian Eisel 2023-02-16 16:58:00 +01:00
Julian Eisel requested review from Bastien Montagne 2023-02-16 16:58:51 +01:00
Julian Eisel approved these changes 2023-02-16 16:59:57 +01:00
Julian Eisel left a comment
Member

Simple and LGTM, but I rather have @mont29 approve this as well.

Simple and LGTM, but I rather have @mont29 approve this as well.
Bastien Montagne requested changes 2023-02-16 17:04:30 +01:00
Bastien Montagne left a comment
Owner

Patch LGTM, but the name of the commit is not valid, it should not hide a change to a generic API behind an issue fix.

Would suggest to separate the change to object_quick_effects.py into its own commit actually.

Both commits also seem to be missing a proper commit message. Title is not enough, at least not for the change to the operator.

Patch LGTM, but the name of the commit is not valid, it should not hide a change to a generic API behind an issue fix. Would suggest to separate the change to `object_quick_effects.py` into its own commit actually. Both commits also seem to be missing a proper commit message. Title is not enough, at least not for the change to the operator.
Author
Member

The PR is meant to be squashed, not merged. I don't really see a benefit of adding and using the new option in separate commits.

The PR is meant to be squashed, not merged. I don't really see a benefit of adding and using the new option in separate commits.
Author
Member

Okay, reading your comment again I think it's reasonable. I'll split up the PR into two commits.

Okay, reading your comment again I think it's reasonable. I'll split up the PR into two commits.
Hans Goudey force-pushed fix-quick-fur-append-node-group from b868997d68 to ce22960cdf 2023-02-16 17:17:40 +01:00 Compare
Hans Goudey requested review from Bastien Montagne 2023-02-16 17:18:10 +01:00
Bastien Montagne approved these changes 2023-02-16 18:07:38 +01:00
Bastien Montagne left a comment
Owner

Thanks, LGTM now.

Thanks, LGTM now.
Hans Goudey merged commit 9f41f95c8e into blender-v3.5-release 2023-02-16 18:14:58 +01:00
Hans Goudey deleted branch fix-quick-fur-append-node-group 2023-02-16 18:15:01 +01:00
Bastien Montagne removed this from the Pipeline, Assets & IO project 2023-07-03 13:02:05 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104828
No description provided.