File Browser: Make full file name label draggable #104830

Julian Eisel · 2023-02-16T17:23:04+01:00

Julian Eisel commented

2023-02-16 17:23:04 +01:00

Previously only the icon of a file could be dragged in the list display
modes, the name label would invoke box select. This made dragging quite
finicky. I've seen this cause quite some frustration, especially when
the file browser is used as a regular editor to drag data from into
other editors.

Instead follow the Outliner (and some other file browsers like the macOS
one): Dragging on empty space invokes box select, dragging on the name
or icon invokes drag & drop of the item.

Note that 1e9564864c and 6da512f0bc were needed to prepare this change.

Previously only the icon of a file could be dragged in the list display modes, the name label would invoke box select. This made dragging quite finicky. I've seen this cause quite some frustration, especially when the file browser is used as a regular editor to drag data from into other editors. Instead follow the Outliner (and some other file browsers like the macOS one): Dragging on empty space invokes box select, dragging on the name or icon invokes drag & drop of the item. Note that 1e9564864c and 6da512f0bc were needed to prepare this change.

❤️ 2

Julian Eisel added the

Module

User Interface

label 2023-02-16 17:23:04 +01:00

Julian Eisel added 1 commit 2023-02-16 17:23:16 +01:00

735ac5a8e7 File Browser: Expand draggable area to full file name

Previously only the icon of a file could be dragged in the list display
modes, the name label would invoke box select. This made dragging quite
finicky. I've seen this cause quite some frustration, especially when
the file browser is used as a regular editor to drag data from into
other editors.

Instead follow the Outliner (and some other file browsers like the macOS
one): Dragging on empty space invokes box select, dragging on the name
or icon invokes drag & drop of the item.

Note that 1e9564864c and 6da512f0bc were needed to prepare this change.

Julian Eisel changed title from ~~File Browser: Expand draggable area to full file name~~ to File Browser: Make full file name label draggable

2023-02-16 17:23:48 +01:00

Julian Eisel requested review from Pablo Vazquez 2023-02-16 17:24:13 +01:00

Julian Eisel requested review from Dalai Felinto 2023-02-16 17:24:25 +01:00

Pablo Vazquez approved these changes 2023-02-16 17:31:18 +01:00

Pablo Vazquez left a comment

Functionality wise: +1!

This always felt so confusing. This is the expected behavior, although I personally always used B to box select anyway.

Thank you for working on it!

Functionality wise: +1! This always felt so confusing. This is the expected behavior, although I personally always used `B` to box select anyway. Thank you for working on it!

Dalai Felinto commented

2023-02-16 18:09:37 +01:00

I built it here, and I'm still trying to wrap my head around this.

Right now there is a related issue that makes this patch very annoying. Basically if you cancel the dragging it closes the entire File Dialog window. Now that it will be more easy to "drag" the items this will happen very often, and I can foresee a lot of frustration.

I do wonder if we should allow dragging at all when in pop-up mode.

Also this patch introduced a bug (see video). Sometimes it forbid me from dragging images when I have Vertical List as the display mode.

I built it here, and I'm still trying to wrap my head around this. Right now there is a related issue that makes this patch *very* annoying. Basically if you cancel the dragging it closes the entire File Dialog window. Now that it will be more easy to "drag" the items this will happen very often, and I can foresee a lot of frustration. I do wonder if we should allow dragging at all when in pop-up mode. ---- Also this patch introduced a bug (see video). Sometimes it forbid me from dragging images when I have Vertical List as the display mode.

bug_box_select-2023-02-16_18.06.58.mp4

2.2 MiB

Julian Eisel commented

2023-02-16 19:28:17 +01:00

Right now there is a related issue that makes this patch very annoying. Basically if you cancel the dragging it closes the entire File Dialog window. Now that it will be more easy to "drag" the items this will happen very often, and I can foresee a lot of frustration.

Escape and right-click should just properly cancel, this wasn't implemented well. Submitted #104838.

I do wonder if we should allow dragging at all when in pop-up mode.

Yeah definitely. I think it's useful to be able to just quickly drag an image or so into the 3D view while browsing for something different. Or even to take a .blend while in a open/save dialog, and drag it into the main window to get the choice to link/append from that file.
At least I don't see much of a point in forbidding it, plus not being able to drag like usually can be confusing (or hide the fact that you can do it in another context even).

Also this patch introduced a bug (see video). Sometimes it forbid me from dragging images when I have Vertical List as the display mode.

Weird, I'll have to look into that.

> Right now there is a related issue that makes this patch *very* annoying. Basically if you cancel the dragging it closes the entire File Dialog window. Now that it will be more easy to "drag" the items this will happen very often, and I can foresee a lot of frustration. Escape and right-click should just properly cancel, this wasn't implemented well. Submitted #104838. > I do wonder if we should allow dragging at all when in pop-up mode. Yeah definitely. I think it's useful to be able to just quickly drag an image or so into the 3D view while browsing for something different. Or even to take a .blend while in a open/save dialog, and drag it into the main window to get the choice to link/append from that file. At least I don't see much of a point in forbidding it, plus not being able to drag like usually can be confusing (or hide the fact that you can do it in another context even). > ---- > > Also this patch introduced a bug (see video). Sometimes it forbid me from dragging images when I have Vertical List as the display mode. Weird, I'll have to look into that.

Julian Eisel commented

2023-02-17 12:02:38 +01:00

Also this patch introduced a bug (see video). Sometimes it forbid me from dragging images when I have Vertical List as the display mode.

Ah gosh, I know what this is caused by. The dropping handlers determine the type of dragged data based on the icon (yes seriously). Since this patch uses empty buttons to invoke dragging, this breaks.

I had a patch to fix this but don't know the D number, not sure how to get that back right now.

> Also this patch introduced a bug (see video). Sometimes it forbid me from dragging images when I have Vertical List as the display mode. Ah gosh, I know what this is caused by. The dropping handlers [determine the type of dragged data based on the icon](https://projects.blender.org/blender/blender/src/branch/main/source/blender/editors/space_sequencer/sequencer_drag_drop.c#L98) (yes seriously). Since this patch uses empty buttons to invoke dragging, this breaks. I had a patch to fix this but don't know the D number, not sure how to get that back right now.

Brecht Van Lommel added this to the User Interface project 2023-02-20 10:38:00 +01:00

Julian Eisel referenced this issue from a commit

2023-02-27 16:47:30 +01:00

UI: Refactor path dropping so logic doesn't depend on icons

Julian Eisel added 3 commits 2023-02-27 16:53:11 +01:00

87f650c147 Merge branch 'main' into temp-file-browser-full-label-drag

232d6bd4bf Fix missing check for optional dragging on icon

4f8d4737b1 Merge branch 'main' into temp-file-browser-full-label-drag

Julian Eisel commented

2023-02-27 16:54:27 +01:00

Two changes are in main now:

This should address the mentioned issues.

Two changes are in `main` now: - [d58e422ac36f: UI: Properly cancel dragging on escape or right-click](https://projects.blender.org/blender/blender/commit/d58e422ac36f1d151248890ca535c85b7ba39e2c) - [17e92711d3bd: UI: Refactor path dropping so logic doesn't depend on icons](https://projects.blender.org/blender/blender/commit/17e92711d3bdf8b587bd484977f2ca1eca4116f8) This should address the mentioned issues.

Dalai Felinto commented

2023-02-28 10:38:22 +01:00

I still get the box select when my drag starts right in the space between the two lines:

Can we use the same margin that the mouse over highlight uses? For the mouse over highlight there is no ambiguity - there is always one line selected, even if the mouse is in the middle of two lines.

I still get the box select when my drag starts right in the space between the two lines: ![image](/attachments/c8c6d07f-8c62-495f-8dd0-b13d5c40ed40) Can we use the same margin that the mouse over highlight uses? For the mouse over highlight there is no ambiguity - there is always one line selected, even if the mouse is in the middle of two lines.

image.png

1.5 MiB

Julian Eisel commented

2023-02-28 11:12:31 +01:00

Yeah I've been a bit torn on this. It is quite useful if you want to box select, macOS does the same. However there it feels more expected for whatever reason, and from own testing I agree it gets more in the way probably.

Pablo Vazquez commented

2023-03-01 14:47:04 +01:00

Indeed it gets more in the way. Most users already know that they can border select with B anyway, or Shift+Click for range selection.

Indeed it gets more in the way. Most users already know that they can border select with `B` anyway, or Shift+Click for range selection.

Francesco Siddi commented

2023-03-14 14:45:12 +01:00

Can this be merged as it is, and have the margin issue dealt with later?

Julian Eisel added 4 commits 2023-03-15 15:57:48 +01:00

7339d04839 Cleanup: Remove redundant parenthesis

68b1927ab5 Merge branch 'main' into temp-file-browser-full-label-drag

8528ab1e52 Merge branch 'main' into temp-file-browser-full-label-drag

73cfd3664b Use full line height to trigger dragging

Julian Eisel commented

2023-03-15 16:01:55 +01:00

I still get the box select when my drag starts right in the space between the two lines:

Can we use the same margin that the mouse over highlight uses? For the mouse over highlight there is no ambiguity - there is always one line selected, even if the mouse is in the middle of two lines.

This is now changed, we always use the full row height for dragging. The dragging hitbox also matches the highlighting exactly now, so whatever is highlighted will match the dragging.

> I still get the box select when my drag starts right in the space between the two lines: > > Can we use the same margin that the mouse over highlight uses? For the mouse over highlight there is no ambiguity - there is always one line selected, even if the mouse is in the middle of two lines. This is now changed, we always use the full row height for dragging. The dragging hitbox also matches the highlighting exactly now, so whatever is highlighted will match the dragging.

Julian Eisel referenced this issue from a commit

2023-03-15 16:09:29 +01:00

File Browser: Make full file name label draggable

Julian Eisel commented

2023-03-15 16:11:55 +01:00

Committed with c3dfe1e204.

Committed with c3dfe1e204.

🎉 1

Julian Eisel closed this pull request

2023-03-15 16:11:57 +01:00

Julian Eisel deleted branch temp-file-browser-full-label-drag

2023-03-15 16:12:15 +01:00