Fix 104816: Ensure Win32 visible title bar #104848

Harley Acheson · 2023-02-17T02:33:59+01:00

Harley Acheson commented

2023-02-17 02:33:59 +01:00

When creating Win32 windows, ensure that the caption bar is visible.

Since #104438 I am wanting to allow blender windows to span multiple monitors, like this:

This patch fixes a bug with that implementation. When starting Blender without a "startup.blend", the initial window is maximized and is requested to be at 0,0 and at maximum size of the monitor. This displays correctly at first (since it is maximized), but if you then press the "restore down" button the caption bar will be above the monitor top edge.

This is because the requested rectangle must be adjusted by the OS (using either fpAdjustWindowRectExForDpi or AdjustWindowRectEx). If the requested top is zero that adjustment makes it about -38. This is so that the top of our client area is where we requested it to be. But this is not what we actually want.

This patch restores a check to ensure that the caption is not above the top of the applicable monitor. The only complication is that we have to use the monitor that is at the original requested top value. If we use the value after adjustment it might be on the monitor above if the user has a stacked orientation of multiple monitors.

This patch also makes another very small correction. When adjusting for the DPI of the monitor, do so for the monitor that is at the middle of the requested area. This is required because Windows uses exactly this for the DPI of the window for its calculations. Current code would have used the monitor at the bottom-right corner of the window by mistake. This is only an issue when when you have multiple monitors that differ in resolution. The error here could result in the possible misplacement of a window by the difference in caption height, so maybe 5-20 pixels.

When creating Win32 windows, ensure that the caption bar is visible. --- Since https://projects.blender.org/blender/blender/pulls/104438 I am wanting to allow blender windows to span multiple monitors, like this: ![SpanMonitors.png](/attachments/95b0b0e7-5c5f-4ecc-a4a2-0c879f5435ba) This patch fixes a bug with that implementation. When starting Blender *without* a "startup.blend", the initial window is maximized and is requested to be at 0,0 and at maximum size of the monitor. This displays correctly at first (since it is maximized), but if you then press the "restore down" button the caption bar will be above the monitor top edge. This is because the requested rectangle must be adjusted by the OS (using either fpAdjustWindowRectExForDpi or AdjustWindowRectEx). If the requested top is zero that adjustment makes it about -38. This is so that the top of our client area is where we requested it to be. But this is not what we actually want. This patch restores a check to ensure that the caption is not above the top of the applicable monitor. The only complication is that we have to use the monitor that is at the original requested top value. If we use the value after adjustment it might be on the monitor above if the user has a stacked orientation of multiple monitors. This patch also makes another very small correction. When adjusting for the DPI of the monitor, do so for the monitor that is at the middle of the requested area. This is required because Windows uses exactly this for the DPI of the window for its calculations. Current code would have used the monitor at the bottom-right corner of the window by mistake. This is only an issue when when you have multiple monitors that differ in resolution. The error here could result in the possible misplacement of a window by the difference in caption height, so maybe 5-20 pixels.

SpanMonitors.png

20 KiB

Harley Acheson requested review from Ray molenkamp 2023-02-17 02:34:36 +01:00

Harley Acheson referenced this pull request

2023-02-17 02:47:03 +01:00

Windows, Stuck at monitor 1 in maximized status #104816

Thomas Dinges commented

2023-02-17 11:33:54 +01:00

Note, this should go into the 3.5 branch, we're in Bcon3. https://wiki.blender.org/wiki/Process/Using_Stabilizing_Branch

Harley Acheson commented

2023-02-17 16:37:05 +01:00

Note, this should go into the 3.5 branch, we're in Bcon3. https://wiki.blender.org/wiki/Process/Using_Stabilizing_Branch

No, this is fixing a bug that is only in 3.6.

> Note, this should go into the 3.5 branch, we're in Bcon3. https://wiki.blender.org/wiki/Process/Using_Stabilizing_Branch No, this is fixing a bug that is only in 3.6.

Ray molenkamp approved these changes 2023-02-17 17:26:10 +01:00

Harley Acheson force-pushed HiddenTitlebar from dd4341e2b2 to 3df9483ab6

2023-02-17 19:23:40 +01:00

Compare

Harley Acheson commented

2023-02-17 19:29:08 +01:00

@blender-bot build windows

Harley Acheson force-pushed HiddenTitlebar from 3df9483ab6 to 5ed7c49ff3

2023-02-17 20:09:27 +01:00

Compare

Harley Acheson merged commit dd2ab55507 into main

2023-02-17 20:11:55 +01:00