Fix #101518: Curves sculptmode Stabilize Stroke misses indicator line #105021

Closed
Philipp Oeser wants to merge 1 commits from lichtwerk:101518 into blender-v3.5-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Drawing code paint_draw_smooth_cursor would be called correctly, it
was just the color not being initialized.

This is usually done with BKE_paint_init, but in the case of curves
sculpting brushes this would create an additional (unnamed) brush which
should be avoided since the workspace toolsystem creates the "right"
brush anyways.

So this patch just does the minimal work to get the Stabilize Stroke
indicator line to draw (which is initializing the color).

Brought over from https://archive.blender.org/developer/D16793

Drawing code `paint_draw_smooth_cursor` would be called correctly, it was just the color not being initialized. This is usually done with `BKE_paint_init`, but in the case of curves sculpting brushes this would create an additional (unnamed) brush which should be avoided since the workspace toolsystem creates the "right" brush anyways. So this patch just does the minimal work to get the Stabilize Stroke indicator line to draw (which is initializing the color). Brought over from https://archive.blender.org/developer/D16793
Philipp Oeser added 1 commit 2023-02-21 14:03:32 +01:00
612a4382c4 FiX #101518: Curves sculptmode Stabilize Stroke misses indicator line
Drawing code `paint_draw_smooth_cursor` would be called correctly, it
was just the color not being initialized.

This is usually done with `BKE_paint_init`, but in the case of curves
sculpting brushes this would create an additional (unnamed) brush which
should be avoided since the workspace toolsystem creates the "right"
brush anyways.

So this patch just does the minimal work to get the Stabilize Stroke
indicator line to draw (which is initializing the color).

Brought over from https://archive.blender.org/developer/D16793
Philipp Oeser changed title from FiX #101518: Curves sculptmode Stabilize Stroke misses indicator line to Fix #101518: Curves sculptmode Stabilize Stroke misses indicator line 2023-02-21 14:03:55 +01:00
Philipp Oeser requested review from Jacques Lucke 2023-02-21 14:04:07 +01:00
Philipp Oeser added this to the Nodes & Physics project 2023-02-21 14:04:24 +01:00
Philipp Oeser requested review from Falk David 2023-02-21 14:05:02 +01:00
Jacques Lucke approved these changes 2023-02-21 16:07:24 +01:00
Falk David approved these changes 2023-02-21 17:29:28 +01:00
Falk David left a comment
Member

Tested it and it works well. I'd be curious why BKE_paint_init creates a brush though, it seems like it would be nice if we can use the same function everywhere.

Might be better for a later cleanup though, so I will accept the changes.

Tested it and it works well. I'd be curious why `BKE_paint_init` creates a brush though, it seems like it would be nice if we can use the same function everywhere. Might be better for a later cleanup though, so I will accept the changes.
Author
Member

Tested it and it works well. I'd be curious why BKE_paint_init creates a brush though, it seems like it would be nice if we can use the same function everywhere.

Might be better for a later cleanup though, so I will accept the changes.

To know exactly, I would have to get my notes from phabricator back (or check again tomorrow)...

IIrc, it had to do with the fact that the curves sculpt brushes are not part of the default startup file, the toolsystem would eventually create them from scratch, but by the time we enter sculptmode, they would not be there yet, so BKE_brush_first_search doesnt find them and just creates one (that behavior indeed might have to be revisited, not sure without looking at code).

> Tested it and it works well. I'd be curious why `BKE_paint_init` creates a brush though, it seems like it would be nice if we can use the same function everywhere. > > Might be better for a later cleanup though, so I will accept the changes. To know exactly, I would have to get my notes from phabricator back (or check again tomorrow)... IIrc, it had to do with the fact that the curves sculpt brushes are not part of the default startup file, the toolsystem would eventually create them from scratch, but by the time we enter sculptmode, they would not be there yet, so `BKE_brush_first_search` doesnt find them and just creates one (that behavior indeed might have to be revisited, not sure without looking at code).
Member

That seems like a bigger change, so I think fixing it in this way now is fine.

That seems like a bigger change, so I think fixing it in this way now is fine.
Author
Member

Committed e5a0a14a27

Committed e5a0a14a27ae272afacf84192a1caa2223d5470b
Philipp Oeser closed this pull request 2023-02-22 11:46:12 +01:00
Philipp Oeser deleted branch 101518 2023-02-22 11:46:38 +01:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105021
No description provided.