VSE: Add sound strip retiming support #105071

Richard Antalik · 2023-02-22T13:35:09+01:00

Richard Antalik commented

2023-02-22 13:35:09 +01:00

This patch contains changes needed for retiming sound strips. This is a part of blender/blender#104544

Deviation from blender/blender#100337 is, that changes in audaspace are not separated.
Versioning for old files is not present, because resulting data is unusable (whole animation is baked, so changing retiming is basically impossible). Versioning also results in precision issues which results in non uniform sound pitch in some cases. And finally calculating strip offset correction is non-trivial (that is least of an issue, but worth mentioning still). So I would advocate to not convert old data to current implementation. I think, that supporting smooth speed transitions would allow for more efficient versioning code.

This patch contains changes needed for retiming sound strips. This is a part of blender/blender#104544 ---- Deviation from blender/blender#100337 is, that changes in audaspace are not separated. Versioning for old files is not present, because resulting data is unusable (whole animation is baked, so changing retiming is basically impossible). Versioning also results in precision issues which results in non uniform sound pitch in some cases. And finally calculating strip offset correction is non-trivial (that is least of an issue, but worth mentioning still). So I would advocate to not convert old data to current implementation. I think, that supporting smooth speed transitions would allow for more efficient versioning code.

Richard Antalik added 5 commits 2023-02-22 13:35:27 +01:00

0859cfbd50 VSE: Add retiming tool

This tools allows to change strip playback speed by manipulating
retiming handles. More handles can be added to single strip to create
variable playback speed.

This tool replaces Speed Factor property in time panel.

03c5ee0294 Fix compilation warning

buildbot/vexp-code-patch-coordinator Build done. Details

e2042ab55d Fix crash on NULL dereference

6b25ac1854 Fix redundant redeclaration warning

bec58cf318 VSE: Add sound strip retiming support

This patch contains changes needed for retiming sound strips. This is a part of #104544

----

Deviation from #100337 is, that changes in audaspace are not separated.
Versioning for old files is not present, because resulting data is unusable (whole animation is baked, so changing retiming is basically impossible). Versioning also results in precision issues which results in non uniform sound pitch in some cases. And finally calculating strip offset correction is non-trivial (that is least of an issue, but worth mentioning still). So I would advocate to not convert old data to current implementation. I think, that supporting smooth speed transitions would allow for more efficient versioning code.

Richard Antalik commented

2023-02-22 13:39:28 +01:00

Well, this didn't work as expected... Will try to rectify unintended changes

Richard Antalik commented

2023-02-22 13:57:10 +01:00

Will rather close and make new PR

Richard Antalik closed this pull request

2023-02-22 13:57:11 +01:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: Add sound strip retiming support #105071

Pull request closed