Fix #103387: Radius affects curves bounding box #105154

Merged

Hans Goudey merged 1 commits from HooglyBoogly/blender:fix-curves-bounds-radius into blender-v3.5-release

2023-02-27 00:01:13 +01:00

Hans Goudey commented

2023-02-23 21:19:23 +01:00

Member

e8f4010611 unified the bounds computation for the new curves
object type and the rest of the curves system used by geometry nodes.
In the process, it made bounds affected by the control point radius.
In theory that makes sense; the bounds are supposed to be the extents
of the visible geometry. But in practice the change wasn't expected,
for a few reasons:

The radius has never affected the bounds for the legacy curve type
The default radius of legacy curve objects is absurdly large at 1.0m
Only the new curve object has visible radius, and only in "strip"
mode or when rendered with Cycles

Currently the bounds are only used for the "Bounding Box" geometry node
and the panel in the 3D viewport sidebar, so there isn't any incentive
to choose less intuitive behavior yet.

Long term, the correct behavior is probably to include the radius in
the bounds, but this commit postpones that change to when it works
better with the rest of the curves system.

e8f4010611e76e0b88cd unified the bounds computation for the new curves object type and the rest of the curves system used by geometry nodes. In the process, it made bounds affected by the control point radius. In theory that makes sense; the bounds are supposed to be the extents of the visible geometry. But in practice the change wasn't expected, for a few reasons: - The radius has never affected the bounds for the legacy curve type - The default radius of legacy curve objects is absurdly large at 1.0m - Only the new curve object has visible radius, and only in "strip" mode or when rendered with Cycles Currently the bounds are only used for the "Bounding Box" geometry node and the panel in the 3D viewport sidebar, so there isn't any incentive to choose less intuitive behavior yet. Long term, the correct behavior is probably to include the radius in the bounds, but this commit postpones that change to when it works better with the rest of the curves system.

Hans Goudey added this to the 3.5 milestone 2023-02-23 21:19:23 +01:00

Hans Goudey added the

Nodes & Physics

labels 2023-02-23 21:19:23 +01:00

Hans Goudey added 1 commit 2023-02-23 21:19:35 +01:00

buildbot/vexp-code-patch-coordinator Build done. Details

6eaaceda80 Fix #103387 : Radius affects curves bounding box

e8f4010611 unified the bounds computation for the new curves
object type and the rest of the curves system used by geometry nodes.
In the process, it made bounds affected by the control point radius.
In theory that makes sense; the bounds are supposed to be the extents
of the visible geometry. But in practice the change wasn't expected,
for a few reasons:
 - The radius has never affected the bounds for the legacy curve type
 - The default radius of legacy curve objects is absurdly large at 1.0m
 - Only the new curve object has visible radius, and only in "strip"
   mode or when rendering with Cycles

Currently the bounds are only used for the "Bounding Box" geometry node
and the panel in the 3D viewport sidebar, so there isn't any incentive
to choose less intuitive behavior yet.

Long term, the _correct_ behavior is probably to include the radius in
the bounds, but this commit postpones that change to when it works
better with the rest of the curves system.

Hans Goudey added this to the Nodes & Physics project 2023-02-23 21:19:59 +01:00

Hans Goudey requested review from Jacques Lucke 2023-02-23 21:20:07 +01:00

Jacques Lucke commented

2023-02-24 14:38:29 +01:00

Member

@blender-bot build

@blender-bot build

Jacques Lucke approved these changes 2023-02-24 14:38:40 +01:00

Hans Goudey referenced this issue from a commit

2023-02-27 00:01:13 +01:00

Fix #103387: Radius affects curves bounding box

Hans Goudey merged commit 97a8bb450c into blender-v3.5-release

2023-02-27 00:01:13 +01:00

Hans Goudey deleted branch fix-curves-bounds-radius

2023-02-27 00:01:16 +01:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105154

No description provided.