Fix #105109: Pick selection with multi object edit #105184

Member

Pick selection for the Curves object was not considering multi object
editing. Only the active object was considered.

This fix introduces pick selection for Curves for multi object editing

Pick selection for the Curves object was not considering multi object editing. Only the active object was considered. This fix introduces pick selection for Curves for multi object editing
Falk David requested review from Hans Goudey 2023-02-24 16:43:53 +01:00
filedescriptor changed target branch from main to blender-v3.5-release 2023-02-27 16:03:22 +01:00
Hans Goudey requested changes 2023-02-27 16:20:01 +01:00
Hans Goudey left a comment
Member

Big picture looks good

Big picture looks good
@ -2989,0 +2990,4 @@
*
* \returns true if the selection changed.
*/
static bool ed_curves_select_pick(bContext *C, const int mval[2], const SelectPick_Params *params)
Member

Pass C and params as references

Pass `C` and `params` as references
filedescriptor marked this conversation as resolved
@ -2991,0 +2998,4 @@
/* Setup view context for argument to callbacks. */
ED_view3d_viewcontext_init(C, &vc, depsgraph);
bool changed = false;
Member

Declare changed right above closest_data, closer to where it's set and used

Declare `changed` right above `closest_data`, closer to where it's set and used
filedescriptor marked this conversation as resolved
@ -2991,0 +3017,4 @@
*params,
mval,
closest_data)) {
changed = true;
Member

Seems like multiple curve objects could get a dependency graph tag, when this operator is only supposed to affect one of them. Maybe it needs to keep track of which object has the closets element and only tag the update at the end.

Seems like multiple curve objects could get a dependency graph tag, when this operator is only supposed to affect one of them. Maybe it needs to keep track of which object has the closets element and only tag the update at the end.
Author
Member

That could work except that click select can also cause a deselection of elements in the other objects. It would have to be more sophisticated

That could work except that click select can also cause a deselection of elements in the other objects. It would have to be more sophisticated
Member

I think it's worth solving that here. Otherwise that leaves some unknown restructuring of the logic for later, and these reevaluations often aren't trivial.

The "found" and "changed" return states could be split up maybe?

I think it's worth solving that here. Otherwise that leaves some unknown restructuring of the logic for later, and these reevaluations often aren't trivial. The "found" and "changed" return states could be split up maybe?
filedescriptor marked this conversation as resolved
Falk David requested review from Hans Goudey 2023-03-02 14:45:52 +01:00
Hans Goudey approved these changes 2023-03-02 14:55:22 +01:00
Hans Goudey left a comment
Member

I'll work on the update tagging a little bit after this is committed, it's not very important but for some reason I find myself caring about it.

I'll work on the update tagging a little bit after this is committed, it's not very important but for some reason I find myself caring about it.
Falk David merged commit 00ca7c5221 into blender-v3.5-release 2023-03-02 15:43:26 +01:00
Falk David deleted branch curves-fix-pick-selection-multi-object-editing 2023-03-02 15:43:28 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105184
No description provided.