UV: Migrate UV packing from Editor to bf_geometry. #105212
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#105212
Loading…
Reference in New Issue
No description provided.
Delete Branch "Chris_Blackbourn/blender:uv-pack-migrate"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
No response
I think it's worth cleaning up the public header a little bit, just noticed a few small things.
@ -0,0 +10,4 @@
#include "BLI_vector.hh"
#include "DNA_vec_types.h"
typedef enum {
Typedef
typedef
isn't necessary in C++, you can just useenum Name {
@ -0,0 +44,4 @@
public:
rctf bounds_rect;
};
Is
extern
necessary here? I wouldn't think so.@ -0,0 +45,4 @@
rctf bounds_rect;
};
extern BoxPack *pack_islands(const blender::Vector<PackIsland *> &island_vector,
Pass a
Span
rather than a const reference to a vector, so the function doesn't depend on which container the elements are stored in.@ -0,0 +46,4 @@
};
extern BoxPack *pack_islands(const blender::Vector<PackIsland *> &island_vector,
const struct UVPackIsland_Params ¶ms,
The
struct
keyword is unnecessary here@HooglyBoogly Nice spotting! Have updated as
496567acce
If you see anything else, feel free to edit inline or post here.
Noticed one more thing. Also, could you press "Resolve Conversation" on my comments that you've addressed? Thanks.
@ -0,0 +9,4 @@
#include "BLI_boxpack_2d.h"
#include "BLI_span.hh"
#include "DNA_vec_types.h"
Like the other public headers in the geometry module, I think this should all be in the
blender::geometry
namespace. That's what's used here instead of theGEO
prefix that would be used for C code. It also means theblender::
namespace doesn't have to be specified every time in the new cc file.Looks good now, thanks.
@ -0,0 +18,4 @@
};
/** See also #UnwrapOptions. */
struct UVPackIsland_Params {
I'd put these in the namespace too, for consistency, not a big deal though.