Animation: Remove the 'Weight Paint: Fix Deforms' operator #105237

Merged
Sybren A. Stüvel merged 2 commits from dr.sybren/blender:remove-fix-deforms into main 2023-03-02 16:58:25 +01:00

The code of the 'Fix Deforms' operator was hard to read and inefficient, doing O(num_vertices * num_vertex_groups) evaluations of the mesh. It caused multiple issues and got in the way of improvements to Blender, and seems to be used very little (if ever).

It was decided in last week's module meeting that this operator should be removed.

There is one static function that's no longer used but kept for now: static bool vertex_group_mesh_with_dvert_poll(bContext *C) which returns true if there is a vertex group that's actually used for deformation. If we're going to make a replacement operator for smoothing out vertex weights for deformations, this might come in handy. #105238 has been created to remind us that this function is there and might need deletion after all.

The code of the 'Fix Deforms' operator was hard to read and inefficient, doing `O(num_vertices * num_vertex_groups)` evaluations of the mesh. It caused multiple issues and got in the way of improvements to Blender, and seems to be used very little (if ever). It was decided in [last week's module meeting](https://devtalk.blender.org/t/2023-02-23-animation-rigging-meeting/27757#patch-review-decision-time-5) that this operator should be removed. There is one static function that's no longer used but kept for now: `static bool vertex_group_mesh_with_dvert_poll(bContext *C)` which returns `true` if there is a vertex group that's actually used for deformation. If we're going to make a replacement operator for smoothing out vertex weights for deformations, this might come in handy. #105238 has been created to remind us that this function is there and might need deletion after all.
Sybren A. Stüvel added the
Module
Animation & Rigging
Interest
Modeling
labels 2023-02-27 11:55:04 +01:00
Sybren A. Stüvel added this to the Animation & Rigging project 2023-02-27 11:55:11 +01:00
Sybren A. Stüvel changed title from WIP: Remove the 'Weight Paint: Fix Deforms' operator to Remove the 'Weight Paint: Fix Deforms' operator 2023-02-27 11:58:20 +01:00
Sybren A. Stüvel requested review from Hans Goudey 2023-02-27 11:58:44 +01:00
Sybren A. Stüvel requested review from Christoph Lendenfeld 2023-02-27 11:58:44 +01:00
Hans Goudey approved these changes 2023-02-27 13:58:14 +01:00
Hans Goudey left a comment
Member

Better to just remove that function IMO-- it's checking for an invalid state (vertex group names should be removed by Blender when vertex group data is removed). But that matters very little compared to getting rid of everything else!

Better to just remove that function IMO-- it's checking for an invalid state (vertex group names should be removed by Blender when vertex group data is removed). But that matters very little compared to getting rid of everything else!
Hans Goudey changed title from Remove the 'Weight Paint: Fix Deforms' operator to Animation: Remove the 'Weight Paint: Fix Deforms' operator 2023-02-28 16:05:47 +01:00
Christoph Lendenfeld approved these changes 2023-03-02 10:25:15 +01:00
Christoph Lendenfeld left a comment
Member

let's get rid of it

let's get rid of it
Sybren A. Stüvel force-pushed remove-fix-deforms from e5fee0bf74 to d8293806b6 2023-03-02 16:56:45 +01:00 Compare
Author
Member

Better to just remove that function IMO-- it's checking for an invalid state (vertex group names should be removed by Blender when vertex group data is removed).

That's good enough a reason for me to remove the code.

> Better to just remove that function IMO-- it's checking for an invalid state (vertex group names should be removed by Blender when vertex group data is removed). That's good enough a reason for me to remove the code.
Sybren A. Stüvel merged commit f5c56b4cd6 into main 2023-03-02 16:58:25 +01:00
Sybren A. Stüvel deleted branch remove-fix-deforms 2023-03-02 16:58:26 +01:00
Sybren A. Stüvel removed this from the Animation & Rigging project 2023-03-02 16:59:42 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105237
No description provided.