Fix #105216: Clear Asset does not immediately redraw the outliner #105287

Philipp Oeser · 2023-02-28T10:08:47+01:00

Philipp Oeser commented

2023-02-28 10:08:47 +01:00

While marking an asset would update the Outliner immediately (this
due to the fact that ED_asset_generate_preview indirectly took care of
a refresh), clearing an asset would not do this.

Now be explicit about this in the Outliner listener and consider asset
notifiers there.

While **marking** an asset would update the Outliner immediately (this due to the fact that `ED_asset_generate_preview` indirectly took care of a refresh), **clearing** an asset would not do this. Now be explicit about this in the Outliner listener and consider asset notifiers there.

🎉 2

Philipp Oeser added this to the Pipeline, Assets & IO project 2023-02-28 10:09:20 +01:00

Philipp Oeser requested review from Julian Eisel 2023-02-28 10:09:35 +01:00

Brecht Van Lommel approved these changes 2023-03-10 14:01:55 +01:00

Julian Eisel approved these changes 2023-03-15 11:42:56 +01:00

source/blender/editors/space_outliner/space_outliner.cc Outdated

						
				@ -197,1 +197,4 @@

				      break;

				    case NC_ASSET:

				      if (ELEM(wmn->action, NA_ADDED, NA_REMOVED)) {

				        ED_region_tag_redraw(region);

Julian Eisel commented

2023-03-15 11:41:04 +01:00

Would suggest using ED_region_tag_redraw_no_rebuild(). Just the icon needs updating, not the entire tree.

Would suggest using `ED_region_tag_redraw_no_rebuild()`. Just the icon needs updating, not the entire tree.

lichtwerk marked this conversation as resolved

Philipp Oeser force-pushed 105216 from 147c608624 to 3afba4c84a

2023-03-17 11:50:22 +01:00

Compare

Philipp Oeser reviewed 2023-03-17 11:52:00 +01:00

source/blender/editors/space_outliner/space_outliner.cc

						
				@ -197,1 +197,4 @@

				      break;

				    case NC_ASSET:

				      if (ELEM(wmn->action, NA_ADDED, NA_REMOVED)) {

				        ED_region_tag_redraw_no_rebuild(region);